This is a list of all comments for UI-DEN-10424-1.

Review Summary: No summary


----------------------------------------
File: sources/model/hd/alarm/MAlarmTriggered.cpp
Revision Comment by pmontazemi on 11 October 2021, 13:18 
https://devapps.diality.us/cru/UI-DEN-10424-1#c10870

  Where was this code moved to or was it dead  code laying
  around?

  Reply by Behrouz NematiPour on 11 October 2021, 13:35
  > Since we have more than one message which is using the
  > dynamic structure now we have a "MAbstractDynamic" model
  > (link bellow) as the parent and these codes have been moved
  > to the parent and all the 3 messages are using the same
  > structure.
  > http://dvm-linux02:8060/cru/UI-DEN-10424-1#CFR-27600

    Reply by pmontazemi on 11 October 2021, 13:47
    > RESOLVED.


---

ID: UI-DEN-10424-1 https://devapps.diality.us/cru/UI-DEN-10424-1

Title: UI-DEN-10424_FW Request A4 A5 Msg Log
Statement of Objectives:
commit : [161d1431|http://192.168.10.132:7990/projects/UI/repos/application/commits/161d1431] - DEN-9968: GUI does not indicate the amount of time the device has been stopped in pre-treatment & treatment

 - Added message ID_TreatmentStop = 0x4900, // 73 and its Model, View
 - Added a timer on the Alarm Dialog which is visible in Treatment Stop and if the message above has a total value.
commit : [b94c297f|http://192.168.10.132:7990/projects/UI/repos/application/commits/b94c297f] - Part 2/2: Added the two new General HD/DG messages


commit : [1f89cfbb|http://192.168.10.132:7990/projects/UI/repos/application/commits/1f89cfbb] - DEN-10161: Missing END TREATMENT option in Treatment-Recirculate-Stop screen

 - The screen (Reconnect) belongs to the TREATMENT_RECIRC_STOPPED_STATE state of the TREATMENT_RECIRC_STATE in the TREATMENT_STATE message, didn't even have a "END TREATMENT" button, which has been added.
 - The time_IsLeft logic has NOT been removed yet, since I don't recall why it has been used in the first place.
commit : [338575f7|http://192.168.10.132:7990/projects/UI/repos/application/commits/338575f7] - Part 2/2: make the Alarm Triggered messages modification

 - Created a class named MAbstractDynamic which is the base class of the dynamic model classes.
 + Dynamic Model classes are the ones with field descriptor (FD) and a data field (DF) after that which the data type in the data field is defined by field descriptor.
 + This combination for now is only for 2 set of FD, DF only.
 - Made the Alarm Triggered inherit from MAbstractDynamic.
commit : [67d05211|http://192.168.10.132:7990/projects/UI/repos/application/commits/67d05211] - Updated AlarmMapping


commit : [cbb246d6|http://192.168.10.132:7990/projects/UI/repos/application/commits/cbb246d6] - Part 1/2: make the unhandled messages dynamic

 - The messages/unhandled.conf has been created in the settings area and will be loaded and used for the unhandled messages in the message interpreter.

State: Closed

Summary: 

Author: Behrouz NematiPour
Moderator: Behrouz NematiPour
Reviewers: (0 active, 2 completed*)
     Sean Nash   (*)
     pmontazemi   (*)