UI-DEN-1090_UI Message Handler / Error Handler

Activity

UI-DEN-1090-1 56

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author & Moderator 1h 50m 19 I aligned the m(s) so I'm sure that I'm using the corre...
    Reviewer - Complete 28m 4 RESOLVED
    pmontazemi  (deleted user)
    Reviewer completed
    Reviewer - Complete 24m 33 RESOLVED.
    lbaloa  (deleted user)
    Reviewer completed
    Reviewer - Complete 16m    
    Reviewer - 0% reviewed      
    Reviewer - 0% reviewed      
    Reviewer - 0% reviewed      
    vduong  (deleted user)
    Reviewer - 0% reviewed      
    msuleiman  (deleted user)
    Reviewer - 0% reviewed      
    Total   2h 59m 56  
    #permalink

    Objectives

    There are no specific objectives for this review.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    There are no general comments on this review.
    /sources/canbus/caninterface.cpp Changed 3
    /sources/canbus/caninterface.h Changed
    /sources/canbus/frameinterface.cpp Added 3
    /sources/canbus/frameinterface.h Added 3
    /sources/canbus/messagebuilder.cpp Added 18
    /sources/canbus/messagebuilder.h Added 3
    /sources/canbus/messagedispatcher.cpp Added
    /sources/canbus/messagedispatcher.h Added
    /sources/canbus/messageglobals.h Added
    /sources/canbus/messagehandler.cpp Deleted
    Open in IDE #permalink
    /sources/canbus/messagehandler.h Deleted
    Open in IDE #permalink
    /sources/canbus/messageinterface.cpp Deleted
    Open in IDE #permalink
    /sources/canbus/messageinterface.h Deleted
    Open in IDE #permalink
    /sources/canbus/messageinterpreter.cpp Added 5
    /sources/canbus/messageinterpreter.h Added
    /sources/canbus/messagepartitioner.cpp Deleted
    Open in IDE #permalink
    /sources/canbus/messagepartitioner.h Deleted
    Open in IDE #permalink
    /sources/configuration/display.cpp Changed
    Open in IDE #permalink
    /sources/configuration/display.h Changed
    Open in IDE #permalink
    /sources/configuration/sound.cpp Changed
    Open in IDE #permalink
    /sources/configuration/sound.h Changed
    Open in IDE #permalink
    /sources/gui/qml/components/BackButton.qml Changed
    Open in IDE #permalink
    /sources/gui/qml/components/LogoD.qml Changed
    Open in IDE #permalink
    /sources/gui/qml/components/MainMenu.qml Changed
    Open in IDE #permalink
    /sources/gui/.../components/ModalDialog.qml Changed
    /sources/gui/qml/components/ScreenItem.qml Changed
    Open in IDE #permalink
    /sources/gui/qml/components/StackItem.qml Changed
    Open in IDE #permalink
    /sources/gui/qml/components/TitleText.qml Changed
    Open in IDE #permalink
    /sources/gui/qml/components/TouchRect.qml Changed
    /sources/gui/qml/dialogs/PowerOff.qml Changed
    Open in IDE #permalink
    /sources/gui/qml/globals/Colors.qml Changed
    Open in IDE #permalink
    /sources/gui/qml/globals/Fonts.qml Changed
    Open in IDE #permalink
    /sources/gui/qml/globals/Variables.qml Changed
    Open in IDE #permalink
    /sources/gui/qml/pages/ManagerHome.qml Changed
    Open in IDE #permalink
    /sources/gui/qml/pages/ManagerStack.qml Changed
    Open in IDE #permalink
    /sources/gui/qml/pages/SettingsHome.qml Changed
    /sources/gui/qml/pages/SettingsStack.qml Changed
    Open in IDE #permalink
    /sources/gui/qml/pages/TreatmentCreate.qml Changed
    Open in IDE #permalink
    /sources/gui/qml/pages/TreatmentHome.qml Changed
    Open in IDE #permalink
    /sources/gui/qml/pages/TreatmentStack.qml Changed
    Open in IDE #permalink
    /sources/gui/qml/pages/TreatmentStart.qml Changed
    /sources/gui/qml/main.qml Changed
    /sources/gui/guiactions.cpp Deleted
    Open in IDE #permalink
    /sources/gui/guiactions.h Deleted
    Open in IDE #permalink
    /sources/gui/guicontroller.cpp Changed
    /sources/gui/guicontroller.h Changed
    /sources/gui/guiglobals.cpp Changed
    /sources/gui/guiglobals.h Changed
    /sources/gui/guiview.cpp Changed
    /sources/gui/guiview.h Changed
    /sources/storage/filehandler.cpp Changed
    Open in IDE #permalink
    /sources/storage/filehandler.h Changed
    Open in IDE #permalink
    /sources/storage/logger.cpp Changed
    Open in IDE #permalink
    /sources/storage/logger.h Changed
    Open in IDE #permalink
    /sources/storage/settings.cpp Changed
    Open in IDE #permalink
    /sources/storage/settings.h Changed
    Open in IDE #permalink
    /sources/utility/crc.cpp Added
    /sources/utility/crc.h Added
    Open in IDE #permalink
    /sources/utility/format.cpp Added
    /sources/utility/format.h Added
    /sources/utility/types.cpp Added 3
    /sources/utility/types.h Added
    /sources/applicationcontroller.cpp Changed
    /sources/applicationcontroller.h Changed
    /sources/applicationpost.cpp Changed
    Open in IDE #permalink
    /sources/applicationpost.h Changed
    Open in IDE #permalink
    /sources/main.h Changed
    Open in IDE #permalink
    /sources/maintimer.cpp Changed 3
    /sources/maintimer.h Changed
    /unittests/tst_canbus.cpp Added 9
    /unittests/tst_canbus.h Added
    Open in IDE #permalink
    /unittests/unittests.cpp Deleted
    Open in IDE #permalink
    /unittests/unittests.h Deleted
    Open in IDE #permalink
    /.gitignore Changed
    /cppcheck.log Changed
    /cppcheck.sh Changed
    /denali.pro Changed
    /denali.pro.user Added
    Open in IDE #permalink
    /main.cpp Changed 6

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time