This is a list of all comments for UI-DEN-12121-1.

Review Summary: No summary


----------------------------------------
File: sources/gui/qml/dialogs/DiagnosticsDialog.qml
Revision Comment by Behrouz NematiPour on 03 March 2022, 23:02 
https://devapps.diality.us/cru/UI-DEN-12121-1#c12337

  remove the empty line.

  Reply by Behrouz NematiPour on 09 March 2022, 16:31
  > RESOLVED
  > I fixed it in [my own
  > branch|http://dvm-linux02:7990/projects/UI/repos/application/commits/b50bbd0e8ab67f7752092a8a0460c5298ed02ef6]
  > and merged it into the [develop
  > branch|http://dvm-linux02:7990/projects/UI/repos/application/commits/e4b0d67d48be9c5a726c0568da1acdb511d49a38].

Revision Comment by Behrouz NematiPour on 03 March 2022, 19:11 
https://devapps.diality.us/cru/UI-DEN-12121-1#c12335

  HD Accelerometer is not being used anymore?
  If so we should put a TODO comment to remove the model/view
  later to keep the Application lighter.

  Reply by Behrouz NematiPour on 09 March 2022, 16:33
  > RESOLVED
  > I fixed it in [my own
  > branch|http://dvm-linux02:7990/projects/UI/repos/application/commits/b50bbd0e8ab67f7752092a8a0460c5298ed02ef6]
  > and merged it into the [develop
  > branch|http://dvm-linux02:7990/projects/UI/repos/application/commits/e4b0d67d48be9c5a726c0568da1acdb511d49a38].

Revision Comment by Behrouz NematiPour on 03 March 2022, 19:10 
https://devapps.diality.us/cru/UI-DEN-12121-1#c12334

  DG Accelerometer is not being used anymore?
  If so we should put a TODO comment to remove the model/view
  later to keep the Application lighter.

  Reply by Behrouz NematiPour on 09 March 2022, 16:33
  > RESOLVED
  > I fixed it in [my own
  > branch|http://dvm-linux02:7990/projects/UI/repos/application/commits/b50bbd0e8ab67f7752092a8a0460c5298ed02ef6]
  > and merged it into the [develop
  > branch|http://dvm-linux02:7990/projects/UI/repos/application/commits/e4b0d67d48be9c5a726c0568da1acdb511d49a38].

Revision Comment by Behrouz NematiPour on 03 March 2022, 19:09 
https://devapps.diality.us/cru/UI-DEN-12121-1#c12333

  please remove the empty line.

  Reply by Behrouz NematiPour on 09 March 2022, 16:33
  > RESOLVED
  > I fixed it in [my own
  > branch|http://dvm-linux02:7990/projects/UI/repos/application/commits/b50bbd0e8ab67f7752092a8a0460c5298ed02ef6]
  > and merged it into the [develop
  > branch|http://dvm-linux02:7990/projects/UI/repos/application/commits/e4b0d67d48be9c5a726c0568da1acdb511d49a38].

Revision Comment by Behrouz NematiPour on 03 March 2022, 18:56 
https://devapps.diality.us/cru/UI-DEN-12121-1#c12330

  Don't see why the CRev is necessary?
  
  Also, formatting doesn't make sense to me.
  fpgaID is in between HD and FPGA versions !!!
  
  I think it should be like:
  v<hdMajor(%1)>.<hdMinor(%2)>.<hdMicro(%3)>.<hdBuild(%4)><'
  '>v<fpgaID(%5)>.<fpgaMajor(%6)>.<fpgaMinor(%7)>.<fpgaLab(%8)><'
  - '><compRev(%9)>
  
  or move the fpgaID at the end of the FPGA versions.

  Reply by Behrouz NematiPour on 09 March 2022, 16:32
  > RESOLVED
  > I fixed it in [my own
  > branch|http://dvm-linux02:7990/projects/UI/repos/application/commits/b50bbd0e8ab67f7752092a8a0460c5298ed02ef6]
  > and merged it into the [develop
  > branch|http://dvm-linux02:7990/projects/UI/repos/application/commits/e4b0d67d48be9c5a726c0568da1acdb511d49a38].

Revision Comment by Behrouz NematiPour on 03 March 2022, 19:07 
https://devapps.diality.us/cru/UI-DEN-12121-1#c12331

  Same as hd version
  please consult with the users of this information.

  Reply by Behrouz NematiPour on 09 March 2022, 16:34
  > RESOLVED
  > I fixed it in [my own
  > branch|http://dvm-linux02:7990/projects/UI/repos/application/commits/b50bbd0e8ab67f7752092a8a0460c5298ed02ef6]
  > and merged it into the [develop
  > branch|http://dvm-linux02:7990/projects/UI/repos/application/commits/e4b0d67d48be9c5a726c0568da1acdb511d49a38].

Revision Comment by Behrouz NematiPour on 03 March 2022, 19:08 
https://devapps.diality.us/cru/UI-DEN-12121-1#c12332

  Please remove the extra empty line.

  Reply by Behrouz NematiPour on 09 March 2022, 16:34
  > RESOLVED
  > I fixed it in [my own
  > branch|http://dvm-linux02:7990/projects/UI/repos/application/commits/b50bbd0e8ab67f7752092a8a0460c5298ed02ef6]
  > and merged it into the [develop
  > branch|http://dvm-linux02:7990/projects/UI/repos/application/commits/e4b0d67d48be9c5a726c0568da1acdb511d49a38].

----------------------------------------
File: sources/model/hd/data/treatment/MTreatmentStatesData.h
Revision Comment by Behrouz NematiPour on 02 March 2022, 15:54 
https://devapps.diality.us/cru/UI-DEN-12121-1#c12233

  [~snash],
  How the change to the TreatmentState message will affect the
  Application?
  This newly added parameter seems redundant to me.
  
  The change is the "Dialysis State" addition.
  |10 - (U32) Dialysis state { 0=start, 1=UF, 2=saline bolus }|
  
  |0x0F00	|15	|0x040	|4 Hz	|N	|HD	|All	|Treatment State	|sub-mode
  (U32-enum)| (U32) UF state	|(U32) saline bolus state |(U32) Hep
  state |(U32) Rinseback state|(U32) Recirc state|7 - (U32) Bld
  Prime state|8 - (U32) Tx End state|9 - (U32) Stop state|10 -
  (U32) Dialysis state|

  Reply by Sean Nash on 03 March 2022, 16:55
  > Let's keep it.

    Reply by Behrouz NematiPour on 03 March 2022, 18:23
    > RESOLVED.
    > The Application will not use that new parameter though.

----------------------------------------
File: sources/canbus/MessageGlobals.h
Revision Comment by Behrouz NematiPour on 02 March 2022, 16:47 
https://devapps.diality.us/cru/UI-DEN-12121-1#c12249

  This needs to be updated to 10 * 4 if the change to the
  "TreatmentStates" is approved by [~snash].
  Also please remove the duplicate.

  Reply by Michael Garthwaite on 02 March 2022, 17:43
  > Fixed. Thanks!

    Reply by Behrouz NematiPour on 03 March 2022, 10:21
    > RESOLVED.

Revision Comment by Behrouz NematiPour on 02 March 2022, 15:34 
https://devapps.diality.us/cru/UI-DEN-12121-1#c12227

  This message has been defined with 5xF32 parameters.
  |0x3100	|49	|0x080	|1 Hz	|N	|DG	|All	|DG Conductivity Data
  |(F32) RO rejection ratio	|(F32) CPi conductivity	|(F32) CPo
  conductivity	|(F32) CD1 conductivity	|(F32) CD2 conductivity|

  Reply by Michael Garthwaite on 02 March 2022, 17:44
  > Fixed. Thanks!

    Reply by Behrouz NematiPour on 03 March 2022, 10:21
    > RESOLVED.

----------------------------------------
File: sources/gui/qml/main.qml
Revision Comment by Behrouz NematiPour on 02 March 2022, 15:41 
https://devapps.diality.us/cru/UI-DEN-12121-1#c12228

  Why VAlarmStatus is added?

  Reply by Michael Garthwaite on 02 March 2022, 15:45
  > Required to display the Alarm Top on the diagnostic screen

    Reply by Behrouz NematiPour on 02 March 2022, 15:46
    > it has already been defined, this would be a duplicate
    > handler.
    > why do we need to have the top on diagnostics while it has
    > to always be on alarm dialog/bar on screen?

      Reply by Michael Garthwaite on 02 March 2022, 15:54
      > Users can not see the alarm screen when the diagnostics
      > screen is visible. This was a request by systems in
      > DEN-12118. Is there another approach to this?

        Reply by Behrouz NematiPour on 02 March 2022, 16:10
        > It has been defined in the AlarmItem.
        > Expose the VAlarmStatus property from AlarmItem.qml by
        > adding this line:
        > {code}
        >     readonly property alias alarm_AlarmID :
        > vAlarmStatus.alarm_AlarmID
        > {code}
        > 
        > then use the AlarmItem object, (which has been defined
        > in the main.qml) to get the alarm id like the line
        > below:
        > {code}
        > _alarmItem.alarm_AlarmID
        > {code}
        > 
        > Thanks,

          Reply by Michael Garthwaite on 02 March 2022, 17:44
          > Fixed. Thanks!

          Reply by Behrouz NematiPour on 03 March 2022, 10:23
          > RESOLVED.

----------------------------------------
File: sources/view/dg/data/VDGValvesStatesData.h
Revision Comment by Behrouz NematiPour on 03 March 2022, 19:16 
https://devapps.diality.us/cru/UI-DEN-12121-1#c12336

  The message is a U16 and each valve is a bit, and it's not
  clear to me why the type has been changed from bool to a very
  big uint32 type?
  Although it was defined as boolean, qml was showing it as an
  int value, so what are we going to achieve here?

  Reply by Behrouz NematiPour on 09 March 2022, 16:30
  > RESOLVED
  > I fixed it in [my own
  > branch|http://dvm-linux02:7990/projects/UI/repos/application/commits/b50bbd0e8ab67f7752092a8a0460c5298ed02ef6]
  > and merged it into the [develop
  > branch|http://dvm-linux02:7990/projects/UI/repos/application/commits/e4b0d67d48be9c5a726c0568da1acdb511d49a38].

----------------------------------------
File: sources/view/hd/data/VHDAirBubbleData.cpp
Revision Comment by Behrouz NematiPour on 03 March 2022, 23:30 
https://devapps.diality.us/cru/UI-DEN-12121-1#c12351

  remove the empty line.
  lower the column alignment spaces.

  Reply by Behrouz NematiPour on 09 March 2022, 16:00
  > RESOLVED
  > I fixed it in [my own
  > branch|http://dvm-linux02:7990/projects/UI/repos/application/commits/b50bbd0e8ab67f7752092a8a0460c5298ed02ef6]
  > and merged it into the [develop
  > branch|http://dvm-linux02:7990/projects/UI/repos/application/commits/e4b0d67d48be9c5a726c0568da1acdb511d49a38].

----------------------------------------
File: sources/view/hd/data/VHDAirBubbleData.h
Revision Comment by Behrouz NematiPour on 03 March 2022, 23:29 
https://devapps.diality.us/cru/UI-DEN-12121-1#c12350

  please align
  & empty line

  Reply by Behrouz NematiPour on 09 March 2022, 16:19
  > RESOLVED
  > I fixed it in [my own
  > branch|http://dvm-linux02:7990/projects/UI/repos/application/commits/b50bbd0e8ab67f7752092a8a0460c5298ed02ef6]
  > and merged it into the [develop
  > branch|http://dvm-linux02:7990/projects/UI/repos/application/commits/e4b0d67d48be9c5a726c0568da1acdb511d49a38].

----------------------------------------
File: sources/view/hd/data/VHDAirTrapData.cpp
Revision Comment by Behrouz NematiPour on 03 March 2022, 23:28 
https://devapps.diality.us/cru/UI-DEN-12121-1#c12349

  Please align
  remove the empty line.

  Reply by Behrouz NematiPour on 09 March 2022, 16:20
  > RESOLVED
  > I fixed it in [my own
  > branch|http://dvm-linux02:7990/projects/UI/repos/application/commits/b50bbd0e8ab67f7752092a8a0460c5298ed02ef6]
  > and merged it into the [develop
  > branch|http://dvm-linux02:7990/projects/UI/repos/application/commits/e4b0d67d48be9c5a726c0568da1acdb511d49a38].

----------------------------------------
File: sources/view/hd/data/VHDAirTrapData.h
Revision Comment by Behrouz NematiPour on 03 March 2022, 23:27 
https://devapps.diality.us/cru/UI-DEN-12121-1#c12348

  remove empty

  Reply by Behrouz NematiPour on 09 March 2022, 16:20
  > RESOLVED
  > I fixed it in [my own
  > branch|http://dvm-linux02:7990/projects/UI/repos/application/commits/b50bbd0e8ab67f7752092a8a0460c5298ed02ef6]
  > and merged it into the [develop
  > branch|http://dvm-linux02:7990/projects/UI/repos/application/commits/e4b0d67d48be9c5a726c0568da1acdb511d49a38].

----------------------------------------
File: sources/view/hd/data/VHDBloodLeakData.h
Revision Comment by Behrouz NematiPour on 03 March 2022, 23:26 
https://devapps.diality.us/cru/UI-DEN-12121-1#c12347

  remove empty line.

  Reply by Behrouz NematiPour on 09 March 2022, 16:20
  > RESOLVED
  > I fixed it in [my own
  > branch|http://dvm-linux02:7990/projects/UI/repos/application/commits/b50bbd0e8ab67f7752092a8a0460c5298ed02ef6]
  > and merged it into the [develop
  > branch|http://dvm-linux02:7990/projects/UI/repos/application/commits/e4b0d67d48be9c5a726c0568da1acdb511d49a38].

----------------------------------------
File: sources/gui/GuiGlobals.h
Revision Comment by Behrouz NematiPour on 02 March 2022, 15:42 
https://devapps.diality.us/cru/UI-DEN-12121-1#c12229

  keep one line empty on top of the // HD Data Messages

  Reply by Michael Garthwaite on 02 March 2022, 17:43
  > Fixed. Thanks!

    Reply by Behrouz NematiPour on 03 March 2022, 10:21
    > RESOLVED.

----------------------------------------
File: sources/model/hd/data/treatment/MTreatmentRinsebackData.h
Revision Comment by Behrouz NematiPour on 03 March 2022, 23:08 
https://devapps.diality.us/cru/UI-DEN-12121-1#c12338

  This seems a big type for just a boolean value to me.
  Please check the FW code as well.

  Reply by Behrouz NematiPour on 09 March 2022, 16:31
  > RESOLVED
  > I fixed it in [my own
  > branch|http://dvm-linux02:7990/projects/UI/repos/application/commits/b50bbd0e8ab67f7752092a8a0460c5298ed02ef6]
  > and merged it into the [develop
  > branch|http://dvm-linux02:7990/projects/UI/repos/application/commits/e4b0d67d48be9c5a726c0568da1acdb511d49a38].

----------------------------------------
File: sources/view/hd/data/treatment/VTreatmentRinsebackData.h
Revision Comment by Behrouz NematiPour on 03 March 2022, 23:10 
https://devapps.diality.us/cru/UI-DEN-12121-1#c12339

  There is a comment in the model.
  I that changes please don't forget to fix this as well.

  Reply by Behrouz NematiPour on 09 March 2022, 16:30
  > RESOLVED
  > I fixed it in [my own
  > branch|http://dvm-linux02:7990/projects/UI/repos/application/commits/b50bbd0e8ab67f7752092a8a0460c5298ed02ef6]
  > and merged it into the [develop
  > branch|http://dvm-linux02:7990/projects/UI/repos/application/commits/e4b0d67d48be9c5a726c0568da1acdb511d49a38].

----------------------------------------
File: sources/model/dg/data/MDGConductivityData.h
Revision Comment by Behrouz NematiPour on 02 March 2022, 16:38 
https://devapps.diality.us/cru/UI-DEN-12121-1#c12247

  Please remove the box column, we decided not to use it in the
  Application documentation.
  Please do this for all the new models added.

  Reply by Michael Garthwaite on 02 March 2022, 17:43
  > Fixed. Thanks!

    Reply by Behrouz NematiPour on 03 March 2022, 10:21
    > RESOLVED.

----------------------------------------
File: sources/model/hd/data/MHDAirBubbleData.h
Revision Comment by Behrouz NematiPour on 03 March 2022, 23:16 
https://devapps.diality.us/cru/UI-DEN-12121-1#c12341

  - Fix the Src, Should be HD.
   - Fix the CAN ID, should be 0x040

  Reply by Behrouz NematiPour on 09 March 2022, 16:31
  > RESOLVED
  > I fixed it in [my own
  > branch|http://dvm-linux02:7990/projects/UI/repos/application/commits/b50bbd0e8ab67f7752092a8a0460c5298ed02ef6]
  > and merged it into the [develop
  > branch|http://dvm-linux02:7990/projects/UI/repos/application/commits/e4b0d67d48be9c5a726c0568da1acdb511d49a38].

Revision Comment by Behrouz NematiPour on 03 March 2022, 23:12 
https://devapps.diality.us/cru/UI-DEN-12121-1#c12340

  the "Data" is redundant.
  in the log, there is a section for the type if is data will be
  ",D,"
  Please, update all the other models and the "| infoText|" in
  the header documents as well.

  Reply by Behrouz NematiPour on 09 March 2022, 16:34
  > I fixed it in [my own
  > branch|http://dvm-linux02:7990/projects/UI/repos/application/commits/b50bbd0e8ab67f7752092a8a0460c5298ed02ef6]
  > and merged it into the [develop
  > branch|http://dvm-linux02:7990/projects/UI/repos/application/commits/e4b0d67d48be9c5a726c0568da1acdb511d49a38].

    Reply by Dara Navaei on 19 October 2023, 10:39
    > RESOLVED

----------------------------------------
File: sources/model/hd/data/MHDAirTrapData.h
Revision Comment by Behrouz NematiPour on 03 March 2022, 23:19 
https://devapps.diality.us/cru/UI-DEN-12121-1#c12342

  fix the Src, and CAN ID.

  Reply by Behrouz NematiPour on 09 March 2022, 16:31
  > RESOLVED
  > I fixed it in [my own
  > branch|http://dvm-linux02:7990/projects/UI/repos/application/commits/b50bbd0e8ab67f7752092a8a0460c5298ed02ef6]
  > and merged it into the [develop
  > branch|http://dvm-linux02:7990/projects/UI/repos/application/commits/e4b0d67d48be9c5a726c0568da1acdb511d49a38].

Revision Comment by Behrouz NematiPour on 03 March 2022, 23:19 
https://devapps.diality.us/cru/UI-DEN-12121-1#c12343

  remove Data, and fix infoText in doc.

  Reply by Behrouz NematiPour on 09 March 2022, 16:33
  > RESOLVED
  > I fixed it in [my own
  > branch|http://dvm-linux02:7990/projects/UI/repos/application/commits/b50bbd0e8ab67f7752092a8a0460c5298ed02ef6]
  > and merged it into the [develop
  > branch|http://dvm-linux02:7990/projects/UI/repos/application/commits/e4b0d67d48be9c5a726c0568da1acdb511d49a38].

----------------------------------------
File: sources/model/hd/data/MHDBloodLeakData.h
Revision Comment by Behrouz NematiPour on 03 March 2022, 23:20 
https://devapps.diality.us/cru/UI-DEN-12121-1#c12344

  Fix #9 to #10

  Reply by Behrouz NematiPour on 09 March 2022, 16:21
  > RESOLVED
  > I fixed it in [my own
  > branch|http://dvm-linux02:7990/projects/UI/repos/application/commits/b50bbd0e8ab67f7752092a8a0460c5298ed02ef6]
  > and merged it into the [develop
  > branch|http://dvm-linux02:7990/projects/UI/repos/application/commits/e4b0d67d48be9c5a726c0568da1acdb511d49a38].

Revision Comment by Behrouz NematiPour on 03 March 2022, 23:22 
https://devapps.diality.us/cru/UI-DEN-12121-1#c12345

  remove Data, and fix infoText in doc.

  Reply by Behrouz NematiPour on 09 March 2022, 16:30
  > I fixed it in [my own
  > branch|http://dvm-linux02:7990/projects/UI/repos/application/commits/b50bbd0e8ab67f7752092a8a0460c5298ed02ef6]
  > and merged it into the [develop
  > branch|http://dvm-linux02:7990/projects/UI/repos/application/commits/e4b0d67d48be9c5a726c0568da1acdb511d49a38].

    Reply by Dara Navaei on 19 October 2023, 11:03
    > RESOLVED

----------------------------------------
File: sources/view/dg/data/VDGConductivityData.h
Revision Comment by Behrouz NematiPour on 03 March 2022, 23:25 
https://devapps.diality.us/cru/UI-DEN-12121-1#c12346

  Remove empty line.

  Reply by Behrouz NematiPour on 09 March 2022, 16:20
  > RESOLVED
  > I fixed it in [my own
  > branch|http://dvm-linux02:7990/projects/UI/repos/application/commits/b50bbd0e8ab67f7752092a8a0460c5298ed02ef6]
  > and merged it into the [develop
  > branch|http://dvm-linux02:7990/projects/UI/repos/application/commits/e4b0d67d48be9c5a726c0568da1acdb511d49a38].


---

ID: UI-DEN-12121-1 https://devapps.diality.us/cru/UI-DEN-12121-1

Title: UI-DEN-12121_SW Dev Sprint 65
Statement of Objectives:


State: Closed

Summary: 

Author: Michael Garthwaite
Moderator: Michael Garthwaite
Reviewers: (1 active, 2 completed*)
     Dara Navaei   (*)
     Behrouz NematiPour   (*)
     Sean Nash