UI-DEN-12258-1 UI-DEN-12258_UI BN S66

closed on 09 May 22

Author

Moderator

Reviewers

UI-DEN-12258_UI BN S66

Activity

Details
Objectives
General Comments 0
Unresolved
Resolved
Number of files included: 197

application 0
- Folder sources 0
  - Folder bluetooth 0
    - File BluetoothInterface.cpp 0 Remove
    - File BluetoothInterface.h 0 Remove
  - Folder canbus 0
    - File CanInterface.cpp 4 Remove
    - File CanInterface.h 0 Remove
    - File FrameInterface.cpp 0 Remove
    - File FrameInterface.h 0 Remove
    - File MessageAcknowModel.cpp 0 Remove
    - File MessageAcknowModel.h 0 Remove
    - File MessageBuilder.cpp 0 Remove
    - File MessageDispatcher.cpp 0 Remove
    - File MessageDispatcher.h 0 Remove
    - File MessageGlobals.h 0 Remove
    - File MessageInterpreter.cpp 0 Remove
  - Folder cloudsync 0
    - File CloudSyncController.cpp 0 Remove
    - File CloudSyncController.h 0 Remove
  - Folder device 0
    - File DeviceController.cpp 0 Remove
    - File DeviceController.h 0 Remove
  - Folder gui 0
    - Folder qml 0
      - Folder components 0
        
        File DebugDataColumn.qml 0 Remove
        
        File GridSelection.qml 0 Remove
      - Folder dialogs 0
        
        File DiagnosticsDialog.qml 0 Remove
      - Folder pages 0
        
        Folder posttreatment 0
        
        File PostTreatmentReview.qml 0 Remove
        
        Folder pretreatment/create 0
        
        File PreTreatmentCreate.qml 0 Remove
        
        Folder treatment/sections 0
        
        File TreatmentFluid.qml 0 Remove
        
        File TreatmentHeparin.qml 0 Remove
      - Folder plugins/virtualkeyboard 0
        
        Folder layouts 0
        
        Folder en_GB 0
        
        File dialpad.qml 0 Remove
        
        File digits.qml 0 Remove
        
        File handwriting.qml 0 Remove
        
        File main.qml 0 Remove
        
        File numbers.qml 0 Remove
        
        File symbols.qml 0 Remove
        
        Folder en_US 0
        
        File dialpad.qml 0 Remove
        
        File digits.qml 0 Remove
        
        File handwriting.qml 0 Remove
        
        File main.qml 0 Remove
        
        File numbers.qml 0 Remove
        
        File symbols.qml 0 Remove
        
        Folder fallback 0
        
        File dialpad.qml 0 Remove
        
        File digits.qml 0 Remove
        
        File handwriting.qml 0 Remove
        
        File main.qml 0 Remove
        
        File numbers.qml 0 Remove
        
        File symbols.qml 0 Remove
        
        Folder styles/denali 0
        
        Folder images 0
        
        File backspace.svg 0 Remove
        
        File check.svg 0 Remove
        
        File enter.svg 0 Remove
        
        File globe.svg 0 Remove
        
        File handwriting.svg 0 Remove
        
        File hidekeyboard.svg 0 Remove
        
        File search.svg 0 Remove
        
        File selectionhandle.svg 0 Remove
        
        File shift-active.svg 0 Remove
        
        File shift-capslock.svg 0 Remove
        
        File shift-normal.svg 0 Remove
        
        File textmode.svg 0 Remove
        
        File style.qml 0 Remove
      - File AlarmItem.qml 0 Remove
      - File main.qml 0 Remove
    - File GuiController.cpp 0 Remove
    - File GuiController.h 0 Remove
    - File GuiGlobals.cpp 0 Remove
    - File GuiView.cpp 0 Remove
    - File GuiView.h 0 Remove
  - Folder model 0
    - Folder dg 0
      - Folder adjustment/settings 0
        
        File MAdjustDGRequests.h 0 Remove
      - Folder data 0
        
        Folder post 0
        
        File MDGPostFinalResultData.h 0 Remove
        
        File MDGPostSingleResultData.h 0 Remove
        
        File MDGAccelerometerData.cpp 0 Remove
        
        File MDGAccelerometerData.h 0 Remove
        
        File MDGConductivityData.h 0 Remove
        
        File MDGTemperaturesData.cpp 0 Remove
        
        File MDGTemperaturesData.h 0 Remove
        
        File MDGValvesStatesData.h 0 Remove
    - Folder hd 0
      - Folder adjustment 0
        
        Folder disinfect 0
        
        File MDisinfectAdjustRequests.h 0 Remove
        
        Folder posttreatment 0
        
        File MPostTreatmentAdjustRequests.h 0 Remove
        
        Folder pretreatment 0
        
        File MPreTreatmentAdjustRequests.h 0 Remove
        
        Folder settings 0
        
        File MAdjustHDRequests.h 0 Remove
        
        Folder treatment 0
        
        File MTreatmentAdjustRequests.h 0 Remove
      - Folder alarm 0
        
        File MAlarmActiveList.h 0 Remove
        
        File MAlarmClearedCondition.cpp 0 Remove
        
        File MAlarmClearedCondition.h 0 Remove
        
        File MAlarmMapping.cpp 0 Remove
        
        File MAlarmTriggered.cpp 0 Remove
        
        File MAlarmTriggered.h 0 Remove
      - Folder data 0
        
        Folder post 0
        
        File MHDPostFinalResultData.h 0 Remove
        
        File MHDPostSingleResultData.h 0 Remove
        
        Folder treatment 0
        
        File MTreatmentBloodPrimeData.h 0 Remove
        
        File MTreatmentHeparinData.h 0 Remove
        
        File MTreatmentRecirculateData.h 0 Remove
        
        File MTreatmentRinsebackData.cpp 0 Remove
        
        File MTreatmentRinsebackData.h 0 Remove
        
        File MTreatmentSalineData.h 0 Remove
        
        File MTreatmentStopData.h 0 Remove
        
        File MHDAccelerometerData.cpp 0 Remove
        
        File MHDAccelerometerData.h 0 Remove
        
        File MHDAirBubbleData.h 0 Remove
        
        File MHDAirTrapData.h 0 Remove
        
        File MHDBloodLeakData.h 0 Remove
        
        File MHDSyringePumpData.h 0 Remove
    - Folder settings 0
      - File MSettings.cpp 0 Remove
      - File MSettings.h 0 Remove
    - Folder ui/data 0
      - File MUIBloodPressureData.h 0 Remove
    - File MAbstractDynamic.cpp 0 Remove
    - File MAbstractDynamic.h 0 Remove
    - File MModel.h 0 Remove
  - Folder storage 0
    - File FileHandler.cpp 0 Remove
    - File Logger.cpp 0 Remove
    - File Logger.h 0 Remove
    - File Settings.cpp 0 Remove
    - File Settings.h 0 Remove
    - File TreatmentLog.cpp 0 Remove
    - File TreatmentLog.h 5 Remove
  - Folder utility 0
    - File format.cpp 0 Remove
    - File format.h 0 Remove
    - File types.h 0 Remove
  - Folder view 0
    - Folder dg/data 0
      - Folder post 0
        
        File VDGPOSTData.h 0 Remove
      - File VDGAccelerometerData.cpp 0 Remove
      - File VDGAccelerometerData.h 0 Remove
      - File VDGConductivityData.h 0 Remove
      - File VDGTemperaturesData.cpp 0 Remove
      - File VDGTemperaturesData.h 0 Remove
      - File VDGValvesStatesData.cpp 0 Remove
      - File VDGValvesStatesData.h 0 Remove
    - Folder hd 0
      - Folder adjustment 0
        
        Folder common 0
        
        File VCommonAdjustmentVitals.cpp 0 Remove
        
        File VCommonAdjustmentVitals.h 0 Remove
        
        Folder disinfect 0
        
        File VDisinfectAdjustChemicalConfirm.h 0 Remove
        
        File VDisinfectAdjustDisinfect.h 0 Remove
        
        Folder posttreatment 0
        
        File VPostTreatmentAdjustDisposablesRemovalConfirm.h 0 Remove
        
        File VPostTreatmentAdjustPatientDisconnectionConfirm.h 0 Remove
        
        File VPostTreatmentAdjustTreatmentLog.cpp 0 Remove
        
        File VPostTreatmentAdjustTreatmentLog.h 0 Remove
        
        Folder pretreatment 0
        
        File VPreTreatmentAdjustmentConsumablesConfirm.h 0 Remove
        
        File VPreTreatmentAdjustmentDisposablesConfirm.h 0 Remove
        
        File VPreTreatmentAdjustmentDisposablesPrime.h 0 Remove
        
        File VPreTreatmentAdjustmentInitTreatment.h 0 Remove
        
        File VPreTreatmentAdjustmentPatientConnectionBegin.h 0 Remove
        
        File VPreTreatmentAdjustmentPatientConnectionConfirm.h 0 Remove
        
        File VPreTreatmentAdjustmentStartTreatment.h 0 Remove
        
        File VPreTreatmentAdjustmentUltrafiltrationInit.h 0 Remove
        
        File VPreTreatmentAdjustmentWaterSample.h 0 Remove
        
        Folder treatment 0
        
        File VTreatmentAdjustmentDuration.h 0 Remove
        
        File VTreatmentAdjustmentEnd.h 0 Remove
        
        File VTreatmentAdjustmentFlows.h 0 Remove
        
        File VTreatmentAdjustmentHeparin.h 0 Remove
        
        File VTreatmentAdjustmentPressuresLimits.h 0 Remove
        
        File VTreatmentAdjustmentRecirculate.h 0 Remove
        
        File VTreatmentAdjustmentRinseback.h 0 Remove
        
        File VTreatmentAdjustmentSaline.h 0 Remove
        
        File VTreatmentAdjustmentUltrafiltrationConfirm.h 0 Remove
        
        File VTreatmentAdjustmentUltrafiltrationEdit.h 0 Remove
        
        File VTreatmentAdjustmentUltrafiltrationState.h 0 Remove
      - Folder alarm 0
        
        File VAlarmActiveList.h 0 Remove
        
        File VAlarmStatus.cpp 0 Remove
        
        File VAlarmStatus.h 0 Remove
      - Folder data 0
        
        Folder post 0
        
        File VHDPOSTData.h 0 Remove
        
        Folder pretreatment 0
        
        File VPreTreatmentStatesData.cpp 0 Remove
        
        File VPreTreatmentStatesData.h 0 Remove
        
        Folder treatment 0
        
        File VHDTreatmentStatesData.cpp 0 Remove
        
        File VHDTreatmentStatesData.h 0 Remove
        
        File VTreatmentPressureOcclusion.h 0 Remove
        
        File VTreatmentRinsebackData.h 0 Remove
        
        File VTreatmentUltrafiltration.h 0 Remove
        
        File VHDAccelerometerData.cpp 3 Remove
        
        File VHDAccelerometerData.h 0 Remove
        
        File VHDAirBubbleData.cpp 0 Remove
        
        File VHDAirBubbleData.h 0 Remove
        
        File VHDAirTrapData.cpp 0 Remove
        
        File VHDAirTrapData.h 0 Remove
        
        File VHDBloodLeakData.h 0 Remove
    - Folder settings 0
      - File VAdjustmentAlarmVolume.h 0 Remove
      - File VAdjustmentService.h 0 Remove
      - File VAdjustmentVersions.h 0 Remove
      - File VDateTime.cpp 0 Remove
    - File VAdjustmentResponseBase.h 0 Remove
    - File VEventSpy.cpp 0 Remove
    - File VEventSpy.h 0 Remove
    - File VGeneralEvent.cpp 0 Remove
    - File VGeneralEvent.h 0 Remove
    - File VPowerOff.h 0 Remove
    - File VTreatmentCreate.cpp 0 Remove
    - File VTreatmentCreate.h 0 Remove
    - File VView.h 0 Remove
  - Folder wifi 0
    - File WifiInterface.cpp 0 Remove
    - File WifiInterface.h 0 Remove
  - File AlarmGenerator.cpp 0 Remove
  - File ApplicationController.cpp 0 Remove
  - File ApplicationController.h 0 Remove
  - File ApplicationPost.cpp 0 Remove
  - File MainTimer.cpp 0 Remove
  - File Threads.cpp 0 Remove
- File AlarmMapping.csv 0 Remove
- File alarmMapping.sh 0 Remove
- File cppcheck.err 0 Remove
- File cppcheck.log 0 Remove
- File denali.pro 0 Remove
- File denali.pro.user 0 Remove
- File denali.qrc 0 Remove
- File en_US.udic 0 Remove
- File main.cpp 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Behrouz NematiPour	Author & Moderator	24m	5	I don't usually remove these kinds of comments they are t...
Sean Nash	Reviewer - Complete	1h 2m	7	RESOLVED.
Dara Navaei	Reviewer - 0% reviewed	0m
Michael Garthwaite	Reviewer - Complete	41m
Total		2h 9m	12

#permalink

Objectives

There are no specific objectives for this review.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

There are no general comments on this review.

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: [Crucible Review CR-1\|CR-1]
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

UI-DEN-12258-1

UI-DEN-12258_UI BN S66

UI-DEN-12258-1 12

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time

UI-DEN-12258_UI BN S66

UI-DEN-12258-1 12

Summarize the review outcomes (optional)

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time