This is a list of all comments for UI-DEN-12258-1.

Review Summary: No summary


----------------------------------------
File: sources/canbus/CanInterface.cpp
Revision Comment by Sean Nash on 08 April 2022, 09:51 
https://devapps.diality.us/cru/UI-DEN-12258-1#c12773

  Does it bother CoCo if you disable a begin but leave the end
  there?

  Reply by Behrouz NematiPour on 12 April 2022, 18:08
  > very good point Sean.
  > Coco ignores it but logs each one which I think it more
  > bothers us than coco.
  > I am going to disable them too.

    Reply by Behrouz NematiPour on 18 April 2022, 17:55
    > Disabled the "coco end"s as well.

      Reply by Sean Nash on 26 April 2022, 11:22
      > RESOLVED.

----------------------------------------
File: sources/view/hd/data/VHDAccelerometerData.cpp
Revision Comment by Sean Nash on 18 April 2022, 16:21 
https://devapps.diality.us/cru/UI-DEN-12258-1#c12778

  When will this get fixed (removed)?

  Reply by Behrouz NematiPour on 18 April 2022, 17:04
  > IT has been recently removed from the diagnostics screen.
  > I'm not sure when it will be needed to get back again on that
  > screen.
  > Probably keeping it is a lot easier than reimplementing it.

    Reply by Sean Nash on 26 April 2022, 13:04
    > RESOLVED.

----------------------------------------
File: sources/storage/TreatmentLog.h
Revision Comment by Sean Nash on 18 April 2022, 16:17 
https://devapps.diality.us/cru/UI-DEN-12258-1#c12777

  Why only comment out?  Can't we just remove?

  Reply by Behrouz NematiPour on 18 April 2022, 17:07
  > To make sure it is intentional, and we didn't miss a
  > parameter.
  > also it helps with the copy pasts later.

    Reply by Sean Nash on 26 April 2022, 11:26
    > So then when would we remove this line of code?

      Reply by Behrouz NematiPour on 26 April 2022, 11:59
      > I don't usually remove these kinds of comments they are
      > there for developers as a reminder to keep the indices
      > match.
      > This is like a code comment.

        Reply by Sean Nash on 26 April 2022, 13:03
        > RESOLVED.


---

ID: UI-DEN-12258-1 https://devapps.diality.us/cru/UI-DEN-12258-1

Title: UI-DEN-12258_UI BN S66
Statement of Objectives:


State: Closed

Summary: 

Author: Behrouz NematiPour
Moderator: Behrouz NematiPour
Reviewers: (1 active, 2 completed*)
     Sean Nash   (*)
     Michael Garthwaite   (*)
     Dara Navaei