UI-DEN-1396-1 UI-DEN-1396_Log Handler

closed on 15 Jan 20

Author

Moderator

Reviewers

UI-DEN-1396_Log Handler

Activity

Details
Objectives
General Comments 11
Unresolved
Resolved
Number of files included: 98

application 0
- Folder scripts 0
  - File run.sh 3 Remove
- Folder sources 0
  - Folder abstract 0
    - File singleton.h 0 Remove
  - Folder canbus 0
    - File alarminterpreter.cpp 0 Remove
    - File alarminterpreter.h 0 Remove
    - File caninterface.cpp 0 Remove
    - File caninterface.h 3 Remove
    - File frameinterface.cpp 0 Remove
    - File frameinterface.h 0 Remove
    - File messagebuilder.cpp 0 Remove
    - File messagebuilder.h 0 Remove
    - File messagedispatcher.cpp 0 Remove
    - File messagedispatcher.h 0 Remove
    - File messageglobals.cpp 0 Remove
    - File messageglobals.h 0 Remove
    - File messagehandler.cpp 0 Remove
    - File messagehandler.h 0 Remove
    - File messageinterface.cpp 0 Remove
    - File messageinterface.h 0 Remove
    - File messageinterpreter.cpp 6 Remove
    - File messageinterpreter.h 0 Remove
    - File messagepartitioner.cpp 0 Remove
    - File messagepartitioner.h 0 Remove
  - Folder configuration 0
    - File display.cpp 3 Remove
    - File display.h 3 Remove
    - File sound.cpp 3 Remove
    - File sound.h 3 Remove
  - Folder gui 0
    - Folder qml 0
      - Folder components 0
        
        File BackButton.qml 3 Remove
        
        File ExportButton.qml 0 Remove
        
        File LogoD.qml 3 Remove
        
        File MainMenu.qml 0 Remove
        
        File ModalDialog.qml 3 Remove
        
        File ScreenItem.qml 3 Remove
        
        File StackItem.qml 3 Remove
        
        File TitleText.qml 3 Remove
        
        File TouchRect.qml 3 Remove
        
        File USBButton.qml 0 Remove
      - Folder dialogs 0
        
        File PowerOff.qml 3 Remove
      - Folder globals 0
        
        File Colors.qml 0 Remove
        
        File Fonts.qml 3 Remove
        
        File Variables.qml 3 Remove
      - Folder pages 0
        
        File ManagerHome.qml 3 Remove
        
        File ManagerStack.qml 3 Remove
        
        File SettingsHome.qml 3 Remove
        
        File SettingsStack.qml 3 Remove
        
        File TreatmentCreate.qml 3 Remove
        
        File TreatmentHome.qml 0 Remove
        
        File TreatmentStack.qml 3 Remove
        
        File TreatmentStart.qml 6 Remove
      - File main.qml 6 Remove
    - File guiactions.cpp 0 Remove
    - File guiactions.h 0 Remove
    - File guicontroller.cpp 6 Remove
    - File guicontroller.h 3 Remove
    - File guiglobals.cpp 3 Remove
    - File guiglobals.h 3 Remove
    - File guiview.cpp 3 Remove
    - File guiview.h 3 Remove
  - Folder storage 0
    - File filehandler.cpp 0 Remove
    - File filehandler.h 0 Remove
    - File logger.cpp 0 Remove
    - File logger.h 3 Remove
    - File settings.cpp 3 Remove
    - File settings.h 3 Remove
    - File storageglobals.cpp 0 Remove
    - File storageglobals.h 0 Remove
    - File usbwatcher.cpp 0 Remove
    - File usbwatcher.h 3 Remove
  - Folder utility 0
    - File crc.cpp 3 Remove
    - File crc.h 0 Remove
    - File format.cpp 0 Remove
    - File format.h 0 Remove
    - File types.cpp 0 Remove
    - File types.h 0 Remove
  - File applicationcontroller.cpp 0 Remove
  - File applicationcontroller.h 3 Remove
  - File applicationpost.cpp 3 Remove
  - File applicationpost.h 3 Remove
  - File main.h 0 Remove
  - File maintimer.cpp 3 Remove
  - File maintimer.h 3 Remove
  - File threads.cpp 0 Remove
  - File threads.h 0 Remove
- Folder unittests 0
  - File tst_canbus.cpp 3 Remove
  - File tst_canbus.h 0 Remove
  - File tst_logging.cpp 0 Remove
  - File tst_logging.h 6 Remove
  - File tst_utilities.cpp 3 Remove
  - File tst_utilities.h 3 Remove
  - File unittests.cpp 3 Remove
  - File unittests.h 0 Remove
- File .gitignore 0 Remove
- File cppcheck.err 0 Remove
- File cppcheck.log 0 Remove
- File cppcheck.sh 0 Remove
- File denali.pro 0 Remove
- File denali.pro.user 0 Remove
- File denali.qrc 0 Remove
- File main.cpp 3 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Behrouz NematiPour	Author & Moderator	1h 38m	57	Very good point. Regarding our discussion I understood. I...
Dara Navaei	Reviewer - Complete	1h 46m
pmontazemi (deleted user)	Reviewer - Complete	43m	104	RESOLVED.
lbaloa (deleted user)	Reviewer - Complete	26m	6	RESOLVED.
Total		4h 36m	167

Linked issues
- DEN-1399
- DEN-1617

#permalink

Objectives

There are no specific objectives for this review.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

lbaloa (deleted user)

We need to provide better description of each class at the beginning in order...

We need to provide better description of each class at the beginning in order to make sense of the code.

10 Jan 20

lbaloa

(deleted user)

Resolved

15 Jan 20

Behrouz NematiPour

I'll take an overall look. Could you please help me with a specific example?

I'll take an overall look.
Could you please help me with a specific example?

13 Jan 20

Behrouz NematiPour

You are absolutely right. I forgot the classes details description. Added det...

You are absolutely right.
I forgot the classes details description.
Added details.

14 Jan 20

Behrouz NematiPour

Very good point. Regarding our discussion I understood. I don't timeout and d...

Very good point.
Regarding our discussion I understood.
I don't timeout and don't wait for a response back.
But I'm going to have that when I'm done with the ACK/BACK.

15 Jan 20

lbaloa (deleted user)

RESOLVED.

15 Jan 20

lbaloa (deleted user)

I looked for time outs when a message is sent, not clear if it is implemented...

I looked for time outs when a message is sent, not clear if it is implemented or not.

10 Jan 20

lbaloa

(deleted user)

Resolved

15 Jan 20

Behrouz NematiPour

Could you please explain a little more which timeout and messages we are talk...

Could you please explain a little more which timeout and messages we are talking about since it's in a general area I don't know which part you mean.

13 Jan 20

lbaloa (deleted user)

RESOLVED.

15 Jan 20

lbaloa (deleted user)

Can you explain why are you using two threads? One in frame interface and ano...

Can you explain why are you using two threads? One in frame interface and another one in can interface? I would think of a communication system as two threads, one sending information and another waiting to receive a response.

10 Jan 20

lbaloa

(deleted user)

Resolved

15 Jan 20

Behrouz NematiPour

Very good question. I put the classes in threads by the producer consumer ide...

Very good question.
I put the classes in threads by the producer consumer idea.
The class FrameInterface is a mediator between the two logics you explained.
So we have three threads :

CanInterface : Gets "Frames (QCanBusFrame)", directly from can device queue them and notify the FrameInterface.
FrameInterface : Gets "Frames" from CanInterface convert them into "array of bytes (QByteArray)" for each channel.
MessageDispatcher : Gets "Array of Bytes (QByteArray)" and [Build] them as "Messages" and wait for further data to make the Messages complete and then [Interpret/Validate] them and dispatch it to the responsible class.

So I have three threads.
It can be 2 but I preferred to put the mediator in its own thread.
I hope it explains.

13 Jan 20

lbaloa (deleted user)

RESOLVED.

15 Jan 20

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: [Crucible Review CR-1\|CR-1]
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

UI-DEN-1396-1

UI-DEN-1396_Log Handler

UI-DEN-1396-1 167

Details

Linked issues

Objectives

Branches in review

Issues Raised From Comments

General Comments

lbaloa (deleted user)

Behrouz NematiPour

Behrouz NematiPour

Behrouz NematiPour

lbaloa (deleted user)

lbaloa (deleted user)

Behrouz NematiPour

lbaloa (deleted user)

lbaloa (deleted user)

Behrouz NematiPour

lbaloa (deleted user)

Log time

UI-DEN-1396_Log Handler

UI-DEN-1396-1 167

Summarize the review outcomes (optional)

Details

Linked issues

Objectives

Branches in review

Issues Raised From Comments

General Comments

lbaloa (deleted user)

Behrouz NematiPour

Behrouz NematiPour

Behrouz NematiPour

lbaloa (deleted user)

lbaloa (deleted user)

Behrouz NematiPour

lbaloa (deleted user)

lbaloa (deleted user)

Behrouz NematiPour

lbaloa (deleted user)

Log time