This is a list of all comments for UI-DEN-1396-1. Review Summary: No summary General Comment by lbaloa on 10 January 2020, 11:02 https://devapps.diality.us/cru/UI-DEN-1396-1#c919 We need to provide better description of each class at the beginning in order to make sense of the code. Reply by Behrouz NematiPour on 13 January 2020, 10:19 > I'll take an overall look. > Could you please help me with a specific example? Reply by Behrouz NematiPour on 14 January 2020, 14:46 > You are absolutely right. > I forgot the classes details description. > Added details. Reply by Behrouz NematiPour on 15 January 2020, 14:05 > Very good point. > Regarding our discussion I understood. > I don't timeout and don't wait for a response back. > But I'm going to have that when I'm done with the ACK/BACK. Reply by lbaloa on 15 January 2020, 14:22 > RESOLVED. General Comment by lbaloa on 10 January 2020, 11:03 https://devapps.diality.us/cru/UI-DEN-1396-1#c920 I looked for time outs when a message is sent, not clear if it is implemented or not. Reply by Behrouz NematiPour on 13 January 2020, 10:18 > Could you please explain a little more which timeout and > messages we are talking about since it's in a general area I > don't know which part you mean. Reply by lbaloa on 15 January 2020, 14:22 > RESOLVED. General Comment by lbaloa on 10 January 2020, 11:04 https://devapps.diality.us/cru/UI-DEN-1396-1#c922 Can you explain why are you using two threads? One in frame interface and another one in can interface? I would think of a communication system as two threads, one sending information and another waiting to receive a response. Reply by Behrouz NematiPour on 13 January 2020, 10:17 > Very good question. > I put the classes in threads by the producer consumer idea. > The class FrameInterface is a mediator between the two logics > you explained. > So we have three threads : > > CanInterface : Gets "Frames (QCanBusFrame)", directly from > can device queue them and notify the FrameInterface. > FrameInterface : Gets "Frames" from CanInterface convert them > into "array of bytes (QByteArray)" for each channel. > MessageDispatcher : Gets "Array of Bytes (QByteArray)" and > [Build] them as "Messages" and wait for further data to make > the Messages complete and then [Interpret/Validate] them and > dispatch it to the responsible class. > > So I have three threads. > It can be 2 but I preferred to put the mediator in its own > thread. > I hope it explains. Reply by lbaloa on 15 January 2020, 14:23 > RESOLVED. ---------------------------------------- File: main.cpp Revision Comment by pmontazemi on 09 January 2020, 16:50 https://devapps.diality.us/cru/UI-DEN-1396-1#c908 Space between two ifs. Reply by Behrouz NematiPour on 14 January 2020, 13:38 > It's a test code as has been stated on line 66 and will be > removed or handled in correct way latter. Reply by pmontazemi on 15 January 2020, 11:11 > RESOLVED. ---------------------------------------- File: sources/applicationcontroller.h Revision Comment by pmontazemi on 09 January 2020, 16:47 https://devapps.diality.us/cru/UI-DEN-1396-1#c897 Changed date? Reply by Behrouz NematiPour on 13 January 2020, 10:46 > Files has been modified many times manuallu on my branch as > you asked a week or toow before 2020 and by Dara's script on > master on 2019 and 2020. > It might be me merging files from my branch to master with > 2019, since I think his script is running only on master > branches. Reply by pmontazemi on 14 January 2020, 09:58 > RESOLVED. ---------------------------------------- File: sources/canbus/caninterface.h Revision Comment by pmontazemi on 09 January 2020, 10:55 https://devapps.diality.us/cru/UI-DEN-1396-1#c858 Put spaces between every single function definition. Reply by Behrouz NematiPour on 14 January 2020, 13:56 > Updated in "38e28c4" Reply by pmontazemi on 15 January 2020, 11:13 > RESOLVED. ---------------------------------------- File: sources/canbus/messageinterpreter.cpp Revision Comment by pmontazemi on 09 January 2020, 10:58 https://devapps.diality.us/cru/UI-DEN-1396-1#c859 Indent the cases for legibility. Reply by Behrouz NematiPour on 14 January 2020, 13:50 > This is the Qt [built-in] style. > I didn't change it since it is also used for QML. > And it made both code look alike. Reply by pmontazemi on 15 January 2020, 11:13 > RESOLVED. Revision Comment by pmontazemi on 09 January 2020, 10:58 https://devapps.diality.us/cru/UI-DEN-1396-1#c860 Same comment here, indent the cases for legibility. Reply by Behrouz NematiPour on 14 January 2020, 13:49 > This is the Qt [built-in] style. > I didn't change it since it is also used for QML. > And it made both code look alike. Reply by pmontazemi on 15 January 2020, 11:13 > RESOLVED. ---------------------------------------- File: sources/gui/guicontroller.cpp Revision Comment by pmontazemi on 09 January 2020, 15:57 https://devapps.diality.us/cru/UI-DEN-1396-1#c885 Date change? Reply by Behrouz NematiPour on 13 January 2020, 10:45 > Files has been modified many times manuallu on my branch as > you asked a week or toow before 2020 and by Dara's script on > master on 2019 and 2020. > It might be me merging files from my branch to master with > 2019, since I think his script is running only on master > branches. Reply by pmontazemi on 14 January 2020, 10:00 > RESOLVED. Revision Comment by pmontazemi on 09 January 2020, 16:00 https://devapps.diality.us/cru/UI-DEN-1396-1#c886 Remove commented section. Reply by Behrouz NematiPour on 13 January 2020, 10:51 > - We are not at release point. > - Some comments are Tests codes which will be (un)comment > back/forth > - Some codes are codes to help developer as an example of > how to use the code in that specific section or matter. > - Some codes are placeholder and will be removed when the > actual implementation is done. > > * In this case it's a usage help. Reply by pmontazemi on 15 January 2020, 11:12 > RESOLVED. ---------------------------------------- File: sources/gui/guicontroller.h Revision Comment by pmontazemi on 09 January 2020, 16:00 https://devapps.diality.us/cru/UI-DEN-1396-1#c887 Changed date? Reply by Behrouz NematiPour on 13 January 2020, 10:45 > Files has been modified many times manuallu on my branch as > you asked a week or toow before 2020 and by Dara's script on > master on 2019 and 2020. > It might be me merging files from my branch to master with > 2019, since I think his script is running only on master > branches. Reply by pmontazemi on 14 January 2020, 09:59 > RESOLVED. ---------------------------------------- File: sources/gui/guiview.cpp Revision Comment by pmontazemi on 09 January 2020, 16:01 https://devapps.diality.us/cru/UI-DEN-1396-1#c890 Changed date? Reply by Behrouz NematiPour on 13 January 2020, 10:45 > Files has been modified many times manuallu on my branch as > you asked a week or toow before 2020 and by Dara's script on > master on 2019 and 2020. > It might be me merging files from my branch to master with > 2019, since I think his script is running only on master > branches. Reply by pmontazemi on 14 January 2020, 09:59 > RESOLVED. ---------------------------------------- File: sources/maintimer.cpp Revision Comment by pmontazemi on 09 January 2020, 16:47 https://devapps.diality.us/cru/UI-DEN-1396-1#c900 Changed date? Reply by Behrouz NematiPour on 13 January 2020, 10:47 > Files has been modified many times manuallu on my branch as > you asked a week or toow before 2020 and by Dara's script on > master on 2019 and 2020. > It might be me merging files from my branch to master with > 2019, since I think his script is running only on master > branches. Reply by pmontazemi on 14 January 2020, 09:58 > RESOLVED. ---------------------------------------- File: sources/storage/logger.h Revision Comment by pmontazemi on 09 January 2020, 16:45 https://devapps.diality.us/cru/UI-DEN-1396-1#c892 Indentation of }? Reply by Behrouz NematiPour on 13 January 2020, 10:50 > namespaces don't have indentation because it would be > redundant and almost all the files have namespaces. Reply by pmontazemi on 15 January 2020, 11:10 > RESOLVED. ---------------------------------------- File: sources/storage/usbwatcher.h Revision Comment by pmontazemi on 09 January 2020, 16:45 https://devapps.diality.us/cru/UI-DEN-1396-1#c895 Indentation of }? Reply by Behrouz NematiPour on 13 January 2020, 10:49 > namespaces don't have indentation because it would be > redundant and almost all the files have namespaces. Reply by pmontazemi on 15 January 2020, 11:10 > RESOLVED. ---------------------------------------- File: unittests/tst_canbus.cpp Revision Comment by pmontazemi on 09 January 2020, 16:48 https://devapps.diality.us/cru/UI-DEN-1396-1#c902 Add blank line at eof. Reply by Behrouz NematiPour on 14 January 2020, 13:44 > There is a line at the end of the file (always should be > since the QtCreator add one anyway) seems like the Crucible > is not showing it !!! Reply by pmontazemi on 15 January 2020, 11:12 > RESOLVED. ---------------------------------------- File: sources/maintimer.h Revision Comment by pmontazemi on 09 January 2020, 16:47 https://devapps.diality.us/cru/UI-DEN-1396-1#c901 Changed date? Reply by Behrouz NematiPour on 13 January 2020, 10:24 > Files has been modified many times manuallu on my branch as > you asked a week or toow before 2020 and by Dara's script on > master on 2019 and 2020. > It might be me merging files from my branch to master with > 2019, since I think his script is running only on master > branches. Reply by pmontazemi on 14 January 2020, 09:58 > RESOLVED. ---------------------------------------- File: scripts/run.sh Revision Comment by pmontazemi on 08 January 2020, 17:40 https://devapps.diality.us/cru/UI-DEN-1396-1#c855 Add space Reply by Behrouz NematiPour on 14 January 2020, 14:12 > updated. Reply by pmontazemi on 15 January 2020, 11:13 > RESOLVED. ---------------------------------------- File: sources/gui/guiglobals.cpp Revision Comment by pmontazemi on 09 January 2020, 16:00 https://devapps.diality.us/cru/UI-DEN-1396-1#c888 Changed date? Reply by Behrouz NematiPour on 13 January 2020, 10:45 > Files has been modified many times manuallu on my branch as > you asked a week or toow before 2020 and by Dara's script on > master on 2019 and 2020. > It might be me merging files from my branch to master with > 2019, since I think his script is running only on master > branches. Reply by pmontazemi on 14 January 2020, 09:59 > RESOLVED. ---------------------------------------- File: sources/gui/guiglobals.h Revision Comment by pmontazemi on 09 January 2020, 16:01 https://devapps.diality.us/cru/UI-DEN-1396-1#c889 Changed date? Reply by Behrouz NematiPour on 13 January 2020, 10:45 > Files has been modified many times manuallu on my branch as > you asked a week or toow before 2020 and by Dara's script on > master on 2019 and 2020. > It might be me merging files from my branch to master with > 2019, since I think his script is running only on master > branches. Reply by pmontazemi on 14 January 2020, 09:59 > RESOLVED. ---------------------------------------- File: sources/gui/guiview.h Revision Comment by pmontazemi on 09 January 2020, 16:01 https://devapps.diality.us/cru/UI-DEN-1396-1#c891 Changed date? Reply by Behrouz NematiPour on 13 January 2020, 10:45 > Files has been modified many times manuallu on my branch as > you asked a week or toow before 2020 and by Dara's script on > master on 2019 and 2020. > It might be me merging files from my branch to master with > 2019, since I think his script is running only on master > branches. Reply by pmontazemi on 14 January 2020, 09:59 > RESOLVED. ---------------------------------------- File: sources/gui/qml/main.qml Revision Comment by pmontazemi on 09 January 2020, 15:57 https://devapps.diality.us/cru/UI-DEN-1396-1#c883 Date change? Reply by Behrouz NematiPour on 13 January 2020, 10:44 > Files has been modified many times manuallu on my branch as > you asked a week or toow before 2020 and by Dara's script on > master on 2019 and 2020. > It might be me merging files from my branch to master with > 2019, since I think his script is running only on master > branches. Reply by pmontazemi on 14 January 2020, 10:00 > RESOLVED. Revision Comment by pmontazemi on 09 January 2020, 15:57 https://devapps.diality.us/cru/UI-DEN-1396-1#c884 Remove commented line. Reply by Behrouz NematiPour on 13 January 2020, 10:57 > - We are not at release point. > - Some comments are Tests codes which will be (un)comment > back/forth > - Some codes are codes to help developer as an example of > how to use the code in that specific section or matter. > - Some codes are placeholder and will be removed when the > actual implementation is done. > . > . > ~ In this case it's Test Code. > . > . Reply by pmontazemi on 15 January 2020, 11:12 > RESOLVED. ---------------------------------------- File: sources/gui/qml/pages/TreatmentStart.qml Revision Comment by pmontazemi on 09 January 2020, 15:56 https://devapps.diality.us/cru/UI-DEN-1396-1#c881 Date change? Reply by Behrouz NematiPour on 13 January 2020, 10:44 > Files has been modified many times manuallu on my branch as > you asked a week or toow before 2020 and by Dara's script on > master on 2019 and 2020. > It might be me merging files from my branch to master with > 2019, since I think his script is running only on master > branches. Reply by pmontazemi on 14 January 2020, 10:00 > RESOLVED. Revision Comment by pmontazemi on 09 January 2020, 15:56 https://devapps.diality.us/cru/UI-DEN-1396-1#c882 Remove commented section. Reply by Behrouz NematiPour on 13 January 2020, 10:54 > - We are not at release point. > - Some comments are Tests codes which will be (un)comment > back/forth > - Some codes are codes to help developer as an example of > how to use the code in that specific section or matter. > - Some codes are placeholder and will be removed when the > actual implementation is done. > > ~ In this case it's the placeholder and is already removed in > "Advanced Treatment" feature. > . > . Reply by pmontazemi on 15 January 2020, 11:12 > RESOLVED. ---------------------------------------- File: sources/gui/qml/components/TouchRect.qml Revision Comment by pmontazemi on 09 January 2020, 15:55 https://devapps.diality.us/cru/UI-DEN-1396-1#c871 Date change? Reply by Behrouz NematiPour on 13 January 2020, 10:43 > Files has been modified many times manuallu on my branch as > you asked a week or toow before 2020 and by Dara's script on > master on 2019 and 2020. > It might be me merging files from my branch to master with > 2019, since I think his script is running only on master > branches. Reply by pmontazemi on 14 January 2020, 10:02 > RESOLVED. ---------------------------------------- File: sources/gui/qml/pages/SettingsHome.qml Revision Comment by pmontazemi on 09 January 2020, 15:56 https://devapps.diality.us/cru/UI-DEN-1396-1#c877 Date change? Reply by Behrouz NematiPour on 13 January 2020, 10:44 > Files has been modified many times manuallu on my branch as > you asked a week or toow before 2020 and by Dara's script on > master on 2019 and 2020. > It might be me merging files from my branch to master with > 2019, since I think his script is running only on master > branches. Reply by pmontazemi on 14 January 2020, 10:01 > RESOLVED. ---------------------------------------- File: unittests/unittests.cpp Revision Comment by pmontazemi on 09 January 2020, 16:50 https://devapps.diality.us/cru/UI-DEN-1396-1#c907 If unit tests were removed, where are the new unit tests? Reply by Behrouz NematiPour on 13 January 2020, 10:03 > Regarding Sapna's request created a Class and set of cpp/h > files for each feature so this generally named has been > changed to "tst_canbus" Reply by pmontazemi on 14 January 2020, 09:57 > RESOLVED. ---------------------------------------- File: sources/gui/qml/components/ModalDialog.qml Revision Comment by pmontazemi on 09 January 2020, 15:54 https://devapps.diality.us/cru/UI-DEN-1396-1#c867 Date change? Reply by Behrouz NematiPour on 13 January 2020, 10:42 > Files has been modified many times manuallu on my branch as > you asked a week or toow before 2020 and by Dara's script on > master on 2019 and 2020. > It might be me merging files from my branch to master with > 2019, since I think his script is running only on master > branches. Reply by pmontazemi on 14 January 2020, 10:02 > RESOLVED. ---------------------------------------- File: sources/applicationpost.cpp Revision Comment by pmontazemi on 09 January 2020, 16:47 https://devapps.diality.us/cru/UI-DEN-1396-1#c898 Changed date? Reply by Behrouz NematiPour on 13 January 2020, 10:46 > Files has been modified many times manuallu on my branch as > you asked a week or toow before 2020 and by Dara's script on > master on 2019 and 2020. > It might be me merging files from my branch to master with > 2019, since I think his script is running only on master > branches. Reply by pmontazemi on 14 January 2020, 09:58 > RESOLVED. ---------------------------------------- File: sources/applicationpost.h Revision Comment by pmontazemi on 09 January 2020, 16:47 https://devapps.diality.us/cru/UI-DEN-1396-1#c899 Changed date? Reply by Behrouz NematiPour on 13 January 2020, 10:46 > Files has been modified many times manuallu on my branch as > you asked a week or toow before 2020 and by Dara's script on > master on 2019 and 2020. > It might be me merging files from my branch to master with > 2019, since I think his script is running only on master > branches. Reply by pmontazemi on 14 January 2020, 09:58 > RESOLVED. ---------------------------------------- File: sources/configuration/display.cpp Revision Comment by pmontazemi on 09 January 2020, 15:48 https://devapps.diality.us/cru/UI-DEN-1396-1#c861 Why back to 2019? We are in 2020. Reply by Behrouz NematiPour on 13 January 2020, 10:36 > Files has been modified many times manuallu on my branch as > you asked a week or toow before 2020 and by Dara's script on > master on 2019 and 2020. > It might be me merging files from my branch to master with > 2019, since I think his script is running only on master > branches. Reply by pmontazemi on 14 January 2020, 10:03 > RESOLVED. ---------------------------------------- File: sources/configuration/display.h Revision Comment by pmontazemi on 09 January 2020, 15:48 https://devapps.diality.us/cru/UI-DEN-1396-1#c862 Same comment here. Reply by Behrouz NematiPour on 13 January 2020, 10:37 > Files has been modified many times manuallu on my branch as > you asked a week or toow before 2020 and by Dara's script on > master on 2019 and 2020. > It might be me merging files from my branch to master with > 2019, since I think his script is running only on master > branches. Reply by pmontazemi on 14 January 2020, 10:02 > RESOLVED. ---------------------------------------- File: sources/configuration/sound.cpp Revision Comment by pmontazemi on 09 January 2020, 15:48 https://devapps.diality.us/cru/UI-DEN-1396-1#c863 Same comment here. Reply by Behrouz NematiPour on 13 January 2020, 10:41 > Files has been modified many times manuallu on my branch as > you asked a week or toow before 2020 and by Dara's script on > master on 2019 and 2020. > It might be me merging files from my branch to master with > 2019, since I think his script is running only on master > branches. Reply by pmontazemi on 14 January 2020, 09:56 > RESOLVED. ---------------------------------------- File: sources/configuration/sound.h Revision Comment by pmontazemi on 09 January 2020, 15:48 https://devapps.diality.us/cru/UI-DEN-1396-1#c864 Same comment here. Reply by Behrouz NematiPour on 13 January 2020, 10:42 > Files has been modified many times manuallu on my branch as > you asked a week or toow before 2020 and by Dara's script on > master on 2019 and 2020. > It might be me merging files from my branch to master with > 2019, since I think his script is running only on master > branches. Reply by pmontazemi on 14 January 2020, 10:03 > RESOLVED. ---------------------------------------- File: sources/gui/qml/components/BackButton.qml Revision Comment by pmontazemi on 09 January 2020, 15:48 https://devapps.diality.us/cru/UI-DEN-1396-1#c865 Same comment here. Reply by Behrouz NematiPour on 13 January 2020, 10:42 > Files has been modified many times manuallu on my branch as > you asked a week or toow before 2020 and by Dara's script on > master on 2019 and 2020. > It might be me merging files from my branch to master with > 2019, since I think his script is running only on master > branches. Reply by pmontazemi on 14 January 2020, 10:02 > RESOLVED. ---------------------------------------- File: sources/gui/qml/components/LogoD.qml Revision Comment by pmontazemi on 09 January 2020, 15:54 https://devapps.diality.us/cru/UI-DEN-1396-1#c866 Date change? Reply by Behrouz NematiPour on 13 January 2020, 10:42 > Files has been modified many times manuallu on my branch as > you asked a week or toow before 2020 and by Dara's script on > master on 2019 and 2020. > It might be me merging files from my branch to master with > 2019, since I think his script is running only on master > branches. Reply by pmontazemi on 14 January 2020, 10:02 > RESOLVED. ---------------------------------------- File: sources/gui/qml/components/ScreenItem.qml Revision Comment by pmontazemi on 09 January 2020, 15:54 https://devapps.diality.us/cru/UI-DEN-1396-1#c868 Date change? Reply by Behrouz NematiPour on 13 January 2020, 10:42 > Files has been modified many times manuallu on my branch as > you asked a week or toow before 2020 and by Dara's script on > master on 2019 and 2020. > It might be me merging files from my branch to master with > 2019, since I think his script is running only on master > branches. Reply by pmontazemi on 14 January 2020, 10:02 > RESOLVED. ---------------------------------------- File: sources/gui/qml/components/StackItem.qml Revision Comment by pmontazemi on 09 January 2020, 15:55 https://devapps.diality.us/cru/UI-DEN-1396-1#c869 Date change? Reply by Behrouz NematiPour on 13 January 2020, 10:42 > Files has been modified many times manuallu on my branch as > you asked a week or toow before 2020 and by Dara's script on > master on 2019 and 2020. > It might be me merging files from my branch to master with > 2019, since I think his script is running only on master > branches. Reply by pmontazemi on 14 January 2020, 10:02 > RESOLVED. ---------------------------------------- File: sources/gui/qml/components/TitleText.qml Revision Comment by pmontazemi on 09 January 2020, 15:55 https://devapps.diality.us/cru/UI-DEN-1396-1#c870 Date change? Reply by Behrouz NematiPour on 13 January 2020, 10:43 > Files has been modified many times manuallu on my branch as > you asked a week or toow before 2020 and by Dara's script on > master on 2019 and 2020. > It might be me merging files from my branch to master with > 2019, since I think his script is running only on master > branches. Reply by pmontazemi on 14 January 2020, 10:02 > RESOLVED. ---------------------------------------- File: sources/gui/qml/dialogs/PowerOff.qml Revision Comment by pmontazemi on 09 January 2020, 15:55 https://devapps.diality.us/cru/UI-DEN-1396-1#c872 Date change? Reply by Behrouz NematiPour on 13 January 2020, 10:43 > Files has been modified many times manuallu on my branch as > you asked a week or toow before 2020 and by Dara's script on > master on 2019 and 2020. > It might be me merging files from my branch to master with > 2019, since I think his script is running only on master > branches. Reply by pmontazemi on 14 January 2020, 10:01 > RESOLVED. ---------------------------------------- File: sources/gui/qml/globals/Fonts.qml Revision Comment by pmontazemi on 09 January 2020, 15:55 https://devapps.diality.us/cru/UI-DEN-1396-1#c873 Date change? Reply by Behrouz NematiPour on 13 January 2020, 10:43 > Files has been modified many times manuallu on my branch as > you asked a week or toow before 2020 and by Dara's script on > master on 2019 and 2020. > It might be me merging files from my branch to master with > 2019, since I think his script is running only on master > branches. Reply by pmontazemi on 14 January 2020, 10:01 > RESOLVED. ---------------------------------------- File: sources/gui/qml/globals/Variables.qml Revision Comment by pmontazemi on 09 January 2020, 15:55 https://devapps.diality.us/cru/UI-DEN-1396-1#c874 Date change? Reply by Behrouz NematiPour on 13 January 2020, 10:43 > Files has been modified many times manuallu on my branch as > you asked a week or toow before 2020 and by Dara's script on > master on 2019 and 2020. > It might be me merging files from my branch to master with > 2019, since I think his script is running only on master > branches. Reply by pmontazemi on 14 January 2020, 10:01 > RESOLVED. ---------------------------------------- File: sources/gui/qml/pages/ManagerHome.qml Revision Comment by pmontazemi on 09 January 2020, 15:55 https://devapps.diality.us/cru/UI-DEN-1396-1#c875 Date change? Reply by Behrouz NematiPour on 13 January 2020, 10:43 > Files has been modified many times manuallu on my branch as > you asked a week or toow before 2020 and by Dara's script on > master on 2019 and 2020. > It might be me merging files from my branch to master with > 2019, since I think his script is running only on master > branches. Reply by pmontazemi on 14 January 2020, 10:01 > RESOLVED. ---------------------------------------- File: sources/gui/qml/pages/ManagerStack.qml Revision Comment by pmontazemi on 09 January 2020, 15:55 https://devapps.diality.us/cru/UI-DEN-1396-1#c876 Date change? Reply by Behrouz NematiPour on 13 January 2020, 10:44 > Files has been modified many times manuallu on my branch as > you asked a week or toow before 2020 and by Dara's script on > master on 2019 and 2020. > It might be me merging files from my branch to master with > 2019, since I think his script is running only on master > branches. Reply by pmontazemi on 14 January 2020, 10:01 > RESOLVED. ---------------------------------------- File: sources/gui/qml/pages/SettingsStack.qml Revision Comment by pmontazemi on 09 January 2020, 15:56 https://devapps.diality.us/cru/UI-DEN-1396-1#c878 Date change? Reply by Behrouz NematiPour on 13 January 2020, 10:44 > Files has been modified many times manuallu on my branch as > you asked a week or toow before 2020 and by Dara's script on > master on 2019 and 2020. > It might be me merging files from my branch to master with > 2019, since I think his script is running only on master > branches. Reply by pmontazemi on 14 January 2020, 10:00 > RESOLVED. ---------------------------------------- File: sources/gui/qml/pages/TreatmentCreate.qml Revision Comment by pmontazemi on 09 January 2020, 15:56 https://devapps.diality.us/cru/UI-DEN-1396-1#c879 Date change? Reply by Behrouz NematiPour on 13 January 2020, 10:44 > Files has been modified many times manuallu on my branch as > you asked a week or toow before 2020 and by Dara's script on > master on 2019 and 2020. > It might be me merging files from my branch to master with > 2019, since I think his script is running only on master > branches. Reply by pmontazemi on 14 January 2020, 10:00 > RESOLVED. ---------------------------------------- File: sources/gui/qml/pages/TreatmentStack.qml Revision Comment by pmontazemi on 09 January 2020, 15:56 https://devapps.diality.us/cru/UI-DEN-1396-1#c880 Date change? Reply by Behrouz NematiPour on 13 January 2020, 10:44 > Files has been modified many times manuallu on my branch as > you asked a week or toow before 2020 and by Dara's script on > master on 2019 and 2020. > It might be me merging files from my branch to master with > 2019, since I think his script is running only on master > branches. Reply by pmontazemi on 14 January 2020, 10:00 > RESOLVED. ---------------------------------------- File: sources/storage/settings.cpp Revision Comment by pmontazemi on 09 January 2020, 16:45 https://devapps.diality.us/cru/UI-DEN-1396-1#c893 Changed date? Reply by Behrouz NematiPour on 13 January 2020, 10:45 > Files has been modified many times manuallu on my branch as > you asked a week or toow before 2020 and by Dara's script on > master on 2019 and 2020. > It might be me merging files from my branch to master with > 2019, since I think his script is running only on master > branches. Reply by pmontazemi on 14 January 2020, 09:59 > RESOLVED. ---------------------------------------- File: sources/storage/settings.h Revision Comment by pmontazemi on 09 January 2020, 16:45 https://devapps.diality.us/cru/UI-DEN-1396-1#c894 Changed date? Reply by Behrouz NematiPour on 13 January 2020, 10:46 > Files has been modified many times manuallu on my branch as > you asked a week or toow before 2020 and by Dara's script on > master on 2019 and 2020. > It might be me merging files from my branch to master with > 2019, since I think his script is running only on master > branches. Reply by pmontazemi on 14 January 2020, 09:59 > RESOLVED. ---------------------------------------- File: sources/utility/crc.cpp Revision Comment by pmontazemi on 09 January 2020, 16:46 https://devapps.diality.us/cru/UI-DEN-1396-1#c896 Move to common, this is too much maintenance. Reply by Behrouz NematiPour on 13 January 2020, 10:48 > When the common repo is ready the hash table will be moved > there but the function itself remains here since the data > types UI and HD are using are different and can't be mixed. Reply by pmontazemi on 15 January 2020, 11:12 > RESOLVED. ---------------------------------------- File: unittests/tst_logging.h Revision Comment by pmontazemi on 09 January 2020, 16:49 https://devapps.diality.us/cru/UI-DEN-1396-1#c903 Remove commented line. Reply by Behrouz NematiPour on 14 January 2020, 13:42 > These are necessary QTest methods that I don't have any > implementation for them yet. > I didn't like the fact that although I don't have anything > implemented, it's still counts as a successful test, so I > comment them out for now until I have an implementation for > them. > In general I prefer not to remove thme to keep them as part > of the standard QtTest class. Reply by pmontazemi on 15 January 2020, 11:11 > RESOLVED. Revision Comment by pmontazemi on 09 January 2020, 16:49 https://devapps.diality.us/cru/UI-DEN-1396-1#c904 Remove commented line. Reply by Behrouz NematiPour on 14 January 2020, 13:42 > These are necessary QTest methods that I don't have any > implementation for them yet. > I didn't like the fact that although I don't have anything > implemented, it's still counts as a successful test, so I > comment them out for now until I have an implementation for > them. > In general I prefer not to remove thme to keep them as part > of the standard QtTest class. Reply by pmontazemi on 15 January 2020, 11:11 > RESOLVED. ---------------------------------------- File: unittests/tst_utilities.cpp Revision Comment by pmontazemi on 09 January 2020, 16:49 https://devapps.diality.us/cru/UI-DEN-1396-1#c905 Remove all commented sections. Reply by Behrouz NematiPour on 14 January 2020, 13:42 > These are necessary QTest methods that I don't have any > implementation for them yet. > I didn't like the fact that although I don't have anything > implemented, it's still counts as a successful test, so I > comment them out for now until I have an implementation for > them. > In general I prefer not to remove thme to keep them as part > of the standard QtTest class. Reply by pmontazemi on 15 January 2020, 11:11 > RESOLVED. ---------------------------------------- File: unittests/tst_utilities.h Revision Comment by pmontazemi on 09 January 2020, 16:49 https://devapps.diality.us/cru/UI-DEN-1396-1#c906 Remove all commented sections. Reply by Behrouz NematiPour on 14 January 2020, 13:39 > These are necessary QTest methods that I don't have any > implementation for them yet. > I didn't like the fact that although I don't have anything > implemented, it's still counts as a successful test, so I > comment them out for now until I have an implementation for > them. > In general I prefer not to remove thme to keep them as part > of the standard QtTest class. Reply by pmontazemi on 15 January 2020, 11:11 > RESOLVED. --- ID: UI-DEN-1396-1 https://devapps.diality.us/cru/UI-DEN-1396-1 Title: UI-DEN-1396_Log Handler Statement of Objectives: State: Closed Summary: Author: Behrouz NematiPour Moderator: Behrouz NematiPour Reviewers: (0 active, 3 completed*) Dara Navaei (*) pmontazemi (*) lbaloa (*)