UI-DEN-14733_UI BN S90

Activity

UI-DEN-14733-1 0

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author & Moderator 13m    
    Reviewer - Complete 4m    
    Reviewer - 0% reviewed      
    jishii  (deleted user)
    Reviewer completed
    Reviewer - Complete 3m    
    Reviewer - 1% reviewed 0m    
    Reviewer - Complete 5m    
    jreaume  (deleted user)
    Reviewer - 0% reviewed      
    vduong  (deleted user)
    Reviewer completed
    Reviewer - Complete 5m    
    Total   32m 0  
    #permalink

    Objectives

    commit : 8b3412f6 - DEN-14736 IMP: Confirm Always on Top

    • The Alarm won't cancel the Confirmation anymore
    • The Alarm Dialog will still get updated while minimized.
    • The Alarm Dialog will get maximized if the confirmation dialog gets closed.


    commit : 6f6ed243 - DEN-14736 IMP: Chem Flush

    • Adding the Chemical Flush button


    commit : e699d00a - DEN-14736 IMP: Update states

    • Updated states regarding changes have been made in FW Common
    • \sa : http://devapps.diality.us:8060/cru/HD-DEN-14549-1

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    There are no general comments on this review.
    /sources/gui/.../disinfect/DisinfectStack.qml Changed
    /sources/.../pretreatment/PreTreatmentConsumablesStack.qml Changed
    /sources/.../pretreatment/PreTreatmentDisposablesStack.qml Changed
    /sources/.../pretreatment/PreTreatmentPrimeStack.qml Changed
    /sources/.../pretreatment/PreTreatmentStack.qml Changed
    /sources/gui/qml/AlarmItem.qml Changed
    /sources/gui/qml/PowerItem.qml Changed
    /sources/model/hd/alarm/MAlarmMapping.cpp Changed
    /sources/.../disinfect/VDisinfectAdjustDisinfect.cpp Changed
    /sources/.../disinfect/VDisinfectAdjustDisinfect.h Changed
    /sources/.../pretreatment/VPreTreatmentStatesData.cpp Changed
    /sources/.../pretreatment/VPreTreatmentStatesData.h Changed
    /sources/.../treatment/VHDTreatmentStatesData.cpp Changed
    /sources/.../treatment/VHDTreatmentStatesData.h Changed
    /.gitignore Changed
    Open in IDE #permalink
    /AlarmMapping.csv Changed
    Open in IDE #permalink
    /cppcheck.err Changed
    Open in IDE #permalink
    /cppcheck.log Changed
    Open in IDE #permalink
    /denali.pro.user Changed
    Open in IDE #permalink
    /imake.sh Changed

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time