This is a list of all comments for UI-DEN-14733-2.

Review Summary: No summary


----------------------------------------
File: en_US.udic
Revision Comment by Sean Nash on 09 February 2023, 08:41 
https://devapps.diality.us/cru/UI-DEN-14733-2#c16448

  Why is her name in string table?

  Reply by Behrouz NematiPour on 09 February 2023, 10:02
  > I laughed loud for a while :D
  > This is the spell checker dictionary.
  > Since my spell checker was complaining and it was bugging me,
  > and I always look at it like there is a bug in that area, I
  > add her name so spell checker won't highlight it anymore.
  > It is a comment I have about the decision we made to remind
  > me why I have that line of code commented.

    Reply by Sean Nash on 09 February 2023, 11:06
    > RESOLVED.

----------------------------------------
File: sources/gui/qml/PowerItem.qml
Revision Comment by vduong on 10 February 2023, 08:04 
https://devapps.diality.us/cru/UI-DEN-14733-2#c16476

  If _root.isOpen is not modified outside of this powerItem.qml,
  You can make it a readonly property and bind it to the
  powerDialog's property.

  Reply by Behrouz NematiPour on 10 February 2023, 08:19
  > Good point,
  > But you can't.
  > The readonly properties are only working with bindings, not
  > assignments.
  > I am using that as a public variable.

    Reply by vduong on 10 February 2023, 09:18
    > Yes, assignments break bindings. 
    > 
    > RESOLVED

----------------------------------------
File: sources/gui/qml/pages/treatment/TreatmentStack.qml
Revision Comment by Michael Garthwaite on 09 February 2023, 09:21 
https://devapps.diality.us/cru/UI-DEN-14733-2#c16449

  is this alignment correct? I see you align by . above (line
  35-38) but I don't see examples of aligning by ( for function
  calls.

  Reply by Michael Garthwaite on 09 February 2023, 09:24
  > RESOLVED.

----------------------------------------
File: sources/gui/GuiController.cpp
Revision Comment by Sean Nash on 09 February 2023, 08:37 
https://devapps.diality.us/cru/UI-DEN-14733-2#c16447

  Any reason this alarm is commented out?

  Reply by Behrouz NematiPour on 09 February 2023, 10:05
  > It was removed.
  > UI sends an alarmTriggered to HD for that, and should not
  > display a dialog by itself.
  > Since on the device, if there is no other alarm HD will
  > eventually display it, and if there is HD will override it.
  > It was just a bug in development then, which was always
  > displaying a useless dialog on VM that doesn't even have a
  > physical SD Card.

    Reply by Sean Nash on 09 February 2023, 11:08
    > So we will likely remove this TODO and comment later?
    > RESOLVED.


---

ID: UI-DEN-14733-2 https://devapps.diality.us/cru/UI-DEN-14733-2

Title: UI-DEN-14733_UI BN S90
Statement of Objectives:
commit : [e5bfc98f|http://devapps.diality.us:7990/projects/UI/repos/application/commits/e5bfc98f] - DEN-14736 : IMP: Dry-Demo Support
 - added the CLI switch -D : --enable-dry-demo
 - added the CLI switch -A : --active-can-bus <CANBus>
 - added the CLI switch -F : --disable-fault-screen
 - will send confirmation response with ConfirmationID of 99 and as accepted(1):
 - e.g. 03:32:29.560,bb00,UI,Confirm,99,1

-------------------------------------------------------------------------------------------------
commit : [bae9ba50|http://devapps.diality.us:7990/projects/UI/repos/application/commits/bae9ba50] - DEN-14736 : IMP: DEN-14779: In-Tx Qb, Qd, PBo, PBA Adj

-------------------------------------------------------------------------------------------------
commit : [74e27f26|http://devapps.diality.us:7990/projects/UI/repos/application/commits/74e27f26] - DEN-14736 : IMP: Secured the SD-Card mount
 - added security recommended USB mount flags
      MS_SYNCHRONOUS
      MS_NOEXEC
      MS_NODEV
      MS_NOSUID

-------------------------------------------------------------------------------------------------
commit : [f4b8d033|http://devapps.diality.us:7990/projects/UI/repos/application/commits/f4b8d033] - DEN-14736 : IMP: Removed the SD-Card alarm dialog
 - it is not clear what needs to be done when SD-Card fails after a successful POST.
 - May need to send an alarmTrigger to HD and stop logging.
 - Removed for now.

-------------------------------------------------------------------------------------------------
commit : [86947a85|http://devapps.diality.us:7990/projects/UI/repos/application/commits/86947a85] - DEN-14736 : IMP: Shutdown dialog / Alarm Dialog
 - The shutdown dialog closure was not maximizing the minimized alarm dialog

-------------------------------------------------------------------------------------------------
commit : [27745bad|http://devapps.diality.us:7990/projects/UI/repos/application/commits/27745bad] - DEN-14736 : IMP: DEN-14779: In-Tx Qb, Qd, PBo, PBA Adj

-------------------------------------------------------------------------------------------------
commit : [52b9edb8|http://devapps.diality.us:7990/projects/UI/repos/application/commits/52b9edb8] - DEN-14736 : IMP: Unhandled Msg ID log
 - Added the messaged Id to the Unhandled messages log


State: Closed

Summary: 

Author: Behrouz NematiPour
Moderator: Behrouz NematiPour
Reviewers: (5 active, 2 completed*)
     Sean Nash   (*)
     vduong   (*)
     jreaume
     Tiffany Mejia
     Michael Garthwaite
     Dara Navaei
     jishii