This is a list of all comments for UI-DEN-14936-1.

Review Summary: No summary


----------------------------------------
File: sources/model/hd/data/posttreatment/MPostTreatmentStatesData.h
Revision Comment by Sean Nash on 29 March 2023, 15:46 
https://devapps.diality.us/cru/UI-DEN-14936-1#c16985

  In post-treatment, there are a few states to work through to
  ensure reservoirs get drained:
  
  /* Post-Treatment drain reservoirs state machine. */
  typedef enum Drain_States
  \{
      DRAIN_DG_DEPRIME_STATE = 0,
  ///< Drain DG De-prime dialysate lines of excess fluid state.
  
      DRAIN_RESERVOIR_SWITCH_STATE,
  ///< Switch reservoir state.
      DRAIN_RESERVOIR_START_DRAIN_STATE,
  ///< Drain reservoir start drain state.
      DRAIN_RESERVOIR_DRAIN_STATE,
  ///< Drain first reservoir state.
      DRAIN_RESERVOIR_COMPLETE_STATE,
  ///< Drain complete state.
      NUM_OF_DRAIN_STATES
  ///< Number of drain states.
  \} DRAIN_STATE_T;

  Reply by Behrouz NematiPour on 30 March 2023, 01:04
  > Not clear what you want me to do here?

    Reply by Sean Nash on 30 March 2023, 17:30
    > Your comment has ???.  Trying to help.

      Reply by Behrouz NematiPour on 30 March 2023, 17:41
      > Thanks, 
      > Will update my comment.

        Reply by Sean Nash on 30 March 2023, 17:58
        > RESOLVED.

----------------------------------------
File: sources/model/dg/data/MDGConductivityData.cpp
Revision Comment by Sean Nash on 29 March 2023, 15:26 
https://devapps.diality.us/cru/UI-DEN-14936-1#c16983

  I think the raw order should be cpi, cpo, cd1, cd2 (reverse of
  what's here).  Same order issue with status below.

  Reply by Behrouz NematiPour on 30 March 2023, 01:07
  > Great catch,
  > Thank a lot Sean for catching that.
  > It is fixed.

    Reply by Sean Nash on 30 March 2023, 17:31
    > RESOLVED.

Revision Comment by Sean Nash on 29 March 2023, 15:28 
https://devapps.diality.us/cru/UI-DEN-14936-1#c16984

  Same ordering should apply here (even if order doesn't matter -
  prefer to match structure of message payload).

  Reply by Behrouz NematiPour on 30 March 2023, 01:07
  > Fixed too.

    Reply by Sean Nash on 30 March 2023, 17:30
    > RESOLVED.


---

ID: UI-DEN-14936-1 https://devapps.diality.us/cru/UI-DEN-14936-1

Title: UI-DEN-14936_UI BN S93
Statement of Objectives:


State: Closed

Summary: 

Author: Behrouz NematiPour
Moderator: Behrouz NematiPour
Reviewers: (5 active, 2 completed*)
     Sean Nash   (*)
     jishii   (*)
     jreaume
     vduong
     Tiffany Mejia
     Michael Garthwaite
     Dara Navaei