UI-DEN-15279-1 DEN-15279-UI-BN-S97-Cybersecurity-Application [ Ready ]

closed on 19 Oct 23

Author

Moderator

Reviewers

Dara Navaei
vduong (deleted user)
jreaume (deleted user)
pvedantam (deleted user)
msuleiman (deleted user)

DEN-15279-UI-BN-S97-Cybersecurity-Application [ Ready ]

Activity

Details
Objectives
General Comments 0
Unresolved
Resolved
Number of files included: 124

application 0
- Folder resources/images 0
  - File EjectDisabled.png 0 Remove
  - File EjectEnabled.png 0 Remove
  - File eject.png 0 Remove
- File scripts 0 Remove
  - File autostart 0 Remove
  - File bluetooth_paired_clear.sh 0 Remove
  - File bluetooth_paired_query.sh 0 Remove
  - File brightness_get.sh 0 Remove
  - File brightness_set.sh 0 Remove
  - File crypt_setup.sh 0 Remove
  - File date_time_set.sh 0 Remove
  - File decommission.sh 0 Remove
  - File export_logs.sh 0 Remove
  - File factory_reset.sh 0 Remove
  - File globals.sh 3 Remove
  - File lockdown.sh 0 Remove
  - File rootsshaccess_get.sh 0 Remove
  - File rootsshaccess_set.sh 0 Remove
  - File run.sh 0 Remove
  - File setup.sh 0 Remove
  - File start.sh 3 Remove
  - File wifi_disconnect_network.sh 0 Remove
  - File wifi_generate_wpa_supplicant.sh 0 Remove
  - File wifi_read_dns.sh 0 Remove
  - File wifi_read_gateway.sh 0 Remove
  - File wifi_read_ip_settings.sh 0 Remove
  - File wifi_request_auto_assigned_ip.sh 0 Remove
  - File wifi_reset_adapter.sh 0 Remove
  - File wifi_reset_interface.sh 0 Remove
  - File wifi_save_dhcp_interface.sh 0 Remove
  - File wifi_save_static_interface_assignments.sh 0 Remove
  - File wifi_scan_for_networks.sh 0 Remove
  - File wifi_set_auto_assigned_ip.sh 0 Remove
  - File wifi_set_dns.sh 0 Remove
  - File wifi_set_gateway.sh 0 Remove
  - File wifi_set_static_ip.sh 0 Remove
  - File wifi_set_subnetmask.sh 0 Remove
  - File wifi_start_wpa_supplicant.sh 0 Remove
  - File wifi_test_internet.sh 0 Remove
- Folder sources 0
  - Folder canbus 0
    - File CanInterface.cpp 0 Remove
    - File CanInterface.h 0 Remove
    - File MessageDispatcher.cpp 0 Remove
    - File MessageInterpreter.cpp 3 Remove
  - Folder cloudsync 0
    - File CloudSyncController.cpp 0 Remove
    - File CloudSyncController.h 0 Remove
  - Folder device 0
    - File DeviceController.cpp 13 Remove
    - File DeviceController.h 0 Remove
    - File DeviceError.cpp 0 Remove
    - File DeviceError.h 0 Remove
    - File DeviceGlobals.h 0 Remove
    - File DeviceModels.cpp 0 Remove
    - File DeviceModels.h 0 Remove
    - File DeviceView.cpp 0 Remove
    - File DeviceView.h 3 Remove
  - Folder gui 0
    - Folder qml 0
      - Folder components 0
        
        File MainMenu.qml 0 Remove
        
        File TextEntry.qml 6 Remove
        
        File USBButton.qml 0 Remove
      - Folder compounds 0
        
        File TouchGrid.qml 0 Remove
      - Folder globals 0
        
        File Fonts.qml 0 Remove
      - Folder pages 0
        
        Folder settings 0
        
        File SettingsBluetoothCuff.qml 0 Remove
        
        File SettingsDG.qml 0 Remove
        
        File SettingsDateTime.qml 0 Remove
        
        File SettingsDecommission.qml 0 Remove
        
        File SettingsDeviceRegistration.qml 0 Remove
        
        File SettingsExportLogs.qml 0 Remove
        
        File SettingsFactoryReset.qml 0 Remove
        
        File SettingsHome.qml 0 Remove
        
        File SettingsInformation.qml 0 Remove
        
        File SettingsManufacturingSetup.qml 0 Remove
        
        File SettingsROInput.qml 0 Remove
        
        File SettingsRootSSHAccess.qml 0 Remove
        
        File SettingsServicePassword.qml 9 Remove
        
        File SettingsStack.qml 0 Remove
        
        File SettingsVolumeBrightness.qml 0 Remove
        
        File SettingsWiFi.qml 0 Remove
        
        File MainStack.qml 0 Remove
        
        File UserConfirmation.qml 0 Remove
      - File main.qml 3 Remove
    - File GuiController.cpp 0 Remove
    - File GuiController.h 0 Remove
    - File GuiView.cpp 0 Remove
    - File GuiView.h 0 Remove
  - Folder model 0
    - Folder hd/alarm 0
      - File MAlarmMapping.cpp 0 Remove
    - File MModel.h 0 Remove
  - Folder storage 0
    - File FileHandler.cpp 2 Remove
    - File FileHandler.h 0 Remove
    - File Logger.cpp 9 Remove
    - File Logger.h 0 Remove
    - File Settings.cpp 12 Remove
    - File Settings.h 3 Remove
    - File StorageGlobals.cpp 5 Remove
    - File StorageGlobals.h 0 Remove
    - File TreatmentLog.cpp 0 Remove
  - Folder utility 0
    - File encryption.cpp 0 Remove
    - File encryption.h 0 Remove
  - Folder view 0
    - Folder hd/data 0
      - File VHDOperationModeData.cpp 0 Remove
      - File VHDOperationModeData.h 0 Remove
    - Folder settings 0
      - File VAdjustmentAlarmVolume.cpp 3 Remove
      - File VAdjustmentAlarmVolume.h 0 Remove
      - File VAdjustmentVersions.cpp 0 Remove
      - File VDateTime.cpp 0 Remove
      - File VDuetRoWaterDG.cpp 0 Remove
      - File VSettings.cpp 0 Remove
      - File VSettings.h 0 Remove
  - Folder wifi 0
    - File WifiInterface.cpp 0 Remove
    - File WifiInterface.h 0 Remove
  - File AlarmGenerator.cpp 0 Remove
  - File AlarmGenerator.h 0 Remove
  - File ApplicationController.cpp 3 Remove
  - File ApplicationController.h 6 Remove
  - File ApplicationPost.cpp 3 Remove
  - File ApplicationPost.h 0 Remove
  - File MainTimer.cpp 0 Remove
  - File MainTimer.h 0 Remove
  - File Threads.cpp 0 Remove
  - File main.h 0 Remove
- File AlarmMapping.csv 0 Remove
- File cppcheck.err 0 Remove
- File cppcheck.log 0 Remove
- File cpplint.py 0 Remove
- File denali.pro 0 Remove
- File denali.pro.user 0 Remove
- File denali.qrc 0 Remove
- File main.cpp 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Behrouz NematiPour	Author & Moderator	1h 54m	26	Correct, it was a typo and fixed.
Michael Garthwaite	Reviewer - 0% reviewed	3m
Tiffany Mejia	Reviewer - 10% reviewed	6m
Sean Nash	Reviewer - 0% reviewed
Dara Navaei	Reviewer - 7% reviewed	3m	7	RESOLVED
vduong (deleted user)	Reviewer - Complete	5h 19m	49	RESOLVED
jreaume (deleted user)	Reviewer - 0% reviewed
pvedantam (deleted user)	Reviewer - 30% reviewed	1h 48m	5	It appears that we are checking string fields of the ethe...
msuleiman (deleted user)	Reviewer - Complete	31m	2	Should use {} for if statement
Total		9h 47m	89

#permalink

Objectives

There are no specific objectives for this review.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee
DEN-15875
DEN-15646

#permalink

General Comments

There are no general comments on this review.

Click to load diff

/scripts/wifi_generate_wpa_supplicant.sh Deleted

Click to load diff

/scripts/wifi_request_auto_assigned_ip.sh Deleted

Click to load diff

/scripts/wifi_save_static_interface_assignments.sh Deleted

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: [Crucible Review CR-1\|CR-1]
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

UI-DEN-15279-1

DEN-15279-UI-BN-S97-Cybersecurity-Application [ Ready ]

UI-DEN-15279-1 89

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time

DEN-15279-UI-BN-S97-Cybersecurity-Application [ Ready ]

UI-DEN-15279-1 89

Summarize the review outcomes (optional)

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time