This is a list of all comments for UI-DEN-15279-5.

Review Summary: No summary


----------------------------------------
File: scripts/factory_reset.sh
Revision Comment by vduong on 17 July 2023, 08:09 
https://devapps.diality.us/cru/UI-DEN-15279-5#c18119

  FOUNT -> FOUND ?

  Reply by Behrouz NematiPour on 17 July 2023, 15:27
  > Fixed

    Reply by vduong on 17 July 2023, 16:01
    > RESOLVED

Revision Comment by vduong on 17 July 2023, 08:14 
https://devapps.diality.us/cru/UI-DEN-15279-5#c18120

  exits -> exists ?

  Reply by Behrouz NematiPour on 17 July 2023, 15:27
  > Thanks for catching that, it was actually a bug.
  > Fixed.

    Reply by vduong on 17 July 2023, 16:01
    > RESOLVED

Revision Comment by vduong on 17 July 2023, 08:15 
https://devapps.diality.us/cru/UI-DEN-15279-5#c18121

  condistion -> condition

  Reply by Behrouz NematiPour on 17 July 2023, 15:26
  > fixed

    Reply by vduong on 17 July 2023, 16:01
    > RESOLVED

----------------------------------------
File: scripts/globals.sh
Revision Comment by pvedantam on 17 July 2023, 16:01 
https://devapps.diality.us/cru/UI-DEN-15279-5#c18187

  Not related to this release, but 5 secs seems excessive to
  setup the bluetooth

  Reply by Dara Navaei on 19 October 2023, 10:30
  > RESOLVED

Revision Comment by pvedantam on 17 July 2023, 16:05 
https://devapps.diality.us/cru/UI-DEN-15279-5#c18188

  Not related to this release, 2 secs does seem excessive. Also
  we need to plan on forking them out.

  Reply by Dara Navaei on 19 October 2023, 10:30
  > RESOLVED

Revision Comment by vduong on 17 July 2023, 08:18 
https://devapps.diality.us/cru/UI-DEN-15279-5#c18122

  Applicaion - > Application

  Reply by Behrouz NematiPour on 17 July 2023, 15:26
  > Fixed

    Reply by vduong on 17 July 2023, 16:01
    > RESOLVED

----------------------------------------
File: scripts/lockdown.sh
Revision Comment by vduong on 17 July 2023, 08:18 
https://devapps.diality.us/cru/UI-DEN-15279-5#c18123

  Why did we remove the copyright header?

  Reply by vduong on 17 July 2023, 14:40
  > RESOLVED

----------------------------------------
File: scripts/setup.sh
Revision Comment by vduong on 17 July 2023, 08:28 
https://devapps.diality.us/cru/UI-DEN-15279-5#c18124

  Do we need sudo here ? What user are we currently logged in as
  when we run this script ?

  Reply by Behrouz NematiPour on 17 July 2023, 15:10
  > the setup.sh script is running in manufacturing setup mode
  > which is completely running by root user.

    Reply by vduong on 17 July 2023, 16:00
    > RESOLVED.

Revision Comment by vduong on 17 July 2023, 08:29 
https://devapps.diality.us/cru/UI-DEN-15279-5#c18125

  There is a " systemctl stop <service> " That we should use
  instead of killall since the qt stuff is using systemctl to
  start.

  Reply by Behrouz NematiPour on 17 July 2023, 14:49
  > this is a one time and the systemctl is used to disable the
  > service.
  > I think that is sufficient for now.

    Reply by vduong on 17 July 2023, 15:06
    > Ok, 
    > RESOLVED

----------------------------------------
File: scripts/start.sh
Revision Comment by vduong on 17 July 2023, 08:32 
https://devapps.diality.us/cru/UI-DEN-15279-5#c18126

  Continueing -> continuing

  Reply by vduong on 17 July 2023, 14:40
  > RESOLVED

----------------------------------------
File: scripts/bluetooth_paired_clear.sh
Revision Comment by msuleiman on 17 July 2023, 09:36 
https://devapps.diality.us/cru/UI-DEN-15279-5#c18129

  Given that the code frequently utilizes the range 8-25, it
  would be sensible to replace it with variables. By utilizing
  variables, you only need to modify the values once.

  Reply by Behrouz NematiPour on 17 July 2023, 14:52
  > A ticket has been created for this and will be addressed,
  > followed up later.

    Reply by Dara Navaei on 19 October 2023, 10:30
    > RESOLVED


---

ID: UI-DEN-15279-5 https://devapps.diality.us/cru/UI-DEN-15279-5

Title: DEN-15279-UI-BN-S97-Cybersecurity-Scripts [ Ready ]
Statement of Objectives:


State: Closed

Summary: 

Author: Behrouz NematiPour
Moderator: Behrouz NematiPour
Reviewers: (5 active, 2 completed*)
     vduong   (*)
     msuleiman   (*)
     Sean Nash
     pvedantam
     Tiffany Mejia
     Michael Garthwaite
     Dara Navaei