This is a list of all comments for UI-DEN-15833-10.

Review Summary: No summary


----------------------------------------
File: sources/storage/Settings.cpp
Revision Comment by Behrouz NematiPour on 28 July 2023, 01:30 
https://devapps.diality.us/cru/UI-DEN-15833-10#c18293

  please do not use else.
  make it like the others on top.
  Look at lines 79 - 83.
  And insert it in between lines 89,90
  with two empty line on top and bottom of the if block
  
  {code}
  if ( ! codition ) {
    err = ;
    LOG_ ;
    return err;
  }
  {code}
  
  thanks

  Reply by vduong on 28 July 2023, 05:35
  > Changed

    Reply by Behrouz NematiPour on 01 August 2023, 18:22
    > RESOLVED

----------------------------------------
File: sources/view/hd/data/VTreatmentRanges.cpp
Revision Comment by Behrouz NematiPour on 28 July 2023, 01:43 
https://devapps.diality.us/cru/UI-DEN-15833-10#c18298

  this is incorrect connection usage.
  it should be moved to the applicationController class.
  
  The rule of API design:
   - the API is just emitting the signal
   - and is not responsible for the usage.
   - any object which needs to use it will connect and use
  (connects the signal to its own slot and runs the logic in its
  own thread)
  
  Please move to ApplicationController class.

  Reply by vduong on 28 July 2023, 05:34
  > Changed based on how GuiView handles the connection from a
  > created-in-QML object.

    Reply by Behrouz NematiPour on 01 August 2023, 18:23
    > Thanks for reminding me the situation with the comment.
    > that is right in View classes we need to.
    > maybe later we can move these checks all in the settings
    > controller, from this view.
    > 
    > RESOLVED.

Revision Comment by Behrouz NematiPour on 28 July 2023, 01:34 
https://devapps.diality.us/cru/UI-DEN-15833-10#c18294

  please align
  SIGNAL(did
    SLOT( on

  Reply by vduong on 28 July 2023, 05:00
  > This I will align similar to how the others look in the
  > AppController. The SLOT/SIGNAL keywords are aligned.

    Reply by Behrouz NematiPour on 01 August 2023, 18:23
    > RESOLVED

Revision Comment by Behrouz NematiPour on 28 July 2023, 01:37 
https://devapps.diality.us/cru/UI-DEN-15833-10#c18296

  add an empty line before and after

  Reply by vduong on 28 July 2023, 05:35
  > Added.

    Reply by Behrouz NematiPour on 01 August 2023, 18:22
    > RESOLVED

Revision Comment by Behrouz NematiPour on 28 July 2023, 01:38 
https://devapps.diality.us/cru/UI-DEN-15833-10#c18297

  please check, lists are not empty.
  can be checked by private member variable:   
  {code}
  isConfigOk = isConfigOk && ! _<Property Name>.isEmpty();
  {code}

  Reply by vduong on 28 July 2023, 05:35
  > Added.

    Reply by Behrouz NematiPour on 01 August 2023, 18:21
    > RESOLVED


---

ID: UI-DEN-15833-10 https://devapps.diality.us/cru/UI-DEN-15833-10

Title: UI-DEN-15833_UI VD S101 - UI - Post Settings Check - [ READY ]
Statement of Objectives:


State: Closed

Summary: 

Author: vduong
Moderator: vduong
Reviewers: (5 active, 3 completed*)
     Tiffany Mejia   (*)
     msuleiman   (*)
     Behrouz NematiPour   (*)
     Sean Nash
     jreaume
     jpaguio
     Michael Garthwaite
     Dara Navaei