This is a list of all comments for UI-DEN-15905-11.

Review Summary: No summary


----------------------------------------
File: scripts/lockdown.sh
Revision Comment by vduong on 28 July 2023, 04:53 
https://devapps.diality.us/cru/UI-DEN-15905-11#c18304

  Do we need to check that the /media/sd-card is already mounted?
  Or is the assumption that it's always there?

  Reply by Behrouz NematiPour on 28 July 2023, 10:33
  > that could be a good idea,
  > but in lockdown we assume the application POST is passed,
  > otherwise we cannot do the manufacturing setup.
  > so technically it already checked in application POST.

    Reply by vduong on 28 July 2023, 11:04
    > RESOLVED

----------------------------------------
File: scripts/setup.sh
Revision Comment by vduong on 28 July 2023, 04:54 
https://devapps.diality.us/cru/UI-DEN-15905-11#c18305

  The comment is incorrect for the params.

  Reply by Behrouz NematiPour on 28 July 2023, 10:35
  > fixed.

    Reply by vduong on 28 July 2023, 11:04
    > RESOLVED

----------------------------------------
File: scripts/usb_mount.sh
Revision Comment by vduong on 28 July 2023, 04:55 
https://devapps.diality.us/cru/UI-DEN-15905-11#c18306

  Did you resolve the ^M character issue we saw yesterday in
  these commits too ?

  Reply by Behrouz NematiPour on 28 July 2023, 10:30
  > yes, I did.
  > that is actually the only change in here.

    Reply by vduong on 28 July 2023, 11:03
    > RESOLVED


---

ID: UI-DEN-15905-11 https://devapps.diality.us/cru/UI-DEN-15905-11

Title: UI-DEN-15905-UI-BN-S102 - UpdateOnly - ui.scripts [ Ready ]
Statement of Objectives:


State: Closed

Summary: 

Author: Behrouz NematiPour
Moderator: Behrouz NematiPour
Reviewers: (4 active, 2 completed*)
     vduong   (*)
     msuleiman   (*)
     Sean Nash
     Tiffany Mejia
     Michael Garthwaite
     Dara Navaei