This is a list of all comments for UI-DEN-15905-12.

Review Summary: No summary


----------------------------------------
File: sources/canbus/FrameInterface.cpp
Revision Comment by vduong on 29 July 2023, 20:29 
https://devapps.diality.us/cru/UI-DEN-15905-12#c18330

  Please put //DEBUG

  Reply by Behrouz NematiPour on 30 July 2023, 13:11
  > added

    Reply by vduong on 31 July 2023, 04:33
    > RESOLVED

----------------------------------------
File: sources/gui/GuiController.cpp
Revision Comment by vduong on 29 July 2023, 20:29 
https://devapps.diality.us/cru/UI-DEN-15905-12#c18331

  Please put //DEBUG

  Reply by Behrouz NematiPour on 30 July 2023, 13:11
  > Added

    Reply by vduong on 31 July 2023, 04:33
    > RESOLVED

----------------------------------------
File: sources/gui/qml/compounds/CheckListView.qml
Revision Comment by vduong on 01 August 2023, 17:16 
https://devapps.diality.us/cru/UI-DEN-15905-12#c18351

  Please add //DEBUG

  Reply by Behrouz NematiPour on 01 August 2023, 22:17
  > added

    Reply by vduong on 02 August 2023, 02:43
    > RESOLVED

Revision Comment by vduong on 01 August 2023, 17:16 
https://devapps.diality.us/cru/UI-DEN-15905-12#c18352

  Did you intentionally left this commented out ?

  Reply by Behrouz NematiPour on 01 August 2023, 19:36
  > yes I did.

    Reply by vduong on 02 August 2023, 02:42
    > RESOLVED

Revision Comment by vduong on 01 August 2023, 17:16 
https://devapps.diality.us/cru/UI-DEN-15905-12#c18353

  //DEBUG, please

  Reply by Behrouz NematiPour on 01 August 2023, 22:28
  > Added

    Reply by vduong on 02 August 2023, 02:43
    > RESOLVED

----------------------------------------
File: sources/view/hd/data/pretreatment/VPreTreatmentStatesData.cpp
Revision Comment by vduong on 01 August 2023, 17:18 
https://devapps.diality.us/cru/UI-DEN-15905-12#c18354

  Type in the name, reservoir missing an r

  Reply by Behrouz NematiPour on 01 August 2023, 22:18
  > Fixed

    Reply by vduong on 02 August 2023, 02:43
    > RESOLVED

----------------------------------------
File: sources/view/hd/data/pretreatment/VPreTreatmentStatesData.h
Revision Comment by vduong on 01 August 2023, 17:18 
https://devapps.diality.us/cru/UI-DEN-15905-12#c18355

  Do you have the HD state for these like the other ones we have
  ? If yes, can you please put the ///<

  Reply by Behrouz NematiPour on 01 August 2023, 19:34
  > these are combined/bundled states.
  > look into the cpp.
  > that is I added an extra _ in the name to distinguish them.

    Reply by vduong on 02 August 2023, 02:42
    > RESOLVED


---

ID: UI-DEN-15905-12 https://devapps.diality.us/cru/UI-DEN-15905-12

Title: DEN-15905 - DEN-15548 - UI-BN-S102-Log178 - Application [ Ready ]
Statement of Objectives:


State: Closed

Summary: 

Author: Behrouz NematiPour
Moderator: Behrouz NematiPour
Reviewers: (5 active, 2 completed*)
     vduong   (*)
     msuleiman   (*)
     Sean Nash
     jreaume
     Tiffany Mejia
     Michael Garthwaite
     Dara Navaei