This is a list of all comments for UI-DEN-16288-1.

Review Summary: No summary


----------------------------------------
File: sources/device/DeviceController.cpp
Revision Comment by msuleiman on 28 August 2023, 09:18 
https://devapps.diality.us/cru/UI-DEN-16288-1#c18751

  If statement - needs indentation

  Reply by Behrouz NematiPour on 30 August 2023, 17:10
  > It currently has.

    Reply by Dara Navaei on 19 October 2023, 10:22
    > RESOLVED

Revision Comment by msuleiman on 28 August 2023, 09:20 
https://devapps.diality.us/cru/UI-DEN-16288-1#c18752

  if statement indentation

  Reply by Behrouz NematiPour on 30 August 2023, 17:10
  > It currently has.

    Reply by msuleiman on 11 September 2023, 12:53
    > RESOLVED

----------------------------------------
File: sources/gui/qml/pages/settings/SettingsRootSSHAccess.qml
Revision Comment by vduong on 28 August 2023, 07:13 
https://devapps.diality.us/cru/UI-DEN-16288-1#c18750

  Did you mean to keep this commented out ?

  Reply by Behrouz NematiPour on 31 August 2023, 10:56
  > removed

    Reply by vduong on 31 August 2023, 11:25
    > RESOLVED

----------------------------------------
File: sources/gui/qml/AlarmItem.qml
Revision Comment by vduong on 30 August 2023, 05:10 
https://devapps.diality.us/cru/UI-DEN-16288-1#c18767

  typo

  Reply by Behrouz NematiPour on 31 August 2023, 10:57
  > thank you, 
  > fixed.

    Reply by vduong on 31 August 2023, 11:25
    > RESOLVED

----------------------------------------
File: sources/gui/qml/PowerItem.qml
Revision Comment by vduong on 30 August 2023, 05:11 
https://devapps.diality.us/cru/UI-DEN-16288-1#c18768

  typo

  Reply by Behrouz NematiPour on 31 August 2023, 10:57
  > fixed

    Reply by vduong on 31 August 2023, 11:26
    > RESOLVED

----------------------------------------
File: sources/gui/qml/dialogs/ConfirmDialog.qml
Revision Comment by vduong on 30 August 2023, 05:03 
https://devapps.diality.us/cru/UI-DEN-16288-1#c18766

  This property is not being used.
  
  Also, you might be able to alias the property that the Dialog
  (root component of ModalDialog).

  Reply by Behrouz NematiPour on 30 August 2023, 17:08
  > it is being used and tend to be the bool.
  > being alias of what?
  > it is being used to let the dialog know if the dialog can be
  > closed upon button press or just emit the signal.

    Reply by vduong on 31 August 2023, 16:54
    > RESOLVED

----------------------------------------
File: main.cpp
Revision Comment by vduong on 31 August 2023, 11:28 
https://devapps.diality.us/cru/UI-DEN-16288-1#c18783

  I suggest doing --enable-update-mode (all lowercase) to be
  consistent with the other params

  Reply by Behrouz NematiPour on 11 September 2023, 11:52
  > good comment,
  > will do in the next release

    Reply by vduong on 11 September 2023, 12:00
    > RESOLVED

----------------------------------------
File: sources/view/settings/VSettings.cpp
Revision Comment by vduong on 31 August 2023, 11:26 
https://devapps.diality.us/cru/UI-DEN-16288-1#c18782

  her. => here.

  Reply by Behrouz NematiPour on 11 September 2023, 12:42
  > fixed.

    Reply by Behrouz NematiPour on 11 September 2023, 13:03
    > Since Vy is busy and it is not a code change and is only
    > type
    > I do resolve on her behalf.
    > RESOLVED


---

ID: UI-DEN-16288-1 https://devapps.diality.us/cru/UI-DEN-16288-1

Title: UI-DEN-16288_UI BN S104 [ ready - application ]
Statement of Objectives:


State: Closed

Summary: 

Author: Behrouz NematiPour
Moderator: Behrouz NematiPour
Reviewers: (6 active, 2 completed*)
     vduong   (*)
     msuleiman   (*)
     Sean Nash
     jreaume
     Tiffany Mejia
     jpaguio
     Michael Garthwaite
     Dara Navaei