UI-DEN-16597-28 UI Bugfix/DEN-16597: UI-BN-S114

closed on 17 Jan 24

Author

Moderator

Reviewers

Dara Navaei
vduong (deleted user)
jpaguio (deleted user)
msuleiman (deleted user)

UI Bugfix/DEN-16597: UI-BN-S114

Activity

Details
Objectives
General Comments 2
Unresolved
Resolved
Number of files included: 17

application 0
- Folder sources 0
  - Folder gui/qml 0
    - Folder components 0
      - File GridSelection.qml 0 Remove
      - File SliderCreateTreatment.qml 0 Remove
    - Folder pages 0
      - Folder pretreatment/create 0
        
        File PreTreatmentCreate.qml 0 Remove
        
        File PreTreatmentCreateStack.qml 0 Remove
      - Folder settings 0
        
        File SettingsExportLogs.qml 0 Remove
      - Folder treatment 0
        
        File TreatmentHome.qml 0 Remove
      - File MainStack.qml 0 Remove
    - File AlarmItem.qml 0 Remove
  - Folder view 0
    - Folder hd 0
      - Folder adjustment 0
        
        Folder common 0
        
        File VCommonAdjustmentVitals.cpp 0 Remove
        
        File VCommonAdjustmentVitals.h 0 Remove
        
        Folder posttreatment 0
        
        File VPostTreatmentAdjustTreatmentLog.h 0 Remove
      - Folder alarm 0
        
        File VAlarmActiveList.h 0 Remove
        
        File VAlarmStatus.cpp 0 Remove
        
        File VAlarmStatus.h 0 Remove
    - Folder settings 0
      - File VDuetRoWaterDG.h 0 Remove
      - File VSettings.h 0 Remove
  - File main.h 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Behrouz NematiPour	Author & Moderator	13m	2	http://devapps.diality.us:8060/cru/UI-DEN-16597-29 RESOLVED
Michael Garthwaite	Reviewer - 0% reviewed
Tiffany Mejia	Reviewer - 0% reviewed
Sean Nash	Reviewer - 0% reviewed
Dara Navaei	Reviewer - 0% reviewed
vduong (deleted user)	Reviewer - 0% reviewed
jpaguio (deleted user)	Reviewer - 0% reviewed
msuleiman (deleted user)	Reviewer - 0% reviewed
Total		13m	2

#permalink

Objectives

There are no specific objectives for this review.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

Behrouz NematiPour

another CR has been created due to some commit issues on the review branch.

17 Jan 24

Behrouz NematiPour

Resolved

17 Jan 24

Behrouz NematiPour

http://devapps.diality.us:8060/cru/UI-DEN-16597-29 RESOLVED

http://devapps.diality.us:8060/cru/UI-DEN-16597-29
RESOLVED

17 Jan 24

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: [Crucible Review CR-1\|CR-1]
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

UI-DEN-16597-28

UI Bugfix/DEN-16597: UI-BN-S114

UI-DEN-16597-28 2

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Behrouz NematiPour

Behrouz NematiPour

Log time

UI Bugfix/DEN-16597: UI-BN-S114

UI-DEN-16597-28 2

Summarize the review outcomes (optional)

Details

Objectives

Branches in review

Issues Raised From Comments

General Comments

Behrouz NematiPour

Behrouz NematiPour

Log time