UI-DEN-2236-1 UI-DEN-2236_UI 100% Coverage of the Application Software

closed on 27 Apr 20

Author

Moderator

Reviewers

UI-DEN-2236_UI 100% Coverage of the Application Software

Activity

Details
Objectives
General Comments 0
Unresolved
Resolved
Number of files included: 158

application 0
- Folder resources/images 0
  - File Close.png 0 Remove
- Folder sources 0
  - Folder canbus 0
    - File caninterface.cpp 0 Remove
    - File frameinterface.cpp 0 Remove
    - File frameinterface.h 0 Remove
    - File messageacknowmodel.cpp 0 Remove
    - File messagebuilder.cpp 0 Remove
    - File messagebuilder.h 0 Remove
    - File messagedispatcher.cpp 0 Remove
    - File messagedispatcher.h 0 Remove
    - File messageglobals.h 0 Remove
    - File messageinterpreter.cpp 0 Remove
    - File messageinterpreter.h 0 Remove
  - Folder gui 0
    - Folder qml 0
      - Folder components 0
        
        File BackButton.qml 0 Remove
        
        File Circle.qml 0 Remove
        
        File CloseButton.qml 0 Remove
        
        File ConfirmButton.qml 0 Remove
        
        File Line.qml 0 Remove
        
        File LogoD.qml 0 Remove
        
        File MainMenu.qml 0 Remove
        
        File ModalDialog.qml 0 Remove
        
        File ModelessDialog.qml.WIP 0 Remove
        
        File NotificationBar.qml 0 Remove
        
        File PlaceHolderText.qml 0 Remove
        
        File ProgressBar.qml 0 Remove
        
        File ProgressBarEx.qml 0 Remove
        
        File ProgressCircle.qml 0 Remove
        
        File ProgressRect.qml 0 Remove
        
        File RangeBar.qml 0 Remove
        
        File RangeMarker.qml 0 Remove
        
        File RangeRect.qml 0 Remove
        
        File ScreenItem.qml 0 Remove
        
        File Slider.qml 0 Remove
        
        File StackItem.qml 0 Remove
        
        File TextRect.qml 0 Remove
        
        File TickMarks.qml 0 Remove
        
        File TimeText.qml 0 Remove
        
        File TitleText.qml 0 Remove
        
        File TouchArea.qml 0 Remove
        
        File TouchRect.qml 0 Remove
      - Folder dialogs 0
        
        File AutoHideInfo.qml 0 Remove
        
        File PowerOff.qml 0 Remove
      - Folder globals 0
        
        File Colors.qml 0 Remove
        
        File Fonts.qml 0 Remove
        
        File Variables.qml 0 Remove
      - Folder pages 0
        
        Folder treatment 0
        
        Folder adjustments 0
        
        File TreatmentAdjustmentBase.qml 0 Remove
        
        File TreatmentAdjustmentFlow.qml 0 Remove
        
        File TreatmentFlowAdjustment.qml 0 Remove
        
        Folder sections 0
        
        File TreatmentFlows.qml 0 Remove
        
        File TreatmentFluid.qml 0 Remove
        
        File TreatmentInfusion.qml 0 Remove
        
        File TreatmentPressure.qml 0 Remove
        
        File TreatmentTime.qml 0 Remove
        
        File TreatmentUltrafiltration.qml 0 Remove
        
        File TreatmentVitals.qml 0 Remove
        
        File TreatmentCreate.qml 0 Remove
        
        File TreatmentHome.qml 0 Remove
        
        File TreatmentStack.qml 0 Remove
        
        File TreatmentStart.qml 0 Remove
        
        File ManagerHome.qml 0 Remove
        
        File ManagerStack.qml 0 Remove
        
        File SettingsHome.qml 0 Remove
        
        File SettingsStack.qml 0 Remove
      - File main.qml 0 Remove
    - File guicontroller.cpp 0 Remove
    - File guicontroller.h 0 Remove
    - File guiglobals.cpp 0 Remove
    - File guiglobals.h 0 Remove
    - File guiview.cpp 0 Remove
    - File guiview.h 0 Remove
  - Folder model 0
    - File mmodel.h 0 Remove
    - File mtreatmentadjustblooddialysateresponse.cpp 0 Remove
    - File mtreatmentadjustblooddialysateresponse.h 0 Remove
    - File mtreatmentflows.cpp 0 Remove
    - File mtreatmentflows.h 0 Remove
    - File mtreatmentpressureocclusion.cpp 0 Remove
    - File mtreatmentpressureocclusion.h 0 Remove
    - File mtreatmentranges.cpp 0 Remove
    - File mtreatmentranges.h 0 Remove
  - Folder storage 0
    - File filehandler.cpp 0 Remove
    - File filehandler.h 0 Remove
    - File logger.cpp 0 Remove
    - File usbwatcher.cpp 0 Remove
    - File usbwatcher.h 0 Remove
  - Folder utility 0
    - File format.cpp 0 Remove
    - File format.h 0 Remove
    - File types.cpp 0 Remove
    - File types.h 0 Remove
  - Folder view 0
    - File valarmstatus.cpp 0 Remove
    - File valarmstatus.h 0 Remove
    - File vpoweroff.cpp 0 Remove
    - File vpoweroff.h 0 Remove
    - File vtreatmentadjustmentsresponse.cpp 0 Remove
    - File vtreatmentadjustmentsresponse.h 0 Remove
    - File vtreatmentbloodflow.h 0 Remove
    - File vtreatmentdialysateflow.h 0 Remove
    - File vtreatmentpressureocclusion.cpp 0 Remove
    - File vtreatmentpressureocclusion.h 0 Remove
    - File vtreatmentranges.cpp 0 Remove
    - File vtreatmentranges.h 0 Remove
    - File vtreatmenttime.h 0 Remove
    - File vtreatmentultrafiltration.h 0 Remove
    - File vview.h 0 Remove
  - File applicationcontroller.cpp 0 Remove
  - File applicationcontroller.h 0 Remove
  - File applicationpost.cpp 0 Remove
  - File main.h 0 Remove
  - File maintimer.cpp 0 Remove
  - File threads.cpp 0 Remove
- Folder unittests 0
  - File tst_canbus.cpp 0 Remove
  - File tst_canbus.h 0 Remove
  - File tst_initializations.cpp 0 Remove
  - File tst_initializations.h 0 Remove
  - File tst_logging.cpp 0 Remove
  - File tst_logging.h 0 Remove
  - File tst_messaging.cpp 0 Remove
  - File tst_messaging.h 0 Remove
  - File tst_models.cpp 0 Remove
  - File tst_models.h 0 Remove
  - File tst_threads.cpp 0 Remove
  - File tst_threads.h 0 Remove
  - File tst_utilities.cpp 0 Remove
  - File tst_utilities.h 0 Remove
  - File tst_views.cpp 0 Remove
  - File tst_views.h 0 Remove
- File denali.pro 0 Remove
- File denali.pro.user 0 Remove
- File denali.qrc 0 Remove
- File main.cpp 0 Remove
scripts 0
- Folder build 0
  - File tst_names.lst 0 Remove
  - File unittest.sh 0 Remove
testsuites 0
- Folder shared/scripts 0
  - File crc.py 0 Remove
  - File denaliMessages.py 0 Remove
  - File globals.py 0 Remove
  - File messageBuilder.py 0 Remove
  - File names.py 0 Remove
  - File unittests.py 0 Remove
  - File utils.py 6 Remove
- Folder tst_Alarm 0
  - File test.py 0 Remove
- Folder tst_GlobalTests 0
  - File test.py 0 Remove
- Folder tst_HomeScreen 0
  - File test.py 0 Remove
- Folder tst_Internals 0
  - File test.py 0 Remove
- Folder tst_ServiceShutdown 0
  - File test.py 0 Remove
- Folder tst_TreatmentScreen 0
  - File test.py 0 Remove
- Folder tst_TreatmentTime 0
  - File test.py 0 Remove
- Folder tst_Treatment_Adjustment_BloodDialysate 0
  - File test.py 0 Remove
- Folder tst_Treatment_BloodDialysate_Section 0
  - File test.py 0 Remove
- Folder tst_Treatment_BloodFlowRate 0
  - File test.py 0 Remove
- Folder tst_Treatment_DialysateFlowRate 0
  - File test.py 0 Remove
- Folder tst_Treatment_ParametersRange 0
  - File test.py 0 Remove
- Folder tst_Treatment_PressureOcclusion 0
  - File test.py 0 Remove
- Folder tst_Treatment_Section_BloodDialysate 0
  - File test.py 0 Remove
- Folder tst_Treatment_Time 0
  - File test.py 0 Remove
- Folder tst_Treatment_Ultrafiltration 0
  - File test.py 0 Remove
- Folder tst_homescreen 0
  - File test.py 0 Remove
- Folder tst_pythonversion 0
  - File test.py 0 Remove
- Folder tst_serviceshutdown 0
  - File globals.py 0 Remove
  - File test.py 0 Remove
- File suite.conf 0 Remove

#permalink

Details

Warning: no files are visible, they have all been filtered.

Participant	Role	Time Spent	Comments	Latest Comment
Dara Navaei	Author	6m
Behrouz NematiPour	Moderator	1h 29m	3	Hey Peter, Thanks for the comments and all the testing . ...
plucia (deleted user)	Reviewer - Complete	1h 27m	3	RESOLVED
pmontazemi (deleted user)	Reviewer - Complete	37m
Total		3h 40m	6

Linked issues
- DEN-2236

#permalink

Objectives

There are no specific objectives for this review.

Branches in review

#permalink

Issues Raised From Comments

Key	Summary	State	Assignee

#permalink

General Comments

There are no general comments on this review.

Click to load diff

/sources/.../adjustments/TreatmentFlowAdjustment.qml Deleted

Click to load diff

/tst_Treatment_BloodDialysate_Section/test.py Deleted

Click to load diff

Notation	Description
[Crucible Review CR-1\|CR-1]	Creates a link to a Crucible review or FishEye artifact using the internal key reference for the item. Example: [Crucible Review CR-1\|CR-1]
[Atlassian Crucible\|http://atlassian.com/crucible]	Creates a link to an external resource, special characters that come after the URL and are not part of it must be separated with a space. External links are denoted with an arrow icon. Example: Atlassian Crucible
{cs:id=1\|rep=repository-key}	Render a link to the changeset Example: 1
bold	Makes text appear bold.
_italic_	Makes text appear in italics.
+underline+	Makes text appear underlined.
??citation??	Makes text appear in citation form.
-strikethrough-	Makes text appear ~~struck through~~.
^superscript^	Makes text appear in ^superscript.
~subscript~	Makes text appear in _subscript.
{{ monospaced }}	Placing double curly-brackets around text makes it appear `monospaced`.
{code} // Some comments here public String getFoo() { return foo; } {code}	The code macro displays a preformatted block for showing code with syntax highlighting. Example: // Some comments here public String getFoo() { return foo; }
bq. Block Quote	To make an entire paragraph into a block quotation, place "bq. " before it. Example: Block Quote
{quote} here is quoteable content to be quoted {quote}	Quote a block of text that's longer than one paragraph. Example: here is quoteable content to be quoted
{color:red} look ma, red text!{color}	Changes the color of a block of text. Example: look ma, red text!
* A list with bullets * Second item ** Indented item	Example: A list with bullets Second item Indented item
# A list with numbers # Second item ## Indented item	Example: A list with numbers Second item Indented item

UI-DEN-2236-1

UI-DEN-2236_UI 100% Coverage of the Application Software

UI-DEN-2236-1 6

Details

Linked issues

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time

UI-DEN-2236_UI 100% Coverage of the Application Software

UI-DEN-2236-1 6

Summarize the review outcomes (optional)

Details

Linked issues

Objectives

Branches in review

Issues Raised From Comments

General Comments

Log time