UI-DEN-3875_Logging_2of3

Activity

UI-DEN-3875-1 85

Keyboard shortcuts  
  • Summarize the review outcomes (optional)
     
    #permalink

    Details

    Warning: no files are visible, they have all been filtered.
    Participant Role Time Spent Comments Latest Comment
    Author & Moderator 2h 7m 28 done
    plucia  (deleted user)
    Reviewer completed
    Reviewer - Complete 1h 23m 10 Ok, RESOLVED.
    pmontazemi  (deleted user)
    Reviewer completed
    Reviewer - Complete 59m 47 RESOLVED.
    Total   4h 30m 85  
    #permalink

    Objectives

    There are no specific objectives for this review.

    Branches in review

    #permalink

    Issues Raised From Comments

    Key Summary State Assignee
    #permalink

    General Comments

    There are no general comments on this review.
    /sources/canbus/caninterface.cpp Changed 3
    /sources/canbus/caninterface.h Changed
    /sources/canbus/frameinterface.cpp Changed 3
    /sources/canbus/messageacknowmodel.cpp Changed
    /sources/canbus/messageacknowmodel.h Changed
    /sources/canbus/messagebuilder.cpp Changed 3
    /sources/canbus/messagebuilder.h Changed 3
    /sources/canbus/messagedispatcher.cpp Changed 6
    Open in IDE #permalink
    /sources/canbus/messagedispatcher.h Changed
    /sources/canbus/messageglobals.h Changed 6
    Open in IDE #permalink
    /sources/canbus/messageinterpreter.cpp Changed 7
    Open in IDE #permalink
    /sources/canbus/messageinterpreter.h Changed
    /sources/.../components/NotificationBar.qml Changed
    /sources/.../dialogs/NotificationDialog.qml Changed 6
    /sources/gui/qml/globals/Variables.qml Changed
    /sources/.../adjustments/TreatmentAdjustmentFlow.qml Changed
    /sources/.../adjustments/TreatmentAdjustmentUltrafiltrationConfirm.qml Changed
    /sources/.../adjustments/TreatmentAdjustmentUltrafiltrationEdit.qml Changed 3
    /sources/.../adjustments/TreatmentAdjustmentUltrafiltrationPaused.qml Changed
    /sources/.../adjustments/TreatmentAdjustmentUltrafiltrationStart.qml Changed
    /sources/gui/.../sections/TreatmentFlows.qml Changed
    /sources/.../sections/TreatmentUltrafiltration.qml Changed
    /sources/gui/.../sections/TreatmentVitals.qml Changed
    /sources/gui/.../treatment/TreatmentStack.qml Changed 6
    Open in IDE #permalink
    /sources/gui/qml/pages/ManagerHome.qml Changed 3
    /sources/gui/qml/pages/SettingsHome.qml Changed 9
    /sources/gui/qml/main.qml Changed
    Open in IDE #permalink
    /sources/gui/guicontroller.cpp Changed
    /sources/gui/guicontroller.h Changed
    /sources/gui/guiglobals.cpp Changed
    Open in IDE #permalink
    /sources/gui/guiglobals.h Changed
    Open in IDE #permalink
    /sources/gui/guiview.cpp Changed
    /sources/model/.../data/MDGDrainPumpData.cpp Added
    /sources/model/dg/data/MDGDrainPumpData.h Added
    /sources/model/dg/data/MDGHeatersData.cpp Added
    /sources/model/dg/data/MDGHeatersData.h Added
    /sources/.../data/MDGLoadCellReadingsData.cpp Added
    /sources/.../data/MDGLoadCellReadingsData.h Added
    /sources/.../data/MDGOperationModeData.cpp Added
    /sources/model/.../data/MDGOperationModeData.h Added
    /sources/model/.../data/MDGPressuresData.cpp Added
    /sources/model/dg/data/MDGPressuresData.h Added
    /sources/model/dg/data/MDGROPumpData.cpp Added
    /sources/model/dg/data/MDGROPumpData.h Added
    /sources/model/.../data/MDGReservoirData.cpp Added
    /sources/model/dg/data/MDGReservoirData.h Added
    /sources/.../data/MDGTemperaturesData.cpp Added
    /sources/model/.../data/MDGTemperaturesData.h Added
    /sources/.../data/MDGValvesStatesData.cpp Added
    /sources/model/.../data/MDGValvesStatesData.h Added
    /sources/.../adjustment/MTreatmentAdjustBloodDialysateResponse.cpp Added
    /sources/.../adjustment/MTreatmentAdjustBloodDialysateResponse.h Added
    /sources/.../adjustment/MTreatmentAdjustDurationResponse.cpp Added
    /sources/.../adjustment/MTreatmentAdjustDurationResponse.h Added
    /sources/.../adjustment/MTreatmentAdjustRequests.h Added
    Open in IDE #permalink
    /sources/.../adjustment/MTreatmentAdjustUltrafiltrationConfirmResponse.cpp Added
    Open in IDE #permalink
    /sources/.../adjustment/MTreatmentAdjustUltrafiltrationConfirmResponse.h Added
    /sources/.../adjustment/MTreatmentAdjustUltrafiltrationEditResponse.cpp Added
    Open in IDE #permalink
    /sources/.../adjustment/MTreatmentAdjustUltrafiltrationEditResponse.h Added
    /sources/.../adjustment/MTreatmentAdjustUltrafiltrationStateResponse.cpp Added
    /sources/.../adjustment/MTreatmentAdjustUltrafiltrationStateResponse.h Added
    /sources/model/hd/alarm/MAlarmCleared.cpp Added
    Open in IDE #permalink
    /sources/model/hd/alarm/MAlarmCleared.h Added
    Open in IDE #permalink
    /sources/model/.../alarm/MAlarmStatusData.cpp Added
    /sources/model/hd/alarm/MAlarmStatusData.h Added
    /sources/model/.../alarm/MAlarmTriggered.cpp Added
    Open in IDE #permalink
    /sources/model/hd/alarm/MAlarmTriggered.h Added
    Open in IDE #permalink
    /sources/.../data/MHDOperationModeData.cpp Added
    /sources/model/.../data/MHDOperationModeData.h Added
    /sources/.../data/MTreatmentFlowsData.cpp Added
    /sources/model/.../data/MTreatmentFlowsData.h Added
    /sources/.../data/MTreatmentOutletFlowData.cpp Added
    /sources/.../data/MTreatmentOutletFlowData.h Added
    /sources/.../data/MTreatmentPressureOcclusionData.cpp Added
    /sources/.../data/MTreatmentPressureOcclusionData.h Added
    /sources/.../data/MTreatmentRangesData.cpp Added
    /sources/model/.../data/MTreatmentRangesData.h Added
    /sources/.../data/MTreatmentStatesData.cpp Added
    /sources/model/.../data/MTreatmentStatesData.h Added
    /sources/model/.../data/MTreatmentTimeData.cpp Added
    /sources/model/.../data/MTreatmentTimeData.h Added
    /sources/model/MAbstract.cpp Added
    Open in IDE #permalink
    /sources/model/MAbstract.h Added
    /sources/model/MDGDebugText.cpp Added
    /sources/model/MDGDebugText.h Added
    /sources/model/MHDDebugText.cpp Added
    /sources/model/MHDDebugText.h Added
    /sources/model/MModel.h Added
    Open in IDE #permalink
    /sources/model/MPowerOff.cpp Added
    /sources/model/MPowerOff.h Added
    /sources/model/malarmcleared.cpp Deleted
    Open in IDE #permalink
    /sources/model/malarmcleared.h Deleted
    Open in IDE #permalink
    /sources/model/malarmstatus.cpp Deleted
    Open in IDE #permalink
    /sources/model/malarmstatus.h Deleted
    Open in IDE #permalink
    /sources/model/malarmtriggered.cpp Deleted
    Open in IDE #permalink
    /sources/model/malarmtriggered.h Deleted
    Open in IDE #permalink
    /sources/model/mloadcellreadings.cpp Deleted
    Open in IDE #permalink
    /sources/model/mloadcellreadings.h Deleted
    Open in IDE #permalink
    /sources/model/mmodel.h Deleted
    Open in IDE #permalink
    /sources/model/mpoweroff.cpp Deleted
    Open in IDE #permalink
    /sources/model/mpoweroff.h Deleted
    Open in IDE #permalink
    /sources/model/mtemperaturesensors.cpp Deleted
    Open in IDE #permalink
    /sources/model/mtemperaturesensors.h Deleted
    Open in IDE #permalink
    /sources/model/mtreatmentadjustblooddialysateresponse.cpp Deleted
    Open in IDE #permalink
    /sources/model/mtreatmentadjustblooddialysateresponse.h Deleted
    Open in IDE #permalink
    /sources/model/mtreatmentadjustdurationresponse.cpp Deleted
    Open in IDE #permalink
    /sources/model/mtreatmentadjustdurationresponse.h Deleted
    Open in IDE #permalink
    /sources/model/mtreatmentadjustrequests.h Deleted
    Open in IDE #permalink
    /sources/model/mtreatmentadjustultrafiltrationconfirmresponse.cpp Deleted
    Open in IDE #permalink
    /sources/model/mtreatmentadjustultrafiltrationconfirmresponse.h Deleted
    Open in IDE #permalink
    /sources/model/mtreatmentadjustultrafiltrationeditresponse.cpp Deleted
    Open in IDE #permalink
    /sources/model/mtreatmentadjustultrafiltrationeditresponse.h Deleted
    Open in IDE #permalink
    /sources/model/mtreatmentadjustultrafiltrationstateresponse.cpp Deleted
    Open in IDE #permalink
    /sources/model/mtreatmentadjustultrafiltrationstateresponse.h Deleted
    Open in IDE #permalink
    /sources/model/mtreatmentflows.cpp Deleted
    Open in IDE #permalink
    /sources/model/mtreatmentflows.h Deleted
    Open in IDE #permalink
    /sources/model/mtreatmentoutletflow.cpp Deleted
    Open in IDE #permalink
    /sources/model/mtreatmentoutletflow.h Deleted
    Open in IDE #permalink
    /sources/model/mtreatmentpressureocclusion.cpp Deleted
    Open in IDE #permalink
    /sources/model/mtreatmentpressureocclusion.h Deleted
    Open in IDE #permalink
    /sources/model/mtreatmentranges.cpp Deleted
    Open in IDE #permalink
    /sources/model/mtreatmentranges.h Deleted
    Open in IDE #permalink
    /sources/model/mtreatmentstate.cpp Deleted
    Open in IDE #permalink
    /sources/model/mtreatmentstate.h Deleted
    Open in IDE #permalink
    /sources/model/mtreatmenttime.cpp Deleted
    Open in IDE #permalink
    /sources/model/mtreatmenttime.h Deleted
    Open in IDE #permalink
    /sources/storage/DriveWatcher.cpp Added
    /sources/storage/DriveWatcher.h Added
    /sources/storage/filehandler.cpp Changed
    /sources/storage/filehandler.h Changed
    /sources/storage/logger.cpp Changed
    /sources/storage/logger.h Changed
    /sources/storage/storageglobals.cpp Changed
    /sources/storage/storageglobals.h Changed
    /sources/storage/usbwatcher.cpp Deleted
    Open in IDE #permalink
    /sources/storage/usbwatcher.h Deleted
    Open in IDE #permalink
    /sources/utility/format.cpp Changed
    /sources/utility/format.h Changed
    /sources/utility/types.h Changed
    /sources/view/dg/data/VDGDrainPumpData.cpp Added
    Open in IDE #permalink
    /sources/view/dg/data/VDGDrainPumpData.h Added
    Open in IDE #permalink
    /sources/view/dg/data/VDGHeatersData.cpp Added
    Open in IDE #permalink
    /sources/view/dg/data/VDGHeatersData.h Added
    Open in IDE #permalink
    /sources/.../data/VDGLoadCellReadingsData.cpp Added
    Open in IDE #permalink
    /sources/.../data/VDGLoadCellReadingsData.h Added
    Open in IDE #permalink
    /sources/.../data/VDGOperationModeData.cpp Added
    Open in IDE #permalink
    /sources/view/.../data/VDGOperationModeData.h Added
    Open in IDE #permalink
    /sources/view/dg/data/VDGPressuresData.cpp Added
    Open in IDE #permalink
    /sources/view/dg/data/VDGPressuresData.h Added
    Open in IDE #permalink
    /sources/view/dg/data/VDGROPumpData.cpp Added
    Open in IDE #permalink
    /sources/view/dg/data/VDGROPumpData.h Added
    Open in IDE #permalink
    /sources/view/dg/data/VDGReservoirData.cpp Added
    Open in IDE #permalink
    /sources/view/dg/data/VDGReservoirData.h Added
    Open in IDE #permalink
    /sources/view/.../data/VDGTemperaturesData.cpp Added
    Open in IDE #permalink
    /sources/view/.../data/VDGTemperaturesData.h Added
    Open in IDE #permalink
    /sources/view/.../data/VDGValvesStatesData.cpp Added
    /sources/view/.../data/VDGValvesStatesData.h Added
    /sources/view/VHDOperationModeData.cpp Added
    Open in IDE #permalink
    /sources/view/VHDOperationModeData.h Added
    Open in IDE #permalink
    /sources/view/valarmstatus.cpp Changed
    /sources/view/valarmstatus.h Changed
    /sources/view/vloadcellreadings.cpp Deleted
    Open in IDE #permalink
    /sources/view/vloadcellreadings.h Deleted
    Open in IDE #permalink
    /sources/view/vpoweroff.h Changed
    /sources/view/vtemperaturesensors.cpp Deleted
    Open in IDE #permalink
    /sources/view/vtemperaturesensors.h Deleted
    Open in IDE #permalink
    /sources/view/vtreatmentadjustmentresponsebase.h Changed
    Open in IDE #permalink
    /sources/view/vtreatmentadjustmentultrafiltrationconfirm.cpp Changed 9
    /sources/view/vtreatmentadjustmentultrafiltrationconfirm.h Changed
    Open in IDE #permalink
    /sources/view/vtreatmentadjustmentultrafiltrationstate.cpp Changed
    /sources/view/vtreatmentadjustmentultrafiltrationstate.h Changed
    /sources/view/vtreatmentbloodflow.h Changed
    /sources/view/vtreatmentdialysateflow.h Changed
    /sources/view/vtreatmentpressureocclusion.h Changed
    /sources/view/vtreatmentranges.h Changed
    /sources/view/vtreatmenttime.h Changed
    /sources/view/vtreatmentultrafiltration.cpp Changed 6
    /sources/view/vtreatmentultrafiltration.h Changed 3
    /sources/view/vview.h Changed
    /sources/applicationcontroller.cpp Changed
    /sources/applicationcontroller.h Changed
    /sources/applicationpost.cpp Changed
    /sources/main.h Changed
    /sources/maintimer.cpp Changed
    /sources/maintimer.h Changed
    /sources/threads.cpp Changed
    /sources/threads.h Changed
    /unittests/tst_acknow.cpp Changed
    /unittests/tst_acknow.h Changed
    /unittests/tst_canbus.cpp Changed
    /unittests/tst_canbus.h Changed
    /unittests/tst_initializations.cpp Changed
    /unittests/tst_initializations.h Changed
    /unittests/tst_logging.cpp Changed
    /unittests/tst_logging.h Changed
    /unittests/tst_messaging.cpp Changed 3
    /unittests/tst_messaging.h Changed
    Open in IDE #permalink
    /unittests/tst_models.cpp Changed
    /unittests/tst_models.h Changed
    Open in IDE #permalink
    /unittests/tst_threads.cpp Changed
    /unittests/tst_threads.h Changed
    /unittests/tst_utilities.cpp Changed 3
    /unittests/tst_utilities.h Changed 3
    /unittests/tst_views.h Changed
    /denali.pro Changed
    /denali.pro.user Changed
    /main.cpp Changed
    /.settings/org.eclipse.core.resources.prefs Added
    Open in IDE #permalink
    /_tst_DGHeatersData_/test.py Deleted
    Open in IDE #permalink
    /shared/scripts/names.py Changed
    /tools/setup_env.sh Added
    /tst_Alarm/test.py Deleted
    Open in IDE #permalink
    /tst_AlarmCleared/test.py Added
    Open in IDE #permalink
    /tst_AlarmStatusData/test.py Added
    /tst_AlarmTriggered/test.py Added
    Open in IDE #permalink
    /tst_Alarm_Colors/test.py Added
    Open in IDE #permalink
    /tst_CANBusFaultCount/test.py Changed
    /tst_DGDrainPumpData/test.py Added
    /tst_DGHeatersData/test.py Added
    /tst_DGLoadCellReadingsData/test.py Added
    /tst_DGOperationMode/test.py Added
    /tst_DGPressureData/test.py Added
    /tst_DGROPumpData/test.py Added
    /tst_DGReservoirData/test.py Added
    /tst_DGTemperaturesData/test.py Added
    /tst_DGValvesStatesData/test.py Added
    /tst_DebugText/test.py Added
    /tst_HDOperationModeData/test.py Added
    /tst_HDOutletFlowData/test.py Added
    /tst_HDPressureOcclusionData/test.py Added
    /tst_HomeScreen/test.py Changed
    /tst_Internals/test.py Changed
    /tst_ServiceShutdown/test.py Changed
    /tst_TreatmentScreen/test.py Changed
    /tst_TreatmentStatesData/test.py Added
    /tst_Treatment_Adjustment_BloodDialysate/test.py Changed
    /tst_Treatment_Adjustment_Duration/test.py Changed
    /tst_Treatment_Adjustment_Ultrafiltration/test.py Changed
    /tst_Treatment_BloodDialysateFlowRate/test.py Added
    /tst_Treatment_BloodFlowRate/test.py Deleted
    Open in IDE #permalink
    /tst_Treatment_DGDrainPump/test.py Deleted
    Open in IDE #permalink
    /tst_Treatment_DGHeaters/test.py Deleted
    Open in IDE #permalink
    /tst_Treatment_DGLoadCellReadings/test.py Deleted
    Open in IDE #permalink
    /tst_Treatment_DGPressure/test.py Deleted
    Open in IDE #permalink
    /tst_Treatment_DGROPump/test.py Deleted
    Open in IDE #permalink
    /tst_Treatment_DGTemperatureSensors/test.py Deleted
    Open in IDE #permalink
    /tst_Treatment_DialysateFlowRate/test.py Deleted
    Open in IDE #permalink
    /tst_Treatment_LoadCellReadings/test.py Deleted
    Open in IDE #permalink
    /tst_Treatment_ParametersRange/test.py Changed
    /tst_Treatment_PressureOcclusion/test.py Changed
    /tst_Treatment_Section_BloodDialysate/test.py Changed
    /tst_Treatment_TemperatureSensors/test.py Deleted
    Open in IDE #permalink
    /tst_Treatment_Time/test.py Changed
    /tst_Treatment_Ultrafiltration/test.py Changed
    /venv.bak/lib/.../site-packages/dialin Deleted
    Open in IDE #permalink
    /.gitignore Changed
    /.project Added
    Open in IDE #permalink
    /.pydevproject Added
    Open in IDE #permalink
    /suite.conf Changed

    Review updated: Reload | Ignore | Collapse

    You cannot reload the review while writing a comment.

    Log time