This is a list of all comments for UI-DEN-5282-1. Review Summary: No summary ---------------------------------------- File: sources/canbus/MessageInterpreter.cpp Revision Comment by pmontazemi on 28 October 2020, 15:14 https://devapps.diality.us/cru/UI-DEN-5282-1#c5748 Why removed? Reply by Behrouz NematiPour on 28 October 2020, 18:29 > Objectives: #01, #04 > Because of the new standard message (#01) I could be able to > use my notify template function (#04) and then these codes > are not used anymore. Reply by pmontazemi on 29 October 2020, 14:02 > RESOLVED. ---------------------------------------- File: en_US.udic Revision Comment by pmontazemi on 28 October 2020, 15:19 https://devapps.diality.us/cru/UI-DEN-5282-1#c5752 What is this new file for? Reply by Behrouz NematiPour on 28 October 2020, 16:07 > Objective: #14 > This is the dictionary file for the QtCreator spellcheck > plugin. Reply by pmontazemi on 29 October 2020, 14:00 > RESOLVED. ---------------------------------------- File: sources/view/hd/adjustment/VTreatmentAdjustmentUltrafiltrationState.cpp Revision Comment by pmontazemi on 28 October 2020, 15:17 https://devapps.diality.us/cru/UI-DEN-5282-1#c5749 Why removed? Reply by Behrouz NematiPour on 28 October 2020, 18:29 > Objectives: #01 > Because of the new standard message (#01) I could be able to > use the FW's returned reason filed for the new message which > the old one didn't have. > So removed UI handling of the message rejection reason by the > FW one as designed by standard Response messages. Reply by pmontazemi on 29 October 2020, 14:01 > RESOLVED. ---------------------------------------- File: en_US.aff Revision Comment by pmontazemi on 28 October 2020, 15:19 https://devapps.diality.us/cru/UI-DEN-5282-1#c5750 What is this new file for? Reply by Behrouz NematiPour on 28 October 2020, 16:45 > Objective: #14 > This is the dictionary file for the QtCreator spellcheck > plugin. Reply by pmontazemi on 29 October 2020, 14:01 > RESOLVED. ---------------------------------------- File: en_US.dic Revision Comment by pmontazemi on 28 October 2020, 15:19 https://devapps.diality.us/cru/UI-DEN-5282-1#c5751 What is this new file for? Reply by Behrouz NematiPour on 28 October 2020, 18:25 > Objective: #14 > This is the dictionary file for the QtCreator spellcheck > plugin. Reply by pmontazemi on 29 October 2020, 14:00 > RESOLVED. ---------------------------------------- File: tst_Internals/test.py Revision Comment by plucia on 28 October 2020, 11:30 https://devapps.diality.us/cru/UI-DEN-5282-1#c5746 utils is imported twice Reply by Behrouz NematiPour on 28 October 2020, 14:23 > Thanks for pointing that out. > It was a test code that is removed. Reply by plucia on 30 October 2020, 09:23 > RESOLVED --- ID: UI-DEN-5282-1 https://devapps.diality.us/cru/UI-DEN-5282-1 Title: UI-DEN-5282_Ultrafiltration Stop State Statement of Objectives: Application : 01 - Used new message 65 instead of Generic for the UF state change request which is in the standard response message format by having (accepted,rejection_reason,...) 02 - Used new field, Saline Bolus State, in the saline state change request. 03 - Code improvement. 04 - Used notify function template. 05 - Modified ModalDialog and TreatmentAdjustmentBase to have separate NotificationBar for the Response errors and current state/general info. 06 - Utilize all the Ultrafiltration states to have a more user-friendly UI by enabling/disabling UI components and showing more information on sections and dialogs. 07 - After updating UI with the FW enum for the Saline bolus those enums used as states to have a more user-friendly UI. 08 - For the Treatment duration section used isRunning instead of isPaused since we have isRunning state and all the other states are not running states. 09 - Used UF_Commands FW enum (GuiUFCommands in UI)for UF state change request to be consistent with FW. 10 - Modified Pressure/Occlusion message to have 3 last params out of 5 as U32 which was F32 as requested by FW team. 11 - Centralized all the responses to 1)the Saline state change 2)UF state change and the broadcast 3)Treatment States messages in the Treatment States broadcast by let that view also listen to the other two responses beside those two messages themselves. So whichever received first will be served first and if the reported state is the same PROPERTY by design will not notify UI for the duplicate update. 12 - Updated Profile build to be used as the instrumented UI build built in the workspace_UI to be easily used for local code coverage effort. 13 - Added remove-extra-lines.sh script. 14 - Added QtCreator's Spell Checker pluggin's dictionary files in the root repo folder for all to use and also the user dictionary which will contain project specific words. testSuites/Simulator: 15 - In Simulator the UI file name changed to Simulator.ui 16 - Added UF 1)Pause 2)Resume 3)Edit/Next 4)Delivered volume 17 - Added Treatment State broadcast as a 1 sec interval broadcast. 18 - update tests with the new UF states and UF,Saline messages. State: Closed Summary: Author: Behrouz NematiPour Reviewers: (0 active, 2 completed*) plucia (*) pmontazemi (*)