This is a list of all comments for UI-DEN-608-1.

Review Summary: No summary


----------------------------------------
File: scripts/run.sh
Revision Comment by pmontazemi on 28 October 2019, 15:44 
https://devapps.diality.us/cru/UI-DEN-608-1#c162

  Have we coordinated with FW Team to make sure this is the fixed
  CAN Bus bit rate that is planned to be used?

  Reply by Behrouz NematiPour on 28 October 2019, 15:48
  > For now it's 250000 and coordinated with FW.
  > When settings and configuration module implemented this will
  > be set able.

    Reply by pmontazemi on 28 October 2019, 16:23
    > RESOLVED.

----------------------------------------
File: sources/gui/qml/components/MainMenu.qml
Revision Comment by pmontazemi on 28 October 2019, 15:45 
https://devapps.diality.us/cru/UI-DEN-608-1#c163

  How was this made a more general component without any code
  being added?

  Reply by Behrouz NematiPour on 28 October 2019, 15:50
  > It has been updated in the other code review here I just
  > removed the residue.

    Reply by pmontazemi on 28 October 2019, 16:22
    > RESOLVED.

Revision Comment by Behrouz NematiPour on 28 October 2019, 15:51 
https://devapps.diality.us/cru/UI-DEN-608-1#c166

  Regarding to improve it and make it more general added a
  repeater so we can have from 1 to n (depending on the text size
  of menu items.)

  Reply by pmontazemi on 03 December 2019, 15:55
  > RESOLVED.


---

ID: UI-DEN-608-1 https://devapps.diality.us/cru/UI-DEN-608-1

Title: DEN-UI-608_CAN Integration on UI 
Statement of Objectives:


State: Closed

Summary: 

Author: Behrouz NematiPour
Moderator: Behrouz NematiPour
Reviewers: (0 active, 3 completed*)
     Dara Navaei   (*)
     pmontazemi   (*)
     lbaloa   (*)