This is a list of all comments for UI-DEN-608-4.

Review Summary: No summary


----------------------------------------
File: sources/applicationcontroller.cpp
Revision Comment by lbaloa on 04 December 2019, 08:35 
https://devapps.diality.us/cru/UI-DEN-608-4#c448

  Verb

  Reply by Dara Navaei on 19 October 2023, 10:55
  > RESOLVED

----------------------------------------
File: sources/canbus/caninterface.cpp
Revision Comment by lbaloa on 04 December 2019, 08:26 
https://devapps.diality.us/cru/UI-DEN-608-4#c437

  I would suggest to use a more descriptive Error string, like,
  Error: Cannot instantiate QCanBus

  Reply by Dara Navaei on 19 October 2023, 10:55
  > RESOLVED

Revision Comment by lbaloa on 04 December 2019, 08:28 
https://devapps.diality.us/cru/UI-DEN-608-4#c438

  Method should be verbs, e.g., setupConnections()

  Reply by Dara Navaei on 19 October 2023, 10:55
  > RESOLVED

Revision Comment by lbaloa on 04 December 2019, 08:28 
https://devapps.diality.us/cru/UI-DEN-608-4#c439

  Same comment as above, make error more descriptive: Error:
  CanDevice cannot connect.

  Reply by Dara Navaei on 19 October 2023, 10:55
  > RESOLVED

Revision Comment by lbaloa on 04 December 2019, 08:29 
https://devapps.diality.us/cru/UI-DEN-608-4#c440

  Same comment as above. We need a clue what is happening.  "Can
  Device is connected"

  Reply by Dara Navaei on 19 October 2023, 10:55
  > RESOLVED

Revision Comment by lbaloa on 04 December 2019, 08:30 
https://devapps.diality.us/cru/UI-DEN-608-4#c441

  Please make status more verbose, e.g., "Can Device is now
  disconnected"

  Reply by Dara Navaei on 19 October 2023, 10:55
  > RESOLVED

Revision Comment by lbaloa on 04 December 2019, 08:31 
https://devapps.diality.us/cru/UI-DEN-608-4#c442

  I believe these cases need indentation

  Reply by Dara Navaei on 19 October 2023, 10:55
  > RESOLVED

----------------------------------------
File: sources/canbus/messagehandler.cpp
Revision Comment by lbaloa on 04 December 2019, 08:32 
https://devapps.diality.us/cru/UI-DEN-608-4#c443

  Method needs to have verb.

  Reply by Dara Navaei on 19 October 2023, 10:55
  > RESOLVED

Revision Comment by lbaloa on 04 December 2019, 08:32 
https://devapps.diality.us/cru/UI-DEN-608-4#c444

  Case need indentation

  Reply by Dara Navaei on 19 October 2023, 10:56
  > RESOLVED

Revision Comment by lbaloa on 04 December 2019, 08:33 
https://devapps.diality.us/cru/UI-DEN-608-4#c446

  Case need indentation

  Reply by Dara Navaei on 19 October 2023, 10:56
  > RESOLVED

----------------------------------------
File: sources/gui/guicontroller.cpp
Revision Comment by lbaloa on 04 December 2019, 08:34 
https://devapps.diality.us/cru/UI-DEN-608-4#c447

  Method needs verb

  Reply by Dara Navaei on 19 October 2023, 10:56
  > RESOLVED


---

ID: UI-DEN-608-4 https://devapps.diality.us/cru/UI-DEN-608-4

Title: DEN-704 :
Statement of Objectives:
DEN-704 :

State: Closed

Summary: 

Author: Behrouz NematiPour
Moderator: Behrouz NematiPour
Reviewers: (1 active, 0 completed*)
     Dara Navaei