UI-DEN-6349-1
UI-DEN-6349_BP HR Manual Entry
Details
| Participant | Role | Time Spent | Comments | Latest Comment |
|---|---|---|---|---|
|
plucia
(deleted user)
|
Author | 6h 59m | 49 | I have updated .gitignore so only bledevices.conf is igno... |
| Reviewer - Complete | 5h 49m | 86 | RESOLVED | |
|
pmontazemi
(deleted user)
|
Reviewer - Complete | 25m | 4 | RESOLVED. |
| Total | 13h 15m | 139 |
-
Linked issues
Branches in review
General Comments
plucia (deleted user)
Reviewers please note: According to the qt virtual keyboard technical stylin...Reviewers please note:
According to the qt virtual keyboard technical styling guide, here
it is recommended to use
Src/qtvirtualkeyboard/src/virtualkeyboard/content/styles/default
as a base for the custom style. The Qt virtual keyboard styling files (called default and retro) I could find are located here on our VM:
/opt/Qt5.12.5/5.12.5/Src/qtvirtualkeyboard/src/virtualkeyboard/content/styles/default
You'll notice that the Qt company has only provided the button images in the svg format. It appears they did this to allow for greater customization of the keyboard styling in the qml code.
I'm aware it has been decided to use pngs in the denali application. If requested, I can change the default Qt-provided keyboard style.qml file to use pngs instead of svgs.
It would be helpful before I do so to get feedback on the look and feel of the numeric keyboard so we have an agreed-upon style, size, and layout of the numeric keyboard, as converting the svgs to pngs will hard-code the styling.
Behrouz NematiPour
Why does it even need styling? Couldn't we use the keyboard default styling? ...Why does it even need styling?
Couldn't we use the keyboard default styling?
Please provide two of the default and styled screenshot versions of the keyboard for comparison.
-
Behrouz NematiPour
marked as
Resolved
01 Feb 21
plucia (deleted user)
You can't adjust the size of the keyboard, change what buttons are available,...You can't adjust the size of the keyboard, change what buttons are available, or adjust the opaque black background that's blocking half the screen without adjusting the styling.
In here you will find a couple of screenshots for comparison:
Default numeric styling:
X:\Users\PeterL\ForBehrouz\Vitals_Entry_Default_Numeric_Keyboard.png
Custom numeric styling:
X:\Users\PeterL\ForBehrouz\Vitals_Numeric_Keyboard.png
Full Qwerty Keyboard with default styling:
X:\Users\PeterL\ForBehrouz\Full_Qwerty_Keyboard.png
Behrouz NematiPour
Thanks for providing the screenshots to compare. I would vote for the default...Thanks for providing the screenshots to compare.
I would vote for the default style which covers half the screen since it is more standard and would be the same all over the application instead of having different keyboard combinations and locations in different situations and prefer to relocate screen components and labeling to fit in the screen.
It can be like :
Vitals Entry
------------------
systolic [ ___ ] diastolic [ ___ ] BPM [ ___ ]
(or labels at top)
and hide the keyboard on last entry BPM, 'enter' touch.
Also, please on the user 'enter' touch go to the next entry.
-
Behrouz NematiPour
marked as
Resolved
01 Feb 21
plucia (deleted user)
Okay, sure no problem. Do you want the full qwerty keyboard then or numeric-o...Okay, sure no problem. Do you want the full qwerty keyboard then or numeric-only for this screen?
Behrouz NematiPour
Thanks, only a Numeric keyboard in this case. Please also take a look at the ...Thanks, only a Numeric keyboard in this case.
Please also take a look at the KDAB training about the QtQuick keyboard handling, in https://www.youtube.com/watch?v=ilCekEOpNYM @ 5:40 using the Keys API to be able to navigate on 'enter' pressed.
that might be helpful.
I think it should be "enterPressed", "returnPressed", or both.
Please also take a look at the UX desing in the link : https://app.zeplin.io/project/5db0c175acfeac55e3cb879e/screen/5dbc8461bab7462c152cb34e
-
Behrouz NematiPour
marked as
Resolved
01 Feb 21
On 1.8.2021:
Code Coverage: 100%
SquishQt Tests: 100% passing