This is a list of all comments for UI-DEN-9626-1.

Review Summary: No summary


----------------------------------------
File: sources/bluetooth/BluetoothInterface.cpp
Revision Comment by pmontazemi on 20 September 2021, 15:06 
https://devapps.diality.us/cru/UI-DEN-9626-1#c10835

  QApplication is misspelled

  Reply by Behrouz NematiPour on 20 September 2021, 21:05
  > Fixed.

    Reply by pmontazemi on 20 September 2021, 21:45
    > RESOLVED.

Revision Comment by pmontazemi on 20 September 2021, 22:22 
https://devapps.diality.us/cru/UI-DEN-9626-1#c10840

  it is (formal) instead of it's (informal)

  Reply by Behrouz NematiPour on 21 September 2021, 11:38
  > updated.

    Reply by pmontazemi on 24 September 2021, 16:10
    > RESOLVED.

Revision Comment by Sean Nash on 22 September 2021, 10:07 
https://devapps.diality.us/cru/UI-DEN-9626-1#c10859

  Remove blank line.

  Reply by Behrouz NematiPour on 22 September 2021, 14:50
  > Removed.

    Reply by Sean Nash on 23 September 2021, 22:38
    > RESOLVED.

Revision Comment by pmontazemi on 20 September 2021, 22:29 
https://devapps.diality.us/cru/UI-DEN-9626-1#c10841

  Remove extra spaces after vData.

  Reply by Behrouz NematiPour on 21 September 2021, 11:38
  > updated.

    Reply by pmontazemi on 24 September 2021, 16:10
    > RESOLVED.

Revision Comment by pmontazemi on 20 September 2021, 22:30 
https://devapps.diality.us/cru/UI-DEN-9626-1#c10842

  We either start with Capital Letter everywhere or we don't.

  Reply by Behrouz NematiPour on 21 September 2021, 11:38
  > updated.

    Reply by pmontazemi on 24 September 2021, 16:10
    > RESOLVED.

Revision Comment by pmontazemi on 20 September 2021, 22:31 
https://devapps.diality.us/cru/UI-DEN-9626-1#c10843

  We either start with Capital letter everywhere or we don't.

  Reply by Behrouz NematiPour on 21 September 2021, 11:38
  > updated.

    Reply by pmontazemi on 24 September 2021, 16:10
    > RESOLVED.

----------------------------------------
File: sources/ApplicationPost.cpp
Revision Comment by Sean Nash on 22 September 2021, 09:49 
https://devapps.diality.us/cru/UI-DEN-9626-1#c10857

  "... and then, and them," - looks like something is wrong with
  this comment.

  Reply by Behrouz NematiPour on 22 September 2021, 14:51
  > Updated the comments to clarify.
  > In ' ..., and them,...'  it meant logical AND &&.
  > And added a lot more comments.

    Reply by Sean Nash on 23 September 2021, 22:32
    > RESOLVED.

Revision Comment by Sean Nash on 22 September 2021, 09:51 
https://devapps.diality.us/cru/UI-DEN-9626-1#c10858

  In the header file, the Ethernet and sound tests are said to be
  not required (i.e. should not prevent system use).  
  So this comment appears to be inconsistent with the header
  file.

  Reply by Behrouz NematiPour on 22 September 2021, 14:53
  > Thanks for the comment.
  > I removed those two and updated the comments as well.

    Reply by Sean Nash on 23 September 2021, 22:32
    > RESOLVED.

----------------------------------------
File: scripts/run.sh
Revision Comment by pmontazemi on 20 September 2021, 15:04 
https://devapps.diality.us/cru/UI-DEN-9626-1#c10834

  1) What is this sleep for?
  2) How did you come up with its value? (I assume this is in
  seconds?)
  3) Is this value consistent among all 4 prototypes and the
  development boards that we have?

  Reply by Behrouz NematiPour on 20 September 2021, 20:41
  > 1) This sleep helps the Bluetooth driver to load properly.
  > 2) After many, many tests figured the Bluetooth device needs
  > a power cycle after it is loaded and find out if giving it a
  > 5-second delay before setting the "hci" device to up, then it
  > works fine and doesn't need the power cycle anymore. I timed
  > the boot up and it's still under 30 seconds.
  > 3) Yes it shouldn't break the loading of the other
  > prototypes, since they may never even need it.

    Reply by pmontazemi on 20 September 2021, 21:46
    > RESOLVED.

----------------------------------------
File: sources/gui/qml/components/StackItem.qml
Revision Comment by Sean Nash on 21 September 2021, 17:48 
https://devapps.diality.us/cru/UI-DEN-9626-1#c10850

  Temporary?  Maybe add a // TODO or is // DEBUG something you'll
  know to search for later?

  Reply by Behrouz NematiPour on 21 September 2021, 17:53
  > In UI we have multiple types of TODOs.
  > DEBUG, FIXME, WARNING, NOTE, TODO

    Reply by Sean Nash on 21 September 2021, 18:26
    > RESOLVED.

----------------------------------------
File: sources/gui/qml/pages/endtreatment/rinseback/EndTreatmentAdditional.qml
Revision Comment by Sean Nash on 21 September 2021, 17:49 
https://devapps.diality.us/cru/UI-DEN-9626-1#c10851

  Does this mean commenting out these 2 lines fixed a bug?  If
  so, why not just delete them?

  Reply by Behrouz NematiPour on 21 September 2021, 17:52
  > This was not a bug,
  > It was a change request from Sarina to remove the Rinseback
  > Aditional 5 min counter.
  > I kept it in case we may need it later.

    Reply by Sean Nash on 21 September 2021, 18:26
    > RESOLVED.


---

ID: UI-DEN-9626-1 https://devapps.diality.us/cru/UI-DEN-9626-1

Title: UI-DEN-9626_DEV Bluetooth Cuff Integration
Statement of Objectives:


State: Closed

Summary: 

Author: Behrouz NematiPour
Moderator: Behrouz NematiPour
Reviewers: (0 active, 2 completed*)
     Sean Nash   (*)
     pmontazemi   (*)