This is a list of all comments for UI-LEAH-2077-2. Review Summary: No summary ---------------------------------------- File: AlarmDefs.h Revision Comment by Sean Nash on 18 March 2025, 19:07 https://devapps.diality.us/cru/UI-LEAH-2077-2#c21789 These 2 alarms are triggered by TD (6 is when TD fails the UI POST because UI reported a POST test failed and 9 is UI not communicating). They were ok the way they were. Please restore them. I only wanted you to change the ones you added at bottom of list. Reply by Behrouz NematiPour on 19 March 2025, 07:12 > revert them back to its original. Reply by Behrouz NematiPour on 19 March 2025, 08:53 > RESOLVED Revision Comment by Sean Nash on 18 March 2025, 13:39 https://devapps.diality.us/cru/UI-LEAH-2077-2#c21772 Lets pick an alignment approach and be consistent. Looks like you prefer aligning the "=" to far right. That's fine, but then make them all that way. Reply by Behrouz NematiPour on 18 March 2025, 13:51 > agree we should be consistent, > I put it this way since it helped to select vertically for > the other part of the code to copy/paste and see all under > each other to review the correct numbering. Reply by Sean Nash on 18 March 2025, 19:09 > So can you align the "=" for 0..95 with the ones you added > then? Reply by Behrouz NematiPour on 19 March 2025, 07:13 > Sure, > All are now aligned. > Also, I updated other enums, if you do not want to, let > me know. Reply by Behrouz NematiPour on 19 March 2025, 08:56 > Fixed Reply by Behrouz NematiPour on 19 March 2025, 08:56 > RESOLVED Revision Comment by Daniel Ho on 19 March 2025, 13:09 https://devapps.diality.us/cru/UI-LEAH-2077-2#c21808 What does this comment mean? Reply by Behrouz NematiPour on 19 March 2025, 13:42 > Updated the comment. Revision Comment by Sean Nash on 18 March 2025, 13:42 https://devapps.diality.us/cru/UI-LEAH-2077-2#c21774 Why are all of these UI POST failures named with ".._TD_UI_.."? Shouldn't they just be ".._UI_.."? What does TD have to do with it? Reply by Behrouz NematiPour on 18 March 2025, 13:52 > it was the way defined in Denali, > let me know what your preference is for Leahi if you want > different. Reply by Sean Nash on 18 March 2025, 14:04 > I prefer you change to just "UI" in enum names and comments > to right. Reply by Behrouz NematiPour on 18 March 2025, 14:10 > I think we should keep the ALARM_ID_TD_COMM_TIMEOUT as > is, right? Reply by Behrouz NematiPour on 18 March 2025, 14:30 > Fixed. Reply by Behrouz NematiPour on 19 March 2025, 08:56 > RESOLVED Revision Comment by Sean Nash on 18 March 2025, 13:43 https://devapps.diality.us/cru/UI-LEAH-2077-2#c21775 You are reserving 100..130 for UI triggered alarms? I guess that's ok, but not really necessary and causes alarm table to be larger than needed. Reply by Behrouz NematiPour on 18 March 2025, 13:54 > my preference is to keep UI alarms sequentially next to each > other if you don't mind. > Let me know if you would like me to remove them. Reply by Behrouz NematiPour on 19 March 2025, 08:57 > RESOLVED Revision Comment by Daniel Ho on 19 March 2025, 13:05 https://devapps.diality.us/cru/UI-LEAH-2077-2#c21807 Why define '=16' here as number of enums but not in other enum definition? In consistent coding Reply by Behrouz NematiPour on 19 March 2025, 13:43 > Thanks for catching that, > fixed. Revision Comment by Sean Nash on 18 March 2025, 13:46 https://devapps.diality.us/cru/UI-LEAH-2077-2#c21776 Why do these 2 structure definitions need to be inside this #ifdef? Reply by Behrouz NematiPour on 18 March 2025, 13:55 > Those are structures and our agreement was to keep them > hidden from SW since the FW has FW types for the struct > elements that are not defined here and fail the build. > Additionally SW won't even use them. Reply by Behrouz NematiPour on 19 March 2025, 08:54 > RESOLVED Revision Comment by Sean Nash on 18 March 2025, 19:10 https://devapps.diality.us/cru/UI-LEAH-2077-2#c21791 Why did you delete this alarm? Reply by Behrouz NematiPour on 19 March 2025, 07:12 > Thanks for catching that. > Revert it back and fixed. Reply by Behrouz NematiPour on 19 March 2025, 08:53 > RESOLVED. Revision Comment by Sean Nash on 18 March 2025, 13:48 https://devapps.diality.us/cru/UI-LEAH-2077-2#c21777 Move this comment line right after alarm 99. Reply by Behrouz NematiPour on 18 March 2025, 15:56 > Fixed. Reply by Behrouz NematiPour on 19 March 2025, 08:56 > RESOLVED Revision Comment by Behrouz NematiPour on 18 March 2025, 13:57 https://devapps.diality.us/cru/UI-LEAH-2077-2#c21782 [~snash], I kept the same structure from Denali here as well. if you are changing the alarms enums do you think we need to update this as well? Reply by Sean Nash on 18 March 2025, 14:02 > Structure is same for now. But please replace all references > to "HD" to "TD". Reply by Behrouz NematiPour on 18 March 2025, 15:52 > I believe I replaced all HD references to TD already, > Could you be more specific. > I only found one "_HD" and it is not in my range of defined > alarms. > > {code} > { 24 , ALARM_ID_HD_ALARM_AUDIO_SELF_TEST_FAILURE > , "TD | Service Required: Hemodialysis Device | A > problem was detected with the hemodialysis device.\n- > Locate the ID code found in the bottom left corner\nof the > alarm screen.\n- Call service to report the issue and > schedule a repair. > | TD POST: Primary Alarm Current | TD alarm audio > failed POST > | If alarm audio current is NOT in expected range for than > 1 second while alarm tone is being output > | "}, > {code} Reply by Sean Nash on 18 March 2025, 19:14 > There are references to "HD" in the text fields within > the table (not enums, but titles and instructions and > such). Reply by Behrouz NematiPour on 19 March 2025, 08:55 > Fixed. Reply by Behrouz NematiPour on 19 March 2025, 08:55 > RESOLVED --- ID: UI-LEAH-2077-2 https://devapps.diality.us/cru/UI-LEAH-2077-2 Title: UI-LEAH-2077_Feature/Leah 2077 Luis Application Clean UP Statement of Objectives: State: Closed Summary: Author: Behrouz NematiPour Moderator: Behrouz NematiPour Reviewers: (5 active, 2 completed*) Sean Nash (*) Daniel Ho (*) jpaguio Vinayakam Mani Michael Garthwaite Dara Navaei amanesh