•  

Comment Results

Review Name Created Custom Fields Content
HD-SPR3-1 18 Oct 2019

RESOLVED IN CODE WALKTHROUGH

HD-SPR3-1 17 Oct 2019

same comment apply in regards the word wrapper

HD-SPR3-1 18 Oct 2019

RESOLVED IN CODE WALKTHROUGH

HD-SPR3-1 17 Oct 2019

Shouldn't you have a variable that indicates which is the active buffer and have it managed it internally by the module.
That way, you wouldn't need to pass the active buffer. It would be switchDoubleBuffer()

HD-SPR3-1 18 Oct 2019

RESOLVED IN CODE WALKTHROUGH

HD-SPR3-1 17 Oct 2019

We might want to change Contollers directory to Controllers

HD-SPR3-1 22 Oct 2019

RESOLVED IN CODE WALKTHROUGH

TEST-REVIEW-1 23 Oct 2019

This comment to test the mark as unresolved function.

TEST-REVIEW-1 23 Oct 2019

This comment is to test the comment on a file functionality.

TEST-REVIEW-1 23 Oct 2019

This comment is to test to the email of the comments.

TEST-REVIEW-1 23 Oct 2019

Reply to the source comment.

HD-SPR4-1 24 Oct 2019

.data need to clarify. It makes the code confusing.

HD-SPR4-1 24 Oct 2019

Comes from the DATA_DECL macro above.

HD-SPR4-1 24 Oct 2019

It's a macro to declare a data that you want to be able to override via script command.

UI-DEN-608-1 28 Oct 2019

Regarding to improve it and make it more general added a repeater so we can have from 1 to n (depending on the text size of menu items.)

HD-DEN-752-1 08 Nov 2019

Possibly. I have not needed one yet and generally do not like delaying in real-time software.

HD-SPR4-1 24 Oct 2019

Need data that can be overridden to go through getter function.

HD-DEN-752-1 08 Nov 2019

Is there a plan to include delays (1_MS_DELAY, 10_MS_DELAY, etc.) using timers at any point in time? If so, these are usually included in the Timers.h/c files.

HD-DEN-759-1 14 Nov 2019

Can the "3" also be parameterized with an ALL CAPS name? I saw it somewhere else where it took the value "1".

UI-DEN-625-1 24 Oct 2019

Removed.

TEST-1 28 Oct 2019

I will change it!

HD-DEN-759-1 07 Nov 2019

This module is very preliminary. I don't have any feedback from flow sensor or pump yet. States may be added, but I don't currently see a need for any more. There will be a lot more detail (possibly sub-states) needed in the "control to target" state.

TEST-1 28 Oct 2019

This is test comment for step 57)

HD-DEN-759-1 14 Nov 2019

Why are there two sys_main.c? How is that even allowed by the OS and Bitbucket/Bamboo?

HD-DEN-759-1 14 Nov 2019

Value "10", which is ...?

HD-SPR4-1 24 Oct 2019

I thought this might be a little faster this way, but I guess this function will always be working on small memory ranges as it's used for messages - so I'll make this change as you recommended.

HD-SPR4-1 25 Oct 2019

RESOLVED IN CODE WALKTHROUGH

HD-SPR4-1 24 Oct 2019

where does currentLampPattern.data come from? This is very confusing. It would be ideal to create simple structures. currentLampPattern is a enum. Where does .data come from? Need to make it simple.

HD-SPR4-1 25 Oct 2019

as is RESOLVED IN CODE WALKTHROUGH

TEST-1 28 Oct 2019

inline comment.

HD-SPR3-1 25 Oct 2019

RESOLVED IN CODE WALKTHROUGH

HD-SPR3-1 25 Oct 2019

RESOLVED IN CODE WALKTHROUGH

HD-SPR3-1 25 Oct 2019

RESOLVED IN CODE WALKTHROUGH

HD-SPR4-1 29 Oct 2019

Done.

HD-MASTER-1 25 Oct 2019

RESOLVED IN CODE WALKTHROUGH

HD-MASTER-1 25 Oct 2019

RESOLVED IN CODE WALKTHROUGH

UI-DEN-625-1 24 Oct 2019

Why is this commented out?

HD-SPR4-1 29 Oct 2019

I like to always place spaces between arguments and mathematical signs.

HD-SPR4-1 28 Oct 2019

Were these CAN registers re-generated from HALCoGen or manually changed?

HD-DEN-759-1 14 Nov 2019

Value "17", which is ...?

HD-SPR4-1 30 Oct 2019

RESOLVED in CODE WALKTHROUGH.

UI-DEN-608-1 28 Oct 2019

It has been updated in the other code review here I just removed the residue.

HD-SPR5-1 31 Oct 2019

Yes, incomplete. Will complete and comment.

HD-DEN-759-1 03 Dec 2019

This is temporary test code.

HD-SPR5-1 01 Nov 2019

RESOLVED and CODE WALKTHROUGH.

HD-DEN-759-1 07 Nov 2019

A compound statement body does not need an if or while or for or anything - it can stand alone. That said, I temporarily commented out the check because the FPGA protocol changed and I haven't caught up with it yet so this test was failing.

HD-DEN-759-1 04 Dec 2019

RESOLVED in CODE WALKTHROUGH.

TEST-1 04 Nov 2019

RESOLVED IN CODE WALKTHROUGH

HD-DEN-759-1 04 Dec 2019

Done.

TEST-1 04 Nov 2019

RESOLVED