•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-DD-FIRMWARE-LDT-3222-1 03 Feb 2026

This function also not using u32ArrayOverride()

LEAHI-DD-FIRMWARE-LDT-2004-3 02 Feb 2026

This state machine running continuously. fill request is initiated for every 1 minutes of balancing chamber exec (since right now level sensor is not working )

//Increment counter for dry bicarb chamber fill
bicarbChamberPeriodicFillCounter += 1;
// Fill bicarb chamber once every 60secs.
if ( bicarbChamberPeriodicFillCounter >= BICARB_CHAMBER_PERIODIC_FILL_TIME )

Unknown macro: { setBicarbChamberFillRequested(); bicarbChamberPeriodicFillCounter = 0; }


The request is cleared here. for consistency I am moving to the end of the fill cycle

LEAHI-DIALIN-LDT-3350-1 02 Feb 2026

What is the use of this dictionary?

LEAHI-TESTSUITES-LDT-2741-1 02 Feb 2026

updated

LEAHI-DD-FIRMWARE-LDT-2004-4 03 Feb 2026

Do we need to say Value?

LEAHI-DD-FIRMWARE-LDT-2004-3 04 Feb 2026

Fixed it

LEAHI-DD-FIRMWARE-LDT-3343-1 03 Feb 2026

For these functions that set specific valves, we should specify which (e.g. recovery valves or balancing chamber valves, or ...).

LEAHI-TD-FIRMWARE-LDT-1415-1 04 Feb 2026

Looks like this reverted back.

LEAHI-TD-FIRMWARE-LDT-1415-1 04 Feb 2026

Removed

LEAHI-TD-FIRMWARE-LDT-1415-1 04 Feb 2026

Yes, updated

LEAHI-APPLICATION-LDT-3307-1 04 Feb 2026

updated

LEAHI-APPLICATION-LDT-3307-1 04 Feb 2026

the changes are alreadyy in the one in td folder and I do not see this file in project or the .pro.

LEAHI-APPLICATION-LDT-3307-1 04 Feb 2026

moved and updated all isntances

LEAHI-APPLICATION-LDT-3307-1 04 Feb 2026

added comment

LEAHI-TD-FIRMWARE-LDT-1415-1 04 Feb 2026

Remove blank line.

LEAHI-TD-FIRMWARE-LDT-1415-1 04 Feb 2026

It's still UI only. Shouldn't this be commented out before we merge?

LEAHI-TESTSUITES-LDT-2741-1 04 Feb 2026

should be utility.aut() if you only want "leahi" utility.aut(""-E")) if you want "leahi -E" only pass in arguemets and remove name parameter in our aut() method

LEAHI-TESTSUITES-LDT-2741-1 04 Feb 2026

update all "leahi" to utility.aut()

LEAHI-TESTSUITES-LDT-2741-1 04 Feb 2026

update to utility.aut("-q")

LEAHI-TESTSUITES-LDT-2741-1 04 Feb 2026

update to utility.aut()

LEAHI-TESTSUITES-LDT-2741-1 04 Feb 2026

update to utility.aut()

LEAHI-TESTSUITES-LDT-2741-1 04 Feb 2026

update to utility.aut("-E")

LEAHI-TESTSUITES-LDT-2741-1 04 Feb 2026

update to utility.aut()

LEAHI-TESTSUITES-LDT-2741-1 04 Feb 2026

remove argument and only pass in arguments.
name is always "leahi" so set it in here

LEAHI-TD-FIRMWARE-LDT-1415-1 04 Feb 2026

Commented out already but I dont know why it is showing the same

UI-DENBUG-331-1 04 Feb 2026

Make clarification comments of what each parameter means

UI-DENBUG-331-1 04 Feb 2026

Add third argument for logname like line 526.

UI-DENBUG-331-1 04 Feb 2026

Check the caller to include logfile name

UI-DENBUG-331-1 04 Feb 2026

Change to QString

LEAHI-DD-FIRMWARE-LDT-1473-1 04 Feb 2026

For spent chamber fill, we don't know how low the liquid level is ( in Chamber H) and hence decided not to turn on the trimmer heater for safety reasons. For bicarb fill, the dry bicart code should cover the actuators status. the current bicarb chamber fill code here should be updated with the newly implemented dry bi cart code changes.

UI-DENBUG-331-1 04 Feb 2026

change to quint 32

LEAHI-DD-FIRMWARE-LDT-1473-1 04 Feb 2026

Since trimmer heater is enabled, no need of temp compensation. only for testing purposes, temp compensation is needed. Hence by default, temp compensation is disabled.

LEAHI-DD-FIRMWARE-LDT-1473-1 04 Feb 2026

Done

LEAHI-DD-FIRMWARE-LDT-1473-1 04 Feb 2026

Done.

UI-DENBUG-331-1 04 Feb 2026

Add logname as the third parameter

UI-DENBUG-331-1 04 Feb 2026

Create enum for all rejection reasons.

Remove default