DG-DEN-3504

DG-DEN-3504

Activity on this page:

Line History

Line history chart not available

Line history chart not available

 

Stats

Commits this week: 0
Total Commits: 4,108
Last Commit: 19 Nov
Commits this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 
Monday 23 Nov 2020
1:19 pm

qnguyen  (deleted user)

1:18 pm

pmontazemi  (deleted user) , Dara Navaei and Sean Nash

10:34 am

pmontazemi  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Tuesday 17 Nov 2020
10:40 am

qnguyen  (deleted user)

Good catch, it is actually an unintended L. Removed.

Good catch, it is actually an unintended L. Removed.

10:37 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:36 am

qnguyen  (deleted user)

Pumps are now controlled individually. Reverse direction for motor has been added.

Pumps are now controlled individually. Reverse direction for motor has been added.

10:34 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:34 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:33 am

pmontazemi  (deleted user)

Not a big fan of numbering variables like Speed1, Speed2, etc.

Not a big fan of numbering variables like Speed1, Speed2, etc.

Monday 16 Nov 2020
8:22 am

Sean Nash

There may be a need to run these pumps in forward or reverse direction (heat disinfect mode). And this would not be tied to RO flow rate - we would want to set an independent flow. May also want to...

There may be a need to run these pumps in forward or reverse direction (heat disinfect mode). And this would not be tied to RO flow rate - we would want to set an independent flow. May also want to control the pumps independently in this mode.

Friday 13 Nov 2020
10:48 am

qnguyen  (deleted user)

This was responsible for turn off concentrate pumps when HD commands DG to exit out of fill mode, but reservoir module has handled this.

This was responsible for turn off concentrate pumps when HD commands DG to exit out of fill mode, but reservoir module has handled this.

10:47 am

qnguyen  (deleted user)

It was acting as a function to turn off concentrate pump if HD commands DG exits fill mode, but has been removed due to reservoir module will handle this.

It was acting as a function to turn off concentrate pump if HD commands DG exits fill mode, but has been removed due to reservoir module will handle this.

10:08 am

Sean Nash

We should think about this. I'm ok with adding an explicit transition out handler (similar to the existing transition to handler), but if we do this we should build this into all modes (DG and HD)....

We should think about this. I'm ok with adding an explicit transition out handler (similar to the existing transition to handler), but if we do this we should build this into all modes (DG and HD).
To date, I've not required any clean-up on way out of a mode - mode can be reset on next entry. That seems to have been working so far.
Valve positions and motor states should be set as appropriate on entry to next mode, so we shouldn't have to worry about these kind of things on way out of a mode.

9:38 am

Sean Nash

I don't see this function actually exiting the mode. Is it caller's responsibility to return to re-circ mode after calling this function?

I don't see this function actually exiting the mode. Is it caller's responsibility to return to re-circ mode after calling this function?

Thursday 12 Nov 2020
10:51 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:51 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:51 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:50 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:50 am

qnguyen  (deleted user)

Changed variable name and added units in comment.

Changed variable name and added units in comment.

10:50 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:50 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:50 am

qnguyen  (deleted user)

Measured speed is kept in an override array. Added checking for measured speed vs. commanded speed.

Measured speed is kept in an override array.
Added checking for measured speed vs. commanded speed.

10:49 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:49 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:47 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:46 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:46 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:45 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:45 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:43 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.