DG-DEN-7091

DG-DEN-7091

Activity on this page:

Line History

Line history chart not available

Line history chart not available

 

Stats

Commits this week: 0
Total Commits: 4,108
Last Commit: 19 Nov
Commits this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 
Tuesday 06 Apr 2021
12:56 pm

qnguyen  (deleted user)

12:19 pm

pmontazemi  (deleted user) and Sean Nash

Tuesday 23 Mar 2021
11:18 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:17 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:17 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Monday 22 Mar 2021
4:29 pm

qnguyen  (deleted user)

Checked with Nick. The DG does not expose motors to the user. The straw door switch should be open in Fill Mode to allow access to straw connection. The straw door switch should be closed in modes ...

Checked with Nick. The DG does not expose motors to the user.
The straw door switch should be open in Fill Mode to allow access to straw connection.
The straw door switch should be closed in modes such as (heat disinfection, chem disinfection) to prevent user from exposure to hot water or chemical.

Added TODO.

11:41 am

qnguyen  (deleted user)

Changed rate to 4 Hz.

Changed rate to 4 Hz.

11:40 am

qnguyen  (deleted user)

Added timeout.

Added timeout.

10:56 am

Sean Nash

Should we send DG modes more often? UI and HD stacks are keying off of these a lot and I worry 1 Hz will not be very responsive. I also worry there may be some modes/states that do not last 1 secon...

Should we send DG modes more often? UI and HD stacks are keying off of these a lot and I worry 1 Hz will not be very responsive. I also worry there may be some modes/states that do not last 1 second and HD may miss it.
If we speed this up, we should also speed up the HD modes broadcast as well.

10:51 am

Sean Nash

Do we need to know if concentrates door is closed before turning on pumps?

Do we need to know if concentrates door is closed before turning on pumps?

10:48 am

Sean Nash

Should we have a timeout on this?

Should we have a timeout on this?

Friday 19 Mar 2021
10:46 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:45 am

Sean Nash

Quang to address temperature in future branch. RESOLVED in CODE WALKTHROUGH.

Quang to address temperature in future branch. RESOLVED in CODE WALKTHROUGH.

10:44 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:43 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:43 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:17 am

qnguyen  (deleted user)

Updated.

Updated.

10:17 am

qnguyen  (deleted user)

Moved valves config to standby mode transition.

Moved valves config to standby mode transition.

9:33 am

Sean Nash

Let's update to v0.5.0.

Let's update to v0.5.0.

9:32 am

Sean Nash

This init is called from main at startup. This seems to work, but I'd prefer to select initial active reservoir and set reservoir valves accordingly after POST - maybe in transition to standby mode...

This init is called from main at startup. This seems to work, but I'd prefer to select initial active reservoir and set reservoir valves accordingly after POST - maybe in transition to standby mode. This way, if POST does something to the valves to test, we will set them afterward. Also gives valve driver and FPGA interface a chance to get started before we start giving actuator commands.

Saturday 13 Mar 2021
9:25 pm

qnguyen  (deleted user)

Fixed.

Fixed.

9:25 pm

qnguyen  (deleted user)

Fixed.

Fixed.

9:07 pm

Sean Nash

conver should be convert. Flow is in L/min.

conver should be convert. Flow is in L/min.

9:07 pm

qnguyen  (deleted user)

The return of this function includes a call to isWaterQualityGood(), which checks for inlet temp and conductivity, reject ratio, and temperature. For the dialysate temperature, it will be done once...

The return of this function includes a call to isWaterQualityGood(), which checks for inlet temp and conductivity, reject ratio, and temperature.
For the dialysate temperature, it will be done once I work on dialysate generation again and remove TODO.

8:43 pm

Sean Nash

Ok, yes, I see that now. But I still don't see any check for dialysate temperature (after heating).

Ok, yes, I see that now. But I still don't see any check for dialysate temperature (after heating).

7:45 pm

Sean Nash

Don't we need to check other things here as well? Inlet temp and conductivity, reject ratio, and dialysate temperature.

Don't we need to check other things here as well? Inlet temp and conductivity, reject ratio, and dialysate temperature.

7:33 pm

Sean Nash

I think there are now 7 incoming CAN msg buffers (8 if counting the 1 serial port buffer).

I think there are now 7 incoming CAN msg buffers (8 if counting the 1 serial port buffer).

Monday 01 Mar 2021
10:39 am

pmontazemi  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:35 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:25 am

qnguyen  (deleted user)

Removed.

Removed.