DIALIN-DEN-15199

RESOLVED.

RESOLVED.

RESOLVED.

RESOLVED.

RESOLVED.

RESOLVED.

This is to be identical to the enum in firmware but in a Dialin enum we cannot have two enums with one number assigned to them since the Dialin enum is an ordered dictionary so we cannot have multi...

This is to be identical to the enum in firmware but in a Dialin enum we cannot have two enums with one number assigned to them since the Dialin enum is an ordered dictionary so we cannot have multiple keys with one number. I removed the commented enum.

Done

Done

This is to very clearly indicate to the user that we are in an unknown state until Dialin receives the status of the test configs from firmware.

This is to very clearly indicate to the user that we are in an unknown state until Dialin receives the status of the test configs from firmware.

Why 0xFFFFFFFF?

Why 0xFFFFFFFF?

Let's try not to use words like enable/disable unless we're literally doing just that (e.g. disable x alarm). I think the core of this test config is "use wet cartridge".

Let's try not to use words like enable/disable unless we're literally doing just that (e.g. disable x alarm). I think the core of this test config is "use wet cartridge".

Why commented out and why setting to a DG test config?

Why commented out and why setting to a DG test config?

DIALIN-DEN-15199_FW DN Sprint 95 Part 2
DIALIN-DEN-15199_FW DN Sprint 95 Part 2
RESOLVED.

RESOLVED.

This is here is because when they request the configs I set the dictionary to reset mode until the new values have been received from the firmware and then the dictionary is updated with the firmwa...

This is here is because when they request the configs I set the dictionary to reset mode until the new values have been received from the firmware and then the dictionary is updated with the firmware values. Thanks I moved it to only execute it if the message was received successfully.

Shouldnt this reset be in cmd_reset_all_test_configs()? It should also be executed after a successful message.

Shouldnt this reset be in cmd_reset_all_test_configs()? It should also be executed after a successful message.

RESOLVED.

RESOLVED.

RESOLVED.

RESOLVED.

RESOLVED.

RESOLVED.

The file header will be added upon the staging build.

The file header will be added upon the staging build.

The file heater will be added automatically in upon the staging build.

The file heater will be added automatically in upon the staging build.

This will be updated once we move to HD.

This will be updated once we move to HD.

Add file header

Add file header

Add file header

Add file header

???

???

DIALIN-DEN-15199_FW DN Sprint
DIALIN-DEN-15199_FW DN Sprint