DIALIN-DEN-3964

DIALIN-DEN-3964

Activity on this page:

Line History

Line history chart not available

Line history chart not available

 

Stats

Commits this week: 0
Total Commits: 2,952
Last Commit: 19 Nov
Commits this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 
Monday 20 Jul 2020
1:57 pm

plucia  (deleted user)

12:22 pm

Sean Nash and pmontazemi  (deleted user)

11:16 am

pmontazemi  (deleted user)

RESOLVED.

RESOLVED.

11:16 am

pmontazemi  (deleted user)

RESOLVED.

RESOLVED.

11:16 am

pmontazemi  (deleted user)

RESOLVED.

RESOLVED.

11:16 am

pmontazemi  (deleted user)

RESOLVED.

RESOLVED.

11:16 am

pmontazemi  (deleted user)

RESOLVED.

RESOLVED.

11:15 am

pmontazemi  (deleted user)

RESOLVED.

RESOLVED.

11:15 am

pmontazemi  (deleted user)

RESOLVED.

RESOLVED.

11:14 am

pmontazemi  (deleted user)

RESOLVED.

RESOLVED.

11:14 am

pmontazemi  (deleted user)

RESOLVED.

RESOLVED.

11:13 am

pmontazemi  (deleted user)

RESOLVED.

RESOLVED.

10:31 am

plucia  (deleted user)

Done

Done

10:31 am

plucia  (deleted user)

Done

Done

10:27 am

plucia  (deleted user)

Done

Done

10:26 am

plucia  (deleted user)

Done

Done

10:26 am

plucia  (deleted user)

Done

Done

10:26 am

plucia  (deleted user)

Done

Done

10:26 am

plucia  (deleted user)

Done

Done

10:26 am

plucia  (deleted user)

Done

Done

10:24 am

plucia  (deleted user)

PEP8 requires that there are two spaces between functions outside of a class. If I delete a space, it violates PEP8: E305

PEP8 requires that there are two spaces between functions outside of a class.
If I delete a space, it violates PEP8: E305

10:12 am

plucia  (deleted user)

Are you sure they were the same changes? In the other review, the change was to fix the bit masking: http://dvm-linux02:8060/cru/#DIALIN-DEN-3593-1CFR-14160 In this review, the change is to upgrade...

Are you sure they were the same changes? In the other review, the change was to fix the bit masking: http://dvm-linux02:8060/cru/#DIALIN-DEN-3593-1CFR-14160
In this review, the change is to upgrade the valve state handler to write valve states to the "state" key / value pair instead of the valve state variable itself.

Saturday 18 Jul 2020
10:26 pm

pmontazemi  (deleted user)

Copyright header missing.

Copyright header missing.

10:25 pm

pmontazemi  (deleted user)

Remove extra line.

Remove extra line.

10:25 pm

pmontazemi  (deleted user)

Remove extra lines.

Remove extra lines.

10:24 pm

pmontazemi  (deleted user)

Remove extra line.

Remove extra line.

10:23 pm

pmontazemi  (deleted user)

Copyright header is missing.

Copyright header is missing.

10:22 pm

pmontazemi  (deleted user)

Remove extra line.

Remove extra line.

10:20 pm

pmontazemi  (deleted user)

Weird that this code change was also part of the other code review. Please check.

Weird that this code change was also part of the other code review. Please check.

10:19 pm

pmontazemi  (deleted user)

Remove extra line.

Remove extra line.