DIALIN-DEN-4438

DIALIN-DEN-4438

Activity on this page:

Line History

Line history chart not available

Line history chart not available

 

Stats

Commits this week: 0
Total Commits: 2,952
Last Commit: 19 Nov
Commits this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 
Friday 28 Aug 2020
4:59 pm

Behrouz NematiPour

4:57 pm

plucia  (deleted user) and pmontazemi  (deleted user)

4:54 pm

Behrouz NematiPour

RESOLVED

RESOLVED

4:53 pm

Behrouz NematiPour

RESOLVED

RESOLVED

4:52 pm

Behrouz NematiPour

RESOLVED

RESOLVED

4:47 pm

pmontazemi  (deleted user)

OK.

OK.

4:46 pm

pmontazemi  (deleted user)

OK.

OK.

4:46 pm

pmontazemi  (deleted user)

OK.

OK.

Thursday 27 Aug 2020
12:36 pm

plucia  (deleted user)

RESOLVED

RESOLVED

Tuesday 25 Aug 2020
2:10 pm

Behrouz NematiPour

I tried to remove it but seems like Jira doesn't listen. sadly after we discussed in a conversation we had that Sarina arranged, when you told me to merge the staging branch into my working branch ...

I tried to remove it but seems like Jira doesn't listen.
sadly after we discussed in a conversation we had that Sarina arranged, when you told me to merge the staging branch into my working branch I didn't envision at that moment Jira doesn't let us remove it after it has been added.
Fortunately what we currently can do is to only review files in dialin/squish folder.

Thanks,

1:55 pm

Behrouz NematiPour

I have a screen capture that I can't attach here and put in X:\Users\PemanM. As I explained in the image file, I don't quit understand how Squish is managing the last line. Now I removed extra it s...

I have a screen capture that I can't attach here and put in X:\Users\PemanM.
As I explained in the image file, I don't quit understand how Squish is managing the last line.
Now I removed extra it shows no empty line at the EOF but I see there is one, prior to that it was showing one but was actually two.
Squish and Jira have different view.
external editor is showing one empty line though.

1:35 pm

Behrouz NematiPour

[~pmontazemi] Could you please review your comments and if it's not in the dialin/squish please keep it for later/related code reviews? Thanks,

[~pmontazemi] Could you please review your comments and if it's not in the dialin/squish please keep it for later/related code reviews?
Thanks,

11:31 am

plucia  (deleted user)

Can you remove unrelated changesets from this code review? I'm seeing many of my changes in this review

Can you remove unrelated changesets from this code review? I'm seeing many of my changes in this review

9:54 am

pmontazemi  (deleted user)

RESOLVED.

RESOLVED.

9:53 am

pmontazemi  (deleted user)

RESOLVED.

RESOLVED.

Sunday 23 Aug 2020
12:40 pm

Behrouz NematiPour

As a general comment, the only folder which has to be modified if required for any feature related to a UI Story has to be only dialin/squish/ folder and none of the other files are related to this...

As a general comment, the only folder which has to be modified if required for any feature related to a UI Story has to be only dialin/squish/ folder and none of the other files are related to this Story.
The only one comment related to this story has been addressed.
This comment checked as "Needs resolution" so we all see and agree on this topic after it has been resolved.

Friday 21 Aug 2020
12:45 pm

plucia  (deleted user)

Peman this isn't Behrouz's change. I must have added this as a placeholder. I have now removed it on my development branch, so it can be replaced in the future with the coverage test.

Peman this isn't Behrouz's change. I must have added this as a placeholder. I have now removed it on my development branch, so it can be replaced in the future with the coverage test.

Thursday 20 Aug 2020
9:52 pm

pmontazemi  (deleted user)

Why file is empty?

Why file is empty?

9:48 pm

pmontazemi  (deleted user)

Remove extra line.

Remove extra line.

Friday 14 Aug 2020
2:39 am

Behrouz NematiPour

DIALIN-DEN-4438_Saline Bolus
DIALIN-DEN-4438_Saline Bolus