DIALIN-DEN-8514

DIALIN-DEN-8514

Activity on this page:

Line History

Line history chart not available

Line history chart not available

 

Stats

Commits this week: 0
Total Commits: 2,952
Last Commit: 19 Nov
Commits this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 
Friday 02 Jul 2021
11:18 am

Behrouz NematiPour

11:17 am

pmontazemi  (deleted user)

RESOLVED.

RESOLVED.

11:15 am

plucia  (deleted user)

RESOLVED

RESOLVED

11:13 am

Behrouz NematiPour

That function doesn't use the UI message Id and is using dialin message-id enum which is not used in UI. *it doesn't get a parameter and is hardcoded. *I can remove that function if not being use...
  • That function doesn't use the UI message Id and is using dialin message-id enum which is not used in UI.
  • it doesn't get a parameter and is hardcoded.
  • I can remove that function if not being used anywhere else.
    Will take care of it in the code review of the next story.
11:12 am

Behrouz NematiPour

Removed in the current working code. Will be reviewed in the next review.

Removed in the current working code.
Will be reviewed in the next review.

10:58 am

plucia  (deleted user)

Tuesday 29 Jun 2021
8:44 am

pmontazemi  (deleted user)

Thursday 24 Jun 2021
8:11 am

pmontazemi  (deleted user)

Remove spaces around "=" sign.

Remove spaces around "=" sign.

Tuesday 15 Jun 2021
4:46 pm

plucia  (deleted user)

This function is a duplicate. Any reason not to update cmd_send_dg_serial without breaking backwards compatibility?

This function is a duplicate. Any reason not to update cmd_send_dg_serial without breaking backwards compatibility?

Monday 14 Jun 2021
11:53 am

Behrouz NematiPour

DIALIN-DEN-8514_UI DEV Alarms Active List Merge Setting
DIALIN-DEN-8514_UI DEV Alarms Active List Merge Setting
Sunday 06 Jun 2021
1:36 pm

Behrouz NematiPour

Tuesday 01 Jun 2021
11:38 am

pmontazemi  (deleted user) and plucia  (deleted user)

10:44 am

plucia  (deleted user)

RESOLVED

RESOLVED

10:44 am

plucia  (deleted user)

RESOLVED

RESOLVED

10:44 am

plucia  (deleted user)

RESOLVED

RESOLVED

10:44 am

plucia  (deleted user)

RESOLVED

RESOLVED

10:43 am

plucia  (deleted user)

RESOLVED

RESOLVED

Friday 28 May 2021
7:51 pm

Behrouz NematiPour

Thanks for catching that, Fixed.

Thanks for catching that,
Fixed.

7:50 pm

Behrouz NematiPour

Thanks for catching that, Fixed.

Thanks for catching that,
Fixed.

7:50 pm

Behrouz NematiPour

Thanks for catching that, Fixed.

Thanks for catching that,
Fixed.

7:50 pm

Behrouz NematiPour

Thanks for catching that, Fixed.

Thanks for catching that,
Fixed.

7:50 pm

Behrouz NematiPour

Thanks for catching that, Fixed.

Thanks for catching that,
Fixed.

5:26 pm

plucia  (deleted user)

Missing .value at the end of the message id

Missing .value at the end of the message id

5:26 pm

plucia  (deleted user)

Missing .value at the end of the message id

Missing .value at the end of the message id

5:26 pm

plucia  (deleted user)

Missing .value

Missing .value

5:26 pm

plucia  (deleted user)

Missing .value

Missing .value

5:25 pm

plucia  (deleted user)

Instead of MSG_ID_DG_DISINFECT_TIME_FLUSH It should be MSG_ID_DG_DISINFECT_TIME_FLUSH.value

Instead of 

MSG_ID_DG_DISINFECT_TIME_FLUSH

It should be 

MSG_ID_DG_DISINFECT_TIME_FLUSH.value
Thursday 27 May 2021
6:21 pm

Dara Navaei

DIALIN-DEN-8514_UI DEV Alarms Active List
DIALIN-DEN-8514_UI DEV Alarms Active List