RESOLVED

RESOLVED

Dialin Review
Dialin Review
Good, So please consider cleaning up used libraries periodically. RESOLVED.

Good,
So please consider cleaning up used libraries periodically.

RESOLVED.

RESOLVED

RESOLVED

1 - pip uses requirements.txt to install dependencies. See tools/setup_environment.sh for more detail. 2 - What you're asking about is the offline install capability. I have created a ticket in Jir...

1 - pip uses requirements.txt to install dependencies. See tools/setup_environment.sh for more detail.
2 - What you're asking about is the offline install capability. I have created a ticket in Jira http://dvm-linux02:8080/browse/DIAL-34 to track this new feature request.
3 - The offline install capability addresses this situation, in the (very) unlikely event that pypi hosting can't be relied upon.
4 - No. My understanding is that we do not need to validate these libraries because Dialin is NPSW.
5 - It's fine to have all of these libraries. For example, some of them are dependencies of python-can. Periodically this requirements.txt will be cleaned if a library is no longer being used. For this change-set, I added flake8 so we can run static code analysis. Flake8 is installed along with its dependencies.

I have updated it so it says Dialin now.

I have updated it so it says Dialin now.

I have some questions regarding these libraries. 1 - What tool/code is checking for these requirements? 2 - What if the requirement is not met? (not a correct version or lib not exists) 3 - If the ...

I have some questions regarding these libraries.
1 - What tool/code is checking for these requirements?
2 - What if the requirement is not met? (not a correct version or lib not exists)
3 - If the lib does not exist is it going to be installed or thrown an error?
4 - Don't we need to validate all these libraries?
5 - What is our process of adding more libraries to the list? On the other way is it fine to have all these libs? are all of them being used?

Why this code review starts with "UI_" it's all Dialin. Shouldn't it be started with Dialin?

Why this code review starts with "UI_" it's all Dialin.
Shouldn't it be started with Dialin?

Dialin DEN-4589_Sprint_26
Dialin DEN-4589_Sprint_26
RESOLVED

RESOLVED

RESOLVED

RESOLVED

RESOLVED

RESOLVED

RESOLVED

RESOLVED

Doesn't let me to click complete seem like I need to put a reply here. So : The interpretation of PEP8 were not correct and Leo suppose to fix it. RESOLVED

Doesn't let me to click complete seem like I need to put a reply here.
So :
The interpretation of PEP8 were not correct and Leo suppose to fix it.

RESOLVED

RESOLVED.

RESOLVED.

RESOLVED

RESOLVED

RESOLVED

RESOLVED

Two cargo(s) resolved for now

Two cargo(s)
resolved for now

RESOLVED

RESOLVED

funny that there were two cargo(s). One has been changed only. resolve for now.

funny that there were two cargo(s).
One has been changed only.
resolve for now.

RESOLVED

RESOLVED

RESOLVED

RESOLVED

Used constant.

Used constant.

Created constants for field positions.

Created constants for field positions.