HD-DEN-14457

HD-DEN-14457

Activity on this page:

Line History

Line history chart not available

Line history chart not available

 

Stats

Commits this week: 0
Total Commits: 3,304
Last Commit: 16 Dec
Commits this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 
Monday 27 Mar 2023
9:55 am

jtaylor  (deleted user)

8:42 am

Dara Navaei

Tuesday 21 Mar 2023
4:34 pm

Sean Nash and wbracken  (deleted user)

Monday 06 Mar 2023
4:43 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:12 am

jtaylor  (deleted user)

Done.

Done.

9:52 am

Sean Nash

Add blank line before return.

Add blank line before return.

Tuesday 28 Feb 2023
11:37 am

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

11:37 am

Sean Nash

I don't think it's necessary - but I'm ok with either location for declaration. RESOLVED in CODE WALKTHROUGH.

I don't think it's necessary - but I'm ok with either location for declaration.
RESOLVED in CODE WALKTHROUGH.

9:38 am

jtaylor  (deleted user)

1. Style, and preference to keep loop control at the top, not buried in the state function. 2. Keep stack size for the state function more predictable. 3. I was considering unwrapping the state mac...

1. Style, and preference to keep loop control at the top, not buried in the state function.
2. Keep stack size for the state function more predictable.
3. I was considering unwrapping the state machine, starting with a separate pause state, that held for priming to advance to the proper state

Ultimately the simplest change may be limited to just this ifndef. No practical reason to move the declaration in that case.

9:24 am

jtaylor  (deleted user)

So far as I can tell, this file was included in the code review only. The repository doesn't include these changes, on this branch.

So far as I can tell, this file was included in the code review only. The repository doesn't include these changes, on this branch.

Monday 27 Feb 2023
11:03 am

Sean Nash

Why move this?

Why move this?

10:59 am

Sean Nash

Saw same change in another branch. Not clear to me why we need/want to change empty state to completed state.

Saw same change in another branch. Not clear to me why we need/want to change empty state to completed state.

Tuesday 21 Feb 2023
3:38 pm

jtaylor  (deleted user)

SyringePump.c was included in this code review in error. The repositories associate the correct files with each branch.

SyringePump.c was included in this code review in error. The repositories associate the correct files with each branch.

Friday 17 Feb 2023
12:01 pm

Dara Navaei

HD-DEN-14457_Reservoir Drains Before Treatment With Pre Treatment Build Flags Off
HD-DEN-14457_Reservoir Drains Before Treatment With Pre Treatment Build Flags Off
Thursday 05 Jan 2023
4:29 pm

jtaylor  (deleted user)

4:29 pm

jtaylor  (deleted user)

Branch removed. This "bugfix" branch was created in error.

Branch removed. This "bugfix" branch was created in error.

11:00 am

Dara Navaei

HD-DEN-14457_Reservoir Drains Before Treatment With Pre Treatment Build Flags Off
HD-DEN-14457_Reservoir Drains Before Treatment With Pre Treatment Build Flags Off