HD-DEN-14459

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Fixed. Thanks!

Fixed. Thanks!

Are there any other ways to exit this state without zeroing this counter (e.g. going to manual control in first if above)? Generally difficult to get all of the places where exiting a state. Safer ...

Are there any other ways to exit this state without zeroing this counter (e.g. going to manual control in first if above)? Generally difficult to get all of the places where exiting a state. Safer to reset things on entry (i.e. line 359 above).

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

This is the only position where its unassigned (changed due to revert below). The counter itself is more controller level than driver level as the persistence counter may be different in other mode...

This is the only position where its unassigned (changed due to revert below). The counter itself is more controller level than driver level as the persistence counter may be different in other modes of operation. This counter is specifically here to hold the air pump on 100ms after upper level is detecting air. Should this check be moved to airpump.c?

Reverted. Thanks!

Reverted. Thanks!

it would take one state cycle ( 50ms ) to do that. The air pump can't drive the fluid level that fast. We can keep it for redundancy but the system would have much bigger problems going on for that...

it would take one state cycle ( 50ms ) to do that. The air pump can't drive the fluid level that fast. We can keep it for redundancy but the system would have much bigger problems going on for that to happen.

Unlikely that we would go from Liq/Liq to Air/Air, but if we did, we would no longer turn the air pump off with this code removed. Should we keep it?

Unlikely that we would go from Liq/Liq to Air/Air, but if we did, we would no longer turn the air pump off with this code removed. Should we keep it?

Safer to zero this when you turn the pump on (could be done in one place in setAirPumpState function) - that way you don't have to worry about zeroing it everywhere you stop the pump.

Safer to zero this when you turn the pump on (could be done in one place in setAirPumpState function) - that way you don't have to worry about zeroing it everywhere you stop the pump.

HD-DEN-14459_Air Trap Fill Alarm Not Triggering
HD-DEN-14459_Air Trap Fill Alarm Not Triggering