HD-DEN-15104

HD-DEN-15104

Activity on this page:

Line History

Line history chart not available

Line history chart not available

 

Stats

Commits this week: 0
Total Commits: 3,304
Last Commit: 16 Dec
Commits this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 
Monday 15 May 2023
1:43 pm

wbracken  (deleted user)

11:35 am

Darren Cox , jtaylor  (deleted user) and Sean Nash

Sunday 14 May 2023
3:11 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

3:10 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

3:09 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

12:48 pm

wbracken  (deleted user)

Moved to here from function.

Moved to here from function.

11:28 am

wbracken  (deleted user)

No longer needed.

No longer needed.

Friday 12 May 2023
5:33 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

5:32 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

5:31 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

5:31 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

5:31 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

5:30 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

5:30 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

5:29 pm

Sean Nash

Per my other comment, please avoid in-function static variables.

Per my other comment, please avoid in-function static variables.

5:28 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

5:28 pm

Sean Nash

Not a fan of in function statics. Probably due to Vectorcast having a hard time initializing them before function is called. Please avoid doing this.

Not a fan of in function statics. Probably due to Vectorcast having a hard time initializing them before function is called. Please avoid doing this.

5:27 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

5:26 pm

Sean Nash

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

5:26 pm

Sean Nash

Now it's gone. No longer needed?

Now it's gone. No longer needed?

1:48 pm

wbracken  (deleted user)

Removed

Removed

1:47 pm

wbracken  (deleted user)

There are enums for the valves. However, the enum value does not correspond to their position in the valve status returned from the FPGA. For example, VDI is enumerated to be the first value in the...

There are enums for the valves. However, the enum value does not correspond to their position in the valve status returned from the FPGA. For example, VDI is enumerated to be the first value in the enum but is the second 2nd group of 3 bits (0 relative) returned by the FPGA.

1:39 pm

wbracken  (deleted user)

This code is identical to the DG implementation. Initially they were only included in debug mode. Seemed like it made sense to move to function as they are only used in the function.

This code is identical to the DG implementation. Initially they were only included in debug mode. Seemed like it made sense to move to function as they are only used in the function.

1:33 pm

wbracken  (deleted user)

This code is identical to the DG implementation. Initially they were only included in debug mode. Seemed like it made sense to move to function as they are only used in the function.

This code is identical to the DG implementation. Initially they were only included in debug mode. Seemed like it made sense to move to function as they are only used in the function.

1:31 pm

wbracken  (deleted user)

Corrected

Corrected

1:21 pm

wbracken  (deleted user)

Removed

Removed

1:20 pm

wbracken  (deleted user)

Added space. I modified slightly, Since this is called outside of the interrupt where the sci2FEOEError is being set I believe it should get the value and only reset it if was TRUE.

Added space. I modified slightly, Since this is called outside of the interrupt where the sci2FEOEError is being set I believe it should get the value and only reset it if was TRUE.

1:16 pm

wbracken  (deleted user)

They were used when FE OE generated software fault. Removed.

They were used when FE OE generated software fault. Removed.

1:15 pm

wbracken  (deleted user)

Removed.

Removed.

1:13 pm

wbracken  (deleted user)

Cut and paste error from DG. Corrected.

Cut and paste error from DG. Corrected.