HD-DEN-2390

HD-DEN-2390

Activity on this page:

Line History

Line history chart not available

Line history chart not available

 

Stats

Commits this week: 0
Total Commits: 6,916
Last Commit: 19 Nov
Commits this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 
Wednesday 01 Apr 2020
9:32 am

Dara Navaei

8:42 am

pmontazemi  (deleted user) and Dara Navaei

8:35 am

pmontazemi  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

8:33 am

pmontazemi  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

8:33 am

pmontazemi  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Tuesday 31 Mar 2020
8:55 am

Sean Nash

At 50ms task interval, it can't. I believe what I was thinking is that 100 ms would be ok, but 150 ms would fail. Changed to 150 ms.

At 50ms task interval, it can't. I believe what I was thinking is that 100 ms would be ok, but 150 ms would fail. Changed to 150 ms.

8:54 am

Sean Nash

Done.

Done.

8:53 am

Sean Nash

Done.

Done.

8:45 am

pmontazemi  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

8:44 am

Sean Nash

Fixed.

Fixed.

Monday 30 Mar 2020
10:26 am

pmontazemi  (deleted user)

RESOLVED in CODE WALKTHROUGH. Dara will create a DevOps Task on Bamboo server to address this.

RESOLVED in CODE WALKTHROUGH. Dara will create a DevOps Task on Bamboo server to address this.

10:24 am

pmontazemi  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:23 am

pmontazemi  (deleted user)

Same comment on being more verbose on naming of function, here.

Same comment on being more verbose on naming of function, here.

10:20 am

pmontazemi  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:20 am

pmontazemi  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:18 am

pmontazemi  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:17 am

pmontazemi  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

8:45 am

Sean Nash

Not sure how else user would request something. I'm trying to keep these enums short while still being descriptive.

Not sure how else user would request something. I'm trying to keep these enums short while still being descriptive.

8:43 am

Sean Nash

I needed the treatment mode module to be able to see these so it could verify user settings changes.

I needed the treatment mode module to be able to see these so it could verify user settings changes.

8:42 am

Sean Nash

dialOut. Fixed.

dialOut. Fixed.

8:39 am

Sean Nash

Done by DG before it is sent to HD.

Done by DG before it is sent to HD.

8:37 am

Sean Nash

Done.

Done.

8:33 am

Sean Nash

Yes, my thinking is that an "official" build will never be zero. If we see zero, it means it's an unofficial build - probably from somebody's branch.

Yes, my thinking is that an "official" build will never be zero. If we see zero, it means it's an unofficial build - probably from somebody's branch.

8:22 am

Dara Navaei

Will do

Will do

Sunday 29 Mar 2020
9:31 pm

pmontazemi  (deleted user)

This build shall be overwritten by Bamboo server (no action item here, but one action item for DevOps).

This build shall be overwritten by Bamboo server (no action item here, but one action item for DevOps).

9:28 pm

pmontazemi  (deleted user)

How is 120 ms computed?

How is 120 ms computed?

9:25 pm

pmontazemi  (deleted user)

Avoid questions in code comments, turn them all to affirmations reflecting what this line of code is doing.

Avoid questions in code comments, turn them all to affirmations reflecting what this line of code is doing.

9:23 pm

pmontazemi  (deleted user)

function name not verbose enough, elaborate.

function name not verbose enough, elaborate.

9:22 pm

pmontazemi  (deleted user)

Where does the conversion from voltage to grams happen?

Where does the conversion from voltage to grams happen?

9:22 pm

pmontazemi  (deleted user)

dialIn or dialOut?

dialIn or dialOut?