HD-DEN-4640

HD-DEN-4640

Activity on this page:

Line History

Line history chart not available

Line history chart not available

 

Stats

Commits this week: 0
Total Commits: 6,916
Last Commit: 19 Nov
Commits this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 
Monday 23 Nov 2020
10:22 am

Sean Nash

10:15 am

Dara Navaei

Wednesday 18 Nov 2020
9:45 pm

qnguyen  (deleted user) and pmontazemi  (deleted user)

Monday 26 Oct 2020
10:41 am

pmontazemi  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:40 am

Sean Nash

Done.

Done.

10:36 am

pmontazemi  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:36 am

pmontazemi  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:32 am

pmontazemi  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:31 am

pmontazemi  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:31 am

pmontazemi  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:31 am

pmontazemi  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

9:31 am

Sean Nash

Structure fields are a mix of different sizes. Compiler will put each field in 32-bit space and pad by default. Since we will be serializing this data for transmission, we do not want structure to ...

Structure fields are a mix of different sizes. Compiler will put each field in 32-bit space and pad by default. Since we will be serializing this data for transmission, we do not want structure to include any padding. The pack pragma instructs compiler not to pad.

9:28 am

Sean Nash

Done.

Done.

9:25 am

Sean Nash

Not consistent. Made all pointers.

Not consistent. Made all pointers.

9:22 am

Sean Nash

These will always be a mix of some un-commented and some commented. Comments would be aligned if all were un-commented.

These will always be a mix of some un-commented and some commented. Comments would be aligned if all were un-commented.

Tuesday 20 Oct 2020
1:20 pm

pmontazemi  (deleted user)

Align parameters and associated comments.

Align parameters and associated comments.

1:19 pm

pmontazemi  (deleted user)

1. Why dialInData is not a pointer but line below *dialOutFlowData is pointed? 2. Why one's name does not include the keyword "Flow" and the other does?

1. Why dialInData is not a pointer but line below *dialOutFlowData is pointed?
2. Why one's name does not include the keyword "Flow" and the other does?

1:12 pm

pmontazemi  (deleted user)

Align all parameters and all corresponding Doxygen comments.

Align all parameters and all corresponding Doxygen comments.

1:04 pm

pmontazemi  (deleted user)

Purpose of asking pre-processor to pack?

Purpose of asking pre-processor to pack?

1:01 pm

pmontazemi  (deleted user)

Add units in comment between parentheses.

Add units in comment between parentheses.

11:54 am

Sean Nash

In f/w, I like to keep percentages as per unit so that the math works - e.g. if I need to apply percentage to something I can just multiply it directly. On Dialin side, I kept as percentage.

In f/w, I like to keep percentages as per unit so that the math works - e.g. if I need to apply percentage to something I can just multiply it directly.
On Dialin side, I kept as percentage.

11:54 am

Sean Nash

In f/w, I like to keep percentages as per unit so that the math works - e.g. if I need to apply percentage to something I can just multiply it directly. On Dialin side, I kept as percentage.

In f/w, I like to keep percentages as per unit so that the math works - e.g. if I need to apply percentage to something I can just multiply it directly.
On Dialin side, I kept as percentage.

11:28 am

pmontazemi  (deleted user)

Why one value is in percent and the other in per unit? (which requires conversion)

Why one value is in percent and the other in per unit? (which requires conversion)

11:27 am

pmontazemi  (deleted user)

Why one flow is in percent and the other in per unit? (which requires conversion)

Why one flow is in percent and the other in per unit? (which requires conversion)

Monday 19 Oct 2020
10:35 am

pmontazemi  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

10:24 am

Sean Nash

Done.

Done.

10:14 am

pmontazemi  (deleted user)

Remove extra line.

Remove extra line.

Wednesday 14 Oct 2020
10:33 am

qnguyen  (deleted user)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Monday 12 Oct 2020
10:19 am

Sean Nash

Done.

Done.

9:25 am

qnguyen  (deleted user)

Suggest expanding these macros.

Suggest expanding these macros.