HD-DEN-4640

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Done.

Done.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Structure fields are a mix of different sizes. Compiler will put each field in 32-bit space and pad by default. Since we will be serializing this data for transmission, we do not want structure to ...

Structure fields are a mix of different sizes. Compiler will put each field in 32-bit space and pad by default. Since we will be serializing this data for transmission, we do not want structure to include any padding. The pack pragma instructs compiler not to pad.

Done.

Done.

Not consistent. Made all pointers.

Not consistent. Made all pointers.

These will always be a mix of some un-commented and some commented. Comments would be aligned if all were un-commented.

These will always be a mix of some un-commented and some commented. Comments would be aligned if all were un-commented.

Align parameters and associated comments.

Align parameters and associated comments.

1. Why dialInData is not a pointer but line below *dialOutFlowData is pointed? 2. Why one's name does not include the keyword "Flow" and the other does?

1. Why dialInData is not a pointer but line below *dialOutFlowData is pointed?
2. Why one's name does not include the keyword "Flow" and the other does?

Align all parameters and all corresponding Doxygen comments.

Align all parameters and all corresponding Doxygen comments.

Purpose of asking pre-processor to pack?

Purpose of asking pre-processor to pack?

Add units in comment between parentheses.

Add units in comment between parentheses.

In f/w, I like to keep percentages as per unit so that the math works - e.g. if I need to apply percentage to something I can just multiply it directly. On Dialin side, I kept as percentage.

In f/w, I like to keep percentages as per unit so that the math works - e.g. if I need to apply percentage to something I can just multiply it directly.
On Dialin side, I kept as percentage.

In f/w, I like to keep percentages as per unit so that the math works - e.g. if I need to apply percentage to something I can just multiply it directly. On Dialin side, I kept as percentage.

In f/w, I like to keep percentages as per unit so that the math works - e.g. if I need to apply percentage to something I can just multiply it directly.
On Dialin side, I kept as percentage.

Why one value is in percent and the other in per unit? (which requires conversion)

Why one value is in percent and the other in per unit? (which requires conversion)

Why one flow is in percent and the other in per unit? (which requires conversion)

Why one flow is in percent and the other in per unit? (which requires conversion)

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Done.

Done.

Remove extra line.

Remove extra line.

RESOLVED in CODE WALKTHROUGH.

RESOLVED in CODE WALKTHROUGH.

Done.

Done.

Suggest expanding these macros.

Suggest expanding these macros.