LEAHI-DD-FIRMWARE-LDT-1473

Add a comment to right listing math functions used.

Add a comment to right listing math functions used.

Remove blank line.

Remove blank line.

DENBUG-331: Duplicate Device Logs Uploading to Modaflx Connect

- add duplicate function for 2010

    • -0
    • +35
    /sources/device/DeviceController.cpp
Looks crucible is not seeing those. let me check once with Dara.

Looks crucible is not seeing those. let me check once with Dara.

Done.

Done.

Updated.

Updated.

Updated

Updated

seems to be old , need to merge the staging code

seems to be old , need to merge the staging code

align the comment

align the comment

complicated check should be replaced with boolean flag

complicated check should be replaced with boolean flag

Variable name is not understood -temDataCollectionTimeInterval ?

Variable name is not understood -temDataCollectionTimeInterval ?

Yes. updated.

Yes. updated.

So shouldn't we stop trimmer heater here then?

So shouldn't we stop trimmer heater here then?

DENBUG-331: Duplicate Device Logs Uploading to Modaflx Connect

Address CR comments

    • -1
    • +9
    /sources/cloudsync/CloudSyncController.h
Done.

Done.

Done

Done

Since trimmer heater is enabled, no need of temp compensation. only for testing purposes, temp compensation is needed. Hence by default, temp compensation is disabled.

Since trimmer heater is enabled, no need of temp compensation. only for testing purposes, temp compensation is needed. Hence by default, temp compensation is disabled.

For spent chamber fill, we don't know how low the liquid level is ( in Chamber H) and hence decided not to turn on the trimmer heater for safety reasons. For bicarb fill, the dry bicart code should...

For spent chamber fill, we don't know how low the liquid level is ( in Chamber H) and hence decided not to turn on the trimmer heater for safety reasons. For bicarb fill, the dry bicart code should cover the actuators status. the current bicarb chamber fill code here should be updated with the newly implemented dry bi cart code changes.

DENBUG-331: Duplicate Device Logs Uploading to Modaflx Connect

- Add new error message for cloudsync for log duplicates

- Add more parameters to 2010 signal

- add Switch case logic for 2010 reject reason. Logic to be implemented and discussed

    • -1351
    • +1369
    /sources/cloudsync/CloudSyncController.cpp
    • -331
    • +333
    /sources/cloudsync/CloudSyncController.h
    • -4
    • +12
    /sources/device/DeviceController.cpp
Mis-spelled "Stabilized".

Mis-spelled "Stabilized".

I think you can do this in 1 line of code using the RANGE macro in Common.h.

I think you can do this in 1 line of code using the RANGE macro in Common.h.

What should trimmer heater be doing in these spent/bicarb chamber states?

What should trimmer heater be doing in these spent/bicarb chamber states?

I would think this would be enabled by default.

I would think this would be enabled by default.

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

    • -0
    • +14
    /sources/model/settings/MWifiNetwork.h
Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

    • -14
    • +0
    /sources/model/settings/MWifiNetwork.h
Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

    • -0
    • +14
    /sources/model/dg/data/MDGGeneralEvent.h
Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

  1. … 607 more files in changeset.
LEAHI-DD-FIRMWARE-LDT-1473_Ultrafiltration - DD
LEAHI-DD-FIRMWARE-LDT-1473_Ultrafiltration - DD
Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

    • -20
    • +14
    /sources/model/hd/alarm/MAlarmMapping.cpp