LEAHI-DD-FIRMWARE-LDT-2030

LEAHI-DD-FIRMWARE-LDT-2030

Activity on this page:

Line History

Line history chart not available

Line history chart not available

 

Stats

Commits this week: 2
Total Commits: 3,310
Last Commit: 11:51
Commits this week: 2

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 
Today
1 hr ago

Tiffany Mejia

DENBUG-331: Duplicate Device Logs Uploading to Modaflx Connect

Address CR comments

Options
    • -8
    • +8
    /sources/cloudsync/CloudSyncController.cpp
    • -1
    • +9
    /sources/cloudsync/CloudSyncController.h
    • -4
    • +3
    /sources/device/DeviceController.cpp
Wednesday 04 Feb
3:03 pm

Tiffany Mejia

DENBUG-331: Duplicate Device Logs Uploading to Modaflx Connect

- Add new error message for cloudsync for log duplicates

- Add more parameters to 2010 signal

- add Switch case logic for 2010 reject reason. Logic to be implemented and discussed

Options
    • -1351
    • +1369
    /sources/cloudsync/CloudSyncController.cpp
    • -331
    • +333
    /sources/cloudsync/CloudSyncController.h
    • -4
    • +12
    /sources/device/DeviceController.cpp
    • -1
    • +1
    /sources/device/DeviceController.h
Monday 02 Feb
9:35 am

Sean Nash

Remove extra blank line.

Remove extra blank line.

9:35 am

Sean Nash

Remove blank line.

Remove blank line.

9:34 am

Sean Nash

Remove blank line.

Remove blank line.

9:33 am

Sean Nash

Remove blank line.

Remove blank line.

Monday 12 Jan
10:29 am

Sean Nash

9:10 am

Sean Nash

Ah, I see it now. But we haven't really addressed my original comment. I will resolve for now, but keep in mind that I'd like to avoid this kind of sequencing where we are declaring local variables...

Ah, I see it now. But we haven't really addressed my original comment. I will resolve for now, but keep in mind that I'd like to avoid this kind of sequencing where we are declaring local variables below statements like on 948.

8:44 am

Dara Navaei

It is defined in line 937.

It is defined in line 937.

Sunday 11 Jan
9:14 pm

Sean Nash

Well now you're using cmdSpec and I don't see where it's declared. Does this compile now?

Well now you're using cmdSpec and I don't see where it's declared. Does this compile now?

Wednesday 07 Jan
4:14 pm

Vendor - TEL - Jashwant Gantyada

removed

removed

4:14 pm

Vendor - TEL - Jashwant Gantyada

done.

done.

4:13 pm

Vendor - TEL - Jashwant Gantyada

done.

done.

4:13 pm

Vendor - TEL - Jashwant Gantyada

removed all.

removed all.

4:13 pm

Vendor - TEL - Jashwant Gantyada

followed the pattern.

followed the pattern.

4:13 pm

Vendor - TEL - Jashwant Gantyada

changed.

changed.

4:12 pm

Vendor - TEL - Jashwant Gantyada

done. changed.

done. changed.

4:12 pm

Vendor - TEL - Jashwant Gantyada

changed.

changed.

4:12 pm

Vendor - TEL - Jashwant Gantyada

changed.

changed.

4:12 pm

Vendor - TEL - Jashwant Gantyada

removed.

removed.

4:11 pm

Vendor - TEL - Jashwant Gantyada

done

done

4:11 pm

Vendor - TEL - Jashwant Gantyada

changed

changed

4:11 pm

Vendor - TEL - Jashwant Gantyada

done

done

4:11 pm

Vendor - TEL - Jashwant Gantyada

done

done

4:11 pm

Vendor - TEL - Jashwant Gantyada

done

done

4:10 pm

Vendor - TEL - Jashwant Gantyada

done

done

4:10 pm

Vendor - TEL - Jashwant Gantyada

done.

done.

1:22 pm

Sean Nash

Should only have one exit for a function at end of function (per our coding standards).

Should only have one exit for a function at end of function (per our coding standards).

1:22 pm

Sean Nash

Add space between (( and )).

Add space between (( and )).

1:20 pm

Sean Nash

We should always include the s/w fault ID and a supporting data (in this case, maybe cmd) with s/w fault alarms.

We should always include the s/w fault ID and a supporting data (in this case, maybe cmd) with s/w fault alarms.