LEAHI-DD-FIRMWARE-LDT-2030

DENBUG-331: Duplicate Device Logs Uploading to Modaflx Connect

Address CR comments

    • -1
    • +9
    /sources/cloudsync/CloudSyncController.h
DENBUG-331: Duplicate Device Logs Uploading to Modaflx Connect

- Add new error message for cloudsync for log duplicates

- Add more parameters to 2010 signal

- add Switch case logic for 2010 reject reason. Logic to be implemented and discussed

    • -1351
    • +1369
    /sources/cloudsync/CloudSyncController.cpp
    • -331
    • +333
    /sources/cloudsync/CloudSyncController.h
    • -4
    • +12
    /sources/device/DeviceController.cpp
Remove extra blank line.

Remove extra blank line.

Remove blank line.

Remove blank line.

Remove blank line.

Remove blank line.

Remove blank line.

Remove blank line.

Ah, I see it now. But we haven't really addressed my original comment. I will resolve for now, but keep in mind that I'd like to avoid this kind of sequencing where we are declaring local variables...

Ah, I see it now. But we haven't really addressed my original comment. I will resolve for now, but keep in mind that I'd like to avoid this kind of sequencing where we are declaring local variables below statements like on 948.

It is defined in line 937.

It is defined in line 937.

Well now you're using cmdSpec and I don't see where it's declared. Does this compile now?

Well now you're using cmdSpec and I don't see where it's declared. Does this compile now?

removed

removed

done.

done.

done.

done.

removed all.

removed all.

followed the pattern.

followed the pattern.

changed.

changed.

done. changed.

done. changed.

changed.

changed.

changed.

changed.

removed.

removed.

done

done

changed

changed

done

done

done

done

done

done

done

done

done.

done.

Should only have one exit for a function at end of function (per our coding standards).

Should only have one exit for a function at end of function (per our coding standards).

Add space between (( and )).

Add space between (( and )).

We should always include the s/w fault ID and a supporting data (in this case, maybe cmd) with s/w fault alarms.

We should always include the s/w fault ID and a supporting data (in this case, maybe cmd) with s/w fault alarms.