LEAHI-DD-FIRMWARE-LDT-3103

LEAHI-DD-FIRMWARE-LDT-3103

Activity on this page:

Line History

Line history chart not available

Line history chart not available

 

Stats

Commits this week: 1
Total Commits: 3,309
Last Commit: 15:03
Commits this week: 1

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 
Monday 02 Feb
10:55 am

Sean Nash

Remove blank line.

Remove blank line.

10:55 am

Sean Nash

Add a blank line before return statement.

Add a blank line before return statement.

10:52 am

Sean Nash

Why is this commented out?

Why is this commented out?

10:51 am

Sean Nash

d48PumpSpeed is an input.

d48PumpSpeed is an input.

Wednesday 21 Jan
1:09 pm

Vendor - TEL - Jashwant Gantyada

We will have to look at it as well. But for now, we are just monitoring the fresh side pressure variation.

We will have to look at it as well. But for now, we are just monitoring the fresh side pressure variation.

1:08 pm

Vendor - TEL - Jashwant Gantyada

This is a testable value.

This is a testable value.

12:44 pm

Sean Nash

Should we remove the condition instead of commenting it out?

Should we remove the condition instead of commenting it out?

Thursday 15 Jan
2:21 pm

Vendor - TEL - Jashwant Gantyada

changed the name to differentiate between driver level and controller level functions.

changed the name to differentiate between driver level and controller level functions.

2:20 pm

Vendor - TEL - Jashwant Gantyada

Yes. will tune them based on the test results.

Yes. will tune them based on the test results.

2:20 pm

Vendor - TEL - Jashwant Gantyada

Fixed it.

Fixed it.

2:20 pm

Vendor - TEL - Jashwant Gantyada

We handle it in the checkSpentFillComplete() mentioned in line 946.

We handle it in the checkSpentFillComplete() mentioned in line 946.

2:18 pm

Vendor - TEL - Jashwant Gantyada

done.

done.

Wednesday 14 Jan
3:08 pm

Vendor - TEL - Jashwant Gantyada

Why are we adjusting/reducing the speed of D48 by a factor of 50%?

Why are we adjusting/reducing the speed of D48 by a factor of 50%?

11:02 am

Sean Nash

I thought we were going to complete cycle when done (not based on time) and feed back error in cycle time to control D48 pump speed to reduce error going forward so we end up getting the target cyc...

I thought we were going to complete cycle when done (not based on time) and feed back error in cycle time to control D48 pump speed to reduce error going forward so we end up getting the target cycle time which will give us target flow rate.

10:53 am

Sean Nash

Where is the closed loop control?

Where is the closed loop control?

10:51 am

Sean Nash

Is this an initial guess for pump control?

Is this an initial guess for pump control?

9:50 am

Sean Nash

Add spaces before/after +=.

Add spaces before/after +=.

9:47 am

Sean Nash

Shouldn't this kind of function be in the pump controller unit? Assuming such functions already exist in the controller, so why do we need these?

Shouldn't this kind of function be in the pump controller unit? Assuming such functions already exist in the controller, so why do we need these?

Tuesday 13 Jan
1:47 pm

Vendor - TEL - Jashwant Gantyada

Why are we checking only fresh side pressures and not spent side as well?

Why are we checking only fresh side pressures and not spent side as well?

Monday 12 Jan
5:00 pm

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-3103_implement closed loop control for d48 pump speed
LEAHI-DD-FIRMWARE-LDT-3103_implement closed loop control for d48 pump speed
Tuesday 23 Dec 2025
7:15 pm

Dara Navaei

7:15 pm

Dara Navaei