LEAHI-DIALIN-LDT-2004 LEAHI-DIALIN-LDT-2004

3:30 pm

Vendor - TEL - Sameer Poyil , Zoltan Miskolci and Michael Garthwaite

More
LEAHI-DIALIN-LDT-2004-1
finished reviewing

2:05 pm

Zoltan Miskolci

Based on the msg id, it should be here

1:30 pm

Vendor - TEL - Sameer Poyil

More
Re: LEAHI-DIALIN-LDT-2004-1
commented on review

@zoltan , could you please confirm whether this is the correct place for BICART_DATA ?

9:09 am

Zoltan Miskolci

More
Re: LEAHI-DIALIN-LDT-2004-1
commented on review

Please pull the latest staging and update the test configs regarding that. I think the dry bicart test config is already there

Please pull the latest staging and update the test configs regarding that.
I think the dry bicart test config is already there

4:00 pm

Sean Nash

More
LEAHI-DIALIN-LDT-2004-1
resumed reviewing

10:07 am

Zoltan Miskolci

More
LEAHI-DIALIN-LDT-2004-2
finished reviewing

9:20 am

Michael Garthwaite

updated to use the generic override. Both of you are correct, the generic override can be used. Since we pack the payload outside of the generic override, for this situation we don't pack the res...

updated to use the generic override.

Both of you are correct, the generic override can be used.

Since we pack the payload outside of the generic override, for this situation we don't pack the reset byte and therefore will stay as a U32 which satisfies the FW constraint. The other concern I had was that the FW would not reply back with a test ACK back to dialin with this cmd, thus causing a timeout in the generic override function. This is address as all messages in the lookup table in FW will reply back with a test ACK.

Therefore im okay using the generic override method

10:46 pm

Sean Nash

More
LEAHI-DIALIN-LDT-2004-2
finished reviewing

10:45 pm

Sean Nash

If Michael is right, then f/w is not expecting an override payload and so we shouldn't use the generic override payload structure.

3:13 pm

Zoltan Miskolci

It handles different size of payloads, and requests without payload without having an issue, so I don't understand why would it cause an issue. you are sending a message with this msg id and this p...

It handles different size of payloads, and requests without payload without having an issue, so I don't understand why would it cause an issue.
you are sending a message with this msg id and this payload, if the FW is expecting that, then it will work.

Should I rename the cmd_generic_override to like cmd_generic_message_sender to be less confusing?

12:31 pm

Michael Garthwaite

fixed writing over the error count override. Model ID isnt an override. Its a set as it does not revert back to another value. FW will be looking for only 1 U32 instead of a TEST_OVERRIDE_PAYLOAD_...

fixed writing over the error count override.

Model ID isnt an override. Its a set as it does not revert back to another value. FW will be looking for only 1 U32 instead of a TEST_OVERRIDE_PAYLOAD_T.

the generic override will cause the FW to always reject the value since the payload size is not what is expected.

12:26 pm

Zoltan Miskolci

More
Re: LEAHI-DIALIN-LDT-2004-2
commented on review

Can't we use the generic override? You just need to update 3 fields: msg_id = MsgIds.MSG_ID_DD_SET_CONDUCTIVITY_MODEL_REQUEST entity_name = 'DD Coductivity sensor model request' override_text = 'S...

Can't we use the generic override?
You just need to update 3 fields:

msg_id = MsgIds.MSG_ID_DD_SET_CONDUCTIVITY_MODEL_REQUEST
entity_name = 'DD Coductivity sensor model request'
override_text = 'Sent' or ''

12:16 pm