RO-LDT-566

RO-LDT-566

Activity on this page:

Line History

Line history chart not available

Line history chart not available

 

Stats

Commits this week: 0
Total Commits: 3,304
Last Commit: 16 Dec
Commits this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 
Wednesday 03 Sep
8:53 am

Michael Garthwaite

8:53 am

Michael Garthwaite

8:53 am

Michael Garthwaite

Tuesday 19 Aug
9:05 am

Dara Navaei and Sean Nash

8:55 am

Sean Nash

Align comment.

Align comment.

8:52 am

Sean Nash

Where did these move to?

Where did these move to?

8:50 am

Sean Nash

These broadcast changes look like temporary test changes. Restore before merging this branch to staging.

These broadcast changes look like temporary test changes. Restore before merging this branch to staging.

8:48 am

Sean Nash

This "if" is not necessary. Just assign to TRUE regardless.

This "if" is not necessary. Just assign to TRUE regardless.

8:47 am

Sean Nash

Add comment to right. And it looks like this flag only relates to flow control - so variable name and comment should reflect that.

Add comment to right.
And it looks like this flag only relates to flow control - so variable name and comment should reflect that.

8:45 am

Sean Nash

Align "=".

Align "=".

8:44 am

Sean Nash

Should this be an "else if"?

Should this be an "else if"?

8:40 am

Sean Nash

Add blank line after declarations.

Add blank line after declarations.

8:39 am

Sean Nash

Remove extra blank line.

Remove extra blank line.

8:39 am

Sean Nash

Are we going to change back to duty cycle % as control signal output?

Are we going to change back to duty cycle % as control signal output?

8:37 am

Sean Nash

Realign comments.

Realign comments.

8:37 am

Sean Nash

Monday 18 Aug
10:16 am

Michael Garthwaite

No and yes. This is for debugging purposes since Dialin will keep a history of events that have happened rather than the alarm module that will only contain the last received alarm trigger. I only ...

No and yes. This is for debugging purposes since Dialin will keep a history of events that have happened rather than the alarm module that will only contain the last received alarm trigger. I only want to keep this until we start enforcing alarms and transitioning into fault.

10:07 am

Sean Nash

Is this adding anything that the trigger alarm message doesn't already do?

Is this adding anything that the trigger alarm message doesn't already do?

Wednesday 13 Aug
2:06 pm

Dara Navaei

RO-LDT-566_Water Treatment And Degassing FP 2
RO-LDT-566_Water Treatment And Degassing FP 2
Tuesday 12 Aug
1:48 pm

Sean Nash

When commenting out problematic alarms (temporarily), can we at least send an event w/ same 2 datas for logging purposes so we can investigate later?

When commenting out problematic alarms (temporarily), can we at least send an event w/ same 2 datas for logging purposes so we can investigate later?

Thursday 07 Aug
2:02 pm

Dara Navaei

RO-LDT-566_Water Treatment And Degassing FP 2
RO-LDT-566_Water Treatment And Degassing FP 2
2:02 pm

Dara Navaei

RO-LDT-566_Water Treatment And Degassing FP 2
RO-LDT-566_Water Treatment And Degassing FP 2
Wednesday 06 Aug
8:18 am

Michael Garthwaite

Tuesday 05 Aug
5:13 pm

Sean Nash and Vinayakam Mani

9:28 am

Michael Garthwaite

Monday 04 Aug
9:26 am

Michael Garthwaite

Added TODO. It'll be implemented in the next branch regarding stop/pauses states and alarm requirements.

Added TODO. It'll be implemented in the next branch regarding stop/pauses states and alarm requirements.

Friday 01 Aug
3:35 pm

Sean Nash

Remove blank line.

Remove blank line.

3:35 pm

Sean Nash

I think FP and DD need to handle alarm trigger, clear, and clear condition messages (msg ID 2,3,4) from other s/w stacks.

I think FP and DD need to handle alarm trigger, clear, and clear condition messages (msg ID 2,3,4) from other s/w stacks.

3:34 pm

Sean Nash

I would put normal messages above Dialin messages in this list - basically ordering this list in msg enum order.

I would put normal messages above Dialin messages in this list - basically ordering this list in msg enum order.

3:29 pm

Sean Nash

Remove blank line.

Remove blank line.