TD-LEAH-32

TD-LEAH-32

Activity on this page:

Line History

Line history chart not available

Line history chart not available

 

Stats

Commits this week: 0
Total Commits: 3,304
Last Commit: 16 Dec
Commits this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 
Thursday 05 Sep 2024
11:06 am

Sean Nash

9:10 am

Vinayakam Mani

Wednesday 04 Sep 2024
10:06 pm

Dara Navaei

10:06 pm

Dara Navaei

I can update the numbers.

I can update the numbers.

9:45 pm

Sean Nash

But what is 0x3000?

But what is 0x3000?

9:42 pm

Sean Nash

Some day. I don't even know what it is and if we even used it in Denali. For now, I want to close this out and merge to staging.

Some day. I don't even know what it is and if we even used it in Denali. For now, I want to close this out and merge to staging.

12:31 pm

Dara Navaei

Do you think we need it? So we should ask Noe to add it?

Do you think we need it? So we should ask Noe to add it?

12:30 pm

Sean Nash

Noe didn't include it.

Noe didn't include it.

12:29 pm

Dara Navaei

This function is used to calculate the baro sensor's CRC.

This function is used to calculate the baro sensor's CRC.

12:29 pm

Sean Nash

I kept these out of common because it's doing some specific things like broadcasting alarm trigger message.

I kept these out of common because it's doing some specific things like broadcasting alarm trigger message.

12:28 pm

Sean Nash

Removed.

Removed.

12:25 pm

Sean Nash

Details are in the header file where the group is defined. This is just saying that all of the code below goes into this group.

Details are in the header file where the group is defined. This is just saying that all of the code below goes into this group.

12:22 pm

Sean Nash

This one masks off lowest nibble. I will make a #define for it.

This one masks off lowest nibble. I will make a #define for it.

12:18 pm

Sean Nash

Who wrote this function? Do you know what to call it?

Who wrote this function? Do you know what to call it?

12:17 pm

Sean Nash

Correct.

Correct.

12:17 pm

Sean Nash

Fixed.

Fixed.

12:16 pm

Sean Nash

Why? I don't recall commenting on private function prototypes. We comment them in function headers.

Why? I don't recall commenting on private function prototypes. We comment them in function headers.

11:24 am

Dara Navaei

Why the has status register been removed?

Why the has status register been removed?

11:23 am

Dara Navaei

The copyright section will be automatically updated during the builds.

The copyright section will be automatically updated during the builds.

11:19 am

Dara Navaei

Can some of these functions be added to the leahi-fwcommon alarm management? Like active alarm or clear alarm. I understand that it might be too difficult to tailor these functions for all of the s...

Can some of these functions be added to the leahi-fwcommon alarm management? Like active alarm or clear alarm. I understand that it might be too difficult to tailor these functions for all of the stacks.

11:15 am

Dara Navaei

Add more details.

Add more details.

11:13 am

Dara Navaei

Remove this code. There is no RTC anymore.

Remove this code. There is no RTC anymore.

10:58 am

Dara Navaei

We should have #define for this number.

We should have #define for this number.

10:58 am

Dara Navaei

We should have #define for this number.

We should have #define for this number.

10:54 am

Dara Navaei

Per the design we agreed on TD not checking with RO directly, right?

Per the design we agreed on TD not checking with RO directly, right?

10:50 am

Dara Navaei

This line needs a doxygen comment.

This line needs a doxygen comment.

Tuesday 03 Sep 2024
9:36 am

Sean Nash

This function was for the 4 pinch valves in HD so I don't think a VBT control is right for this. I figured we could sort this out when we work on the valves controller/monitor unit.

This function was for the 4 pinch valves in HD so I don't think a VBT control is right for this.
I figured we could sort this out when we work on the valves controller/monitor unit.

9:30 am

Sean Nash

Done.

Done.

9:28 am

Sean Nash

Renamed to DD fault. I think an RO fault can share the DD fault property since I imagine an RO fault would cause the DD to go to fault mode.

Renamed to DD fault.
I think an RO fault can share the DD fault property since I imagine an RO fault would cause the DD to go to fault mode.

9:25 am

Sean Nash

Fixed.

Fixed.