Index: cppcheck.err =================================================================== diff -u -r2b052737cfe750322f5be63f57325ff08dcb9483 -raebd7de323b1a841a479f3aba07df0e1f6cef145 --- cppcheck.err (.../cppcheck.err) (revision 2b052737cfe750322f5be63f57325ff08dcb9483) +++ cppcheck.err (.../cppcheck.err) (revision aebd7de323b1a841a479f3aba07df0e1f6cef145) @@ -1,8 +1,8 @@ -[sources/ApplicationPost.cpp:62] -> [sources/ApplicationPost.cpp:64]: (style) Condition '!ok' is always false -[sources/ApplicationPost.cpp:87] -> [sources/ApplicationPost.cpp:89]: (style) Condition '!ok' is always false -[sources/ApplicationPost.cpp:131] -> [sources/ApplicationPost.cpp:133]: (style) Condition '!ok' is always false -[sources/ApplicationPost.cpp:148] -> [sources/ApplicationPost.cpp:150]: (style) Condition '!ok' is always false -[sources/ApplicationPost.cpp:156] -> [sources/ApplicationPost.cpp:158]: (style) Condition '!ok' is always false +[sources/ApplicationPost.cpp:77] -> [sources/ApplicationPost.cpp:79]: (style) Condition '!ok' is always false +[sources/ApplicationPost.cpp:104] -> [sources/ApplicationPost.cpp:106]: (style) Condition '!ok' is always false +[sources/ApplicationPost.cpp:157] -> [sources/ApplicationPost.cpp:158]: (style) Condition '!ok' is always false +[sources/ApplicationPost.cpp:183] -> [sources/ApplicationPost.cpp:185]: (style) Condition '!ok' is always false +[sources/ApplicationPost.cpp:197] -> [sources/ApplicationPost.cpp:199]: (style) Condition '!ok' is always false [sources/MainTimer.cpp:69]: (style) The scope of the variable 'oH' can be reduced. Warning: Be careful when fixing this message, especially when there are inner loops. Here is an example where cppcheck will write that the scope for 'i' can be reduced: void f(int x) { @@ -45,7 +45,6 @@ [sources/model/hd/adjustment/treatment/MTreatmentAdjustUltrafiltrationEditResponse.h:67] -> [sources/model/hd/adjustment/treatment/MTreatmentAdjustUltrafiltrationConfirmResponse.h:61]: (warning) The class 'MAdjustUltrafiltrationEditResponse' defines member variable with name 'stringPrefix' also defined in its parent class 'MAdjustUltrafiltrationConfirmResponse'. [sources/model/hd/adjustment/treatment/MTreatmentAdjustUltrafiltrationEditResponse.h:79] -> [sources/model/hd/adjustment/treatment/MTreatmentAdjustUltrafiltrationConfirmResponse.h:79]: (warning) The class 'MAdjustUltrafiltrationEditResponse' defines member variable with name '_data' also defined in its parent class 'MAdjustUltrafiltrationConfirmResponse'. [sources/storage/Settings.h:44]: (style) Unused private function: 'Settings::makeSetting' -[sources/AlarmGenerator.cpp:67]: (style) The function 'ALARM_ID_BLE_CUFF' is never used. [sources/view/VTreatmentCreate.cpp:124]: (style) The function 'doCancel' is never used. [sources/view/settings/VNetworkModel.cpp:224]: (style) The function 'doCheckIfConnected' is never used. [sources/view/hd/alarm/VAlarmStatus.cpp:93]: (style) The function 'doClearCondition' is never used. @@ -61,7 +60,7 @@ [sources/view/hd/adjustment/treatment/VTreatmentAdjustmentUltrafiltrationConfirm.cpp:66]: (style) The function 'doOptionDuration' is never used. [sources/view/hd/adjustment/treatment/VTreatmentAdjustmentRecirculate.cpp:51]: (style) The function 'doReconnect' is never used. [sources/view/hd/alarm/VAlarmActiveList.cpp:106]: (style) The function 'doRequest' is never used. -[sources/view/hd/adjustment/common/VCommonAdjustmentVitals.cpp:110]: (style) The function 'doReset' is never used. +[sources/view/hd/adjustment/common/VCommonAdjustmentVitals.cpp:109]: (style) The function 'doReset' is never used. [sources/view/VTreatmentCreate (legacy).cpp:111]: (style) The function 'doResetCreateTreatment' is never used. [sources/view/hd/adjustment/pretreatment/VPreTreatmentAdjustmentWaterSample.cpp:64]: (style) The function 'doResult' is never used. [sources/view/hd/adjustment/treatment/VTreatmentAdjustmentHeparin.cpp:51]: (style) The function 'doResume' is never used. @@ -70,9 +69,9 @@ [sources/view/settings/VNetworkModel.cpp:321]: (style) The function 'doSetIPAddress' is never used. [sources/view/settings/VNetworkModel.cpp:339]: (style) The function 'doSetSubnetMask' is never used. [sources/view/hd/alarm/VAlarmStatus.cpp:76]: (style) The function 'doSilence' is never used. -[sources/view/hd/adjustment/common/VCommonAdjustmentVitals.cpp:92]: (style) The function 'doSkip' is never used. +[sources/view/hd/adjustment/common/VCommonAdjustmentVitals.cpp:89]: (style) The function 'doSkip' is never used. [sources/view/hd/adjustment/treatment/VTreatmentAdjustmentSaline.cpp:58]: (style) The function 'doStop' is never used. -[sources/view/hd/adjustment/common/VCommonAdjustmentVitals.cpp:101]: (style) The function 'doTimeout' is never used. +[sources/view/hd/adjustment/common/VCommonAdjustmentVitals.cpp:98]: (style) The function 'doTimeout' is never used. [sources/view/VEventSpy.cpp:189]: (style) The function 'doTouchReset' is never used. [sources/view/hd/adjustment/treatment/VTreatmentAdjustmentRecirculate.cpp:75]: (style) The function 'doTreatmentEnd' is never used. [sources/view/hd/alarm/VAlarmStatus.cpp:55]: (style) The function 'doUserActionEnd' is never used. @@ -83,6 +82,10 @@ [sources/utility/types.cpp:28]: (style) The function 'floatCompare' is never used. [sources/utility/types.cpp:44]: (style) The function 'getBits' is never used. [sources/storage/FileHandler.cpp:166]: (style) The function 'removeFiles' is never used. -[sources/view/settings/VNetworkModel.cpp:167]: (style) The function 'roleNames' is never used. +[sources/bluetooth/BluetoothInterface.cpp:1169]: (style) The function 'requestBattery' is never used. +[sources/bluetooth/BluetoothInterface.cpp:1156]: (style) The function 'requestInformation' is never used. +[sources/bluetooth/BluetoothInterface.cpp:1137]: (style) The function 'requestMeasurements' is never used. +[sources/view/settings/VBluetooth.cpp:79]: (style) The function 'roleNames' is never used. +[sources/bluetooth/BluetoothInterface.cpp:794]: (style) The function 'stopScan' is never used. [sources/MainTimer.cpp:116]: (style) The function 'timerEvent' is never used. (information) Cppcheck cannot find all the include files. Cppcheck can check the code without the include files found. But the results will probably be more accurate if all the include files are found. Please check your project's include directories and add all of them as include directories for Cppcheck. To see what files Cppcheck cannot find use --check-config.