Index: sources/canbus/MessageDispatcher.cpp =================================================================== diff -u -r27cc308ff5113a9386899d3c8f8b29962a8498e1 -r79e076cece4ba503be6c3834eb68d1e5cb1b882f --- sources/canbus/MessageDispatcher.cpp (.../MessageDispatcher.cpp) (revision 27cc308ff5113a9386899d3c8f8b29962a8498e1) +++ sources/canbus/MessageDispatcher.cpp (.../MessageDispatcher.cpp) (revision 79e076cece4ba503be6c3834eb68d1e5cb1b882f) @@ -75,7 +75,7 @@ */ void MessageDispatcher::quit() { - // coco begin validated: Application termination is not correctly done in coco!!! + // disabled coco begin validated: Application termination is not correctly done in coco!!! // it has been tested and works perfectly fine in normal run. quitThread(); // validated } @@ -137,7 +137,7 @@ */ void MessageDispatcher::quitThread() { - // coco begin validated: Application termination is not correctly done in coco!!! + // disabled coco begin validated: Application termination is not correctly done in coco!!! // it has been tested and works perfectly fine in normal run. if ( ! _thread ) return; @@ -160,7 +160,7 @@ void MessageDispatcher::onFrameReceive(Can_Id vCan_Id, const QByteArray &vPayload) { // Append a message to the list - // coco begin validated: if empty (first condition) is true, it must never check for the complete (second condition) + // disabled coco begin validated: if empty (first condition) is true, it must never check for the complete (second condition) // because if the list is empty there is no last() item if (_messageList[vCan_Id].isEmpty() || _messageList[vCan_Id].last().isComplete()) { // coco end @@ -205,7 +205,7 @@ */ void MessageDispatcher::onFailedTransmit(Sequence vSequence) { - // coco begin validated: Is a placeholder and has not been implemented yet + // disabled coco begin validated: Is a placeholder and has not been implemented yet emit didFailedTransmit(vSequence); } // coco end @@ -360,7 +360,7 @@ * \param vData - Data model contains the user acknowledge request information. * \return void */ -/* // coco begin validated: Manually tested. This model class is a placeholder and there is no use case for this now. +/* // disabled coco begin validated: Manually tested. This model class is a placeholder and there is no use case for this now. void MessageDispatcher::onAdjustment(const AlarmClearedConditionRequestData &vData) { QVariantList mData; @@ -800,7 +800,7 @@ #endif } - // coco begin validated: Has been tested manually but in this function this cannot be false because the message interpreter is doing the same validation. + // disabled coco begin validated: Has been tested manually but in this function this cannot be false because the message interpreter is doing the same validation. // still checking here in case the logic has changed therefore buildFrame should still validate the message for developer safety. if ( ! _builder.buildFrames(vActionId, mData, frameList, mSequence) ) { LOG_DEBUG(QString("Incorrect Message cannot be built")); // TODO : LogInfo Improvement @@ -933,7 +933,7 @@ checkAcknowTransmit(vMessage, srcText); // then if needs acknow send it immediately. } - // coco begin validated: Has been validated manually. If MessageInterpreter::interpretMessage fails, this also returns false + // disabled coco begin validated: Has been validated manually. If MessageInterpreter::interpretMessage fails, this also returns false if ( _interpreter.interpretMessage( vMessage, mData ) ) { ok = true; emit didActionReceive(vMessage.actionId, mData); @@ -951,7 +951,7 @@ */ Sequence MessageDispatcher::rxCount() { - // coco begin validated: has been manually validated since it requires so many received messages to reset the seq + // disabled coco begin validated: has been manually validated since it requires so many received messages to reset the seq if ( _rxSequence < SEQUENCE_MAX ) { ++_rxSequence; } else { @@ -968,7 +968,7 @@ */ Sequence MessageDispatcher::txCount() { - // coco begin validated: has been manually validated since it requires so many received messages to reset the seq + // disabled coco begin validated: has been manually validated since it requires so many received messages to reset the seq if ( _txSequence < SEQUENCE_MAX ) { ++_txSequence; } else {