Index: firmware/App/Controllers/Thermistors.c =================================================================== diff -u -ra5fcb6fc6b04e8940e3c38be453ad8ff9168a616 -r9ce06772b2f651c57144327e6cbf886e2bc22dee --- firmware/App/Controllers/Thermistors.c (.../Thermistors.c) (revision a5fcb6fc6b04e8940e3c38be453ad8ff9168a616) +++ firmware/App/Controllers/Thermistors.c (.../Thermistors.c) (revision 9ce06772b2f651c57144327e6cbf886e2bc22dee) @@ -234,7 +234,7 @@ // If the values are out of range, raise an alarm if ( temperature < MIN_ALLOWED_TEMPERATURE || temperature >= MAX_ALLOWED_TEMPERATURE ) { - //SET_ALARM_WITH_2_F32_DATA( ALARM_ID_DG_THERMISOTRS_TEMPERATURE_OUT_OF_RANGE, thermistor, temperature ); + SET_ALARM_WITH_2_F32_DATA( ALARM_ID_DG_THERMISTORS_TEMPERATURE_OUT_OF_RANGE, thermistor, temperature ); // If any thermistor/sensor is not in range, POST has failed thermistorsSelfTestReslt = SELF_TEST_STATUS_FAILED; } @@ -321,12 +321,9 @@ for ( thermistor = THERMISTOR_ONBOARD_NTC; thermistor < NUM_OF_THERMISTORS; thermistor++ ) { temperature = getThermistorTemperatureValue( thermistor ); + BOOL const isTempOutOfRange = ( temperature >= MAX_ALLOWED_TEMPERATURE ) && ( temperature < MIN_ALLOWED_TEMPERATURE ); - BOOL isTempOutOfUpperRange = temperature >= MAX_ALLOWED_TEMPERATURE; - BOOL isTempOutOfLowerRange = temperature < MIN_ALLOWED_TEMPERATURE; - - checkPersistentAlarm( PERSISTENT_ALARM_THERMISTOR_TEMPERATURE_OUT_OF_RANGE, isTempOutOfLowerRange, temperature, MIN_ALLOWED_TEMPERATURE ); - checkPersistentAlarm( PERSISTENT_ALARM_THERMISTOR_TEMPERATURE_OUT_OF_RANGE, isTempOutOfUpperRange, temperature, MAX_ALLOWED_TEMPERATURE ); + checkPersistentAlarm( ALARM_ID_DG_THERMISTORS_TEMPERATURE_OUT_OF_RANGE, isTempOutOfRange, temperature, MAX_ALLOWED_TEMPERATURE ); } }