Index: results/cppcheckError.csv =================================================================== diff -u -r0c61042b352abf8a54943a4c91a4c190442e07ee -rfeb93744f73bc0a3d58841bb02bd05c38357f35d --- results/cppcheckError.csv (.../cppcheckError.csv) (revision 0c61042b352abf8a54943a4c91a4c190442e07ee) +++ results/cppcheckError.csv (.../cppcheckError.csv) (revision feb93744f73bc0a3d58841bb02bd05c38357f35d) @@ -1,20 +1,21 @@ File, Line No., Severity, Issue, Description dgfirmware/firmware/App/Controllers/DrainPump.c,166,style,unreadVariable,Variable 'drnPumpSpd' is assigned a value that is never used. +dgfirmware/firmware/App/Controllers/Fans.c,222,style,redundantAssignment,Variable 'state' is reassigned a value before the old one has been used. +dgfirmware/firmware/App/Controllers/Fans.c,318,style,redundantAssignment,Variable 'temperature' is reassigned a value before the old one has been used. dgfirmware/firmware/App/Controllers/ROPump.c,338,style,unreadVariable,Variable 'tgtPres' is assigned a value that is never used. dgfirmware/firmware/App/Controllers/ROPump.c,339,style,unreadVariable,Variable 'actPres' is assigned a value that is never used. dgfirmware/firmware/App/Controllers/ROPump.c,340,style,unusedVariable,Unused variable: newPWM -dgfirmware/firmware/App/Controllers/TemperatureSensors.c,528,style,knownConditionTrueFalse,Condition 'fpgaError==0' is always true -dgfirmware/firmware/App/Controllers/TemperatureSensors.c,525,style,redundantAssignment,Variable 'isADCValid' is reassigned a value before the old one has been used. +dgfirmware/firmware/App/Controllers/TemperatureSensors.c,575,style,redundantAssignment,Variable 'isADCValid' is reassigned a value before the old one has been used. dgfirmware/firmware/App/Modes/ModeFill.c,163,style,redundantAssignment,Variable 'isInletWaterReady' is reassigned a value before the old one has been used. dgfirmware/firmware/App/Modes/ModeFill.c,199,style,redundantAssignment,Variable 'isDialysateProductionGood' is reassigned a value before the old one has been used. dgfirmware/firmware/App/Modes/ModeFill.c,231,style,redundantAssignment,Variable 'isDialysateConductivityBad' is reassigned a value before the old one has been used. dgfirmware/firmware/App/Services/Interrupts.c,172,style,variableScope,The scope of the variable 'debugStr' can be reduced. dgfirmware/firmware/App/Services/PIControllers.c,76,style,variableScope,The scope of the variable 'controller' can be reduced. dgfirmware/firmware/App/Services/Reservoirs.c,269,style,redundantAssignment,Variable 'result' is reassigned a value before the old one has been used. dgfirmware/firmware/FWCommon/FlashDrvr/Fapi_UserDefinedFunctions.c,0,information,toomanyconfigs,Too many #ifdef configurations - cppcheck only checks 12 of 21 configurations. Use --force to check all configurations. -dgfirmware/firmware/FWCommon/NVDataMgmt.c,1526,style,variableScope,The scope of the variable 'quotient' can be reduced. -dgfirmware/firmware/FWCommon/NVDataMgmt.c,1527,style,variableScope,The scope of the variable 'modulus' can be reduced. -dgfirmware/firmware/FWCommon/NVDataMgmt.c,1530,style,variableScope,The scope of the variable 'i' can be reduced. +dgfirmware/firmware/FWCommon/NVDataMgmt.c,1566,style,variableScope,The scope of the variable 'quotient' can be reduced. +dgfirmware/firmware/FWCommon/NVDataMgmt.c,1567,style,variableScope,The scope of the variable 'modulus' can be reduced. +dgfirmware/firmware/FWCommon/NVDataMgmt.c,1570,style,variableScope,The scope of the variable 'i' can be reduced. dgfirmware/firmware/FWCommon/RTC.c,1195,style,redundantAssignment,Variable 'result' is reassigned a value before the old one has been used. dgfirmware/firmware/FWCommon/RTC.c,782,style,variableScope,The scope of the variable 'decimalHigh' can be reduced. dgfirmware/firmware/FWCommon/RTC.c,783,style,variableScope,The scope of the variable 'decimalLow' can be reduced. @@ -29,57 +30,60 @@ dgfirmware/firmware/App/Services/Interrupts.c,312,style,unusedFunction,The function 'dmaGroupANotification' is never used. dgfirmware/firmware/App/Services/AlarmMgmt.c,70,style,unusedFunction,The function 'execAlarmMgmt' is never used. dgfirmware/firmware/App/Controllers/DrainPump.c,381,style,unusedFunction,The function 'execDrainPumpTest' is never used. -dgfirmware/firmware/FWCommon/NVDataMgmt.c,736,style,unusedFunction,The function 'execNVDataMgmt' is never used. -dgfirmware/firmware/FWCommon/NVDataMgmt.c,615,style,unusedFunction,The function 'execNVDataMgmtSelfTest' is never used. +dgfirmware/firmware/FWCommon/NVDataMgmt.c,776,style,unusedFunction,The function 'execNVDataMgmt' is never used. +dgfirmware/firmware/FWCommon/NVDataMgmt.c,655,style,unusedFunction,The function 'execNVDataMgmtSelfTest' is never used. dgfirmware/firmware/App/Controllers/ROPump.c,482,style,unusedFunction,The function 'execROPumpTest' is never used. dgfirmware/firmware/FWCommon/RTC.c,364,style,unusedFunction,The function 'execRTC' is never used. dgfirmware/firmware/FWCommon/Accel.c,665,style,unusedFunction,The function 'getAccelCalibration' is never used. -dgfirmware/firmware/FWCommon/NVDataMgmt.c,724,style,unusedFunction,The function 'getBootloaderFlag' is never used. +dgfirmware/firmware/FWCommon/NVDataMgmt.c,764,style,unusedFunction,The function 'getBootloaderFlag' is never used. dgfirmware/firmware/FWCommon/Utilities.c,285,style,unusedFunction,The function 'getCriticalData' is never used. dgfirmware/firmware/App/Modes/ModeChemicalDisinfect.c,94,style,unusedFunction,The function 'getCurrentChemicalDisinfectState' is never used. dgfirmware/firmware/App/Modes/ModeDrain.c,139,style,unusedFunction,The function 'getCurrentDrainState' is never used. dgfirmware/firmware/App/Modes/ModeFault.c,88,style,unusedFunction,The function 'getCurrentFaultState' is never used. dgfirmware/firmware/App/Modes/ModeFlush.c,92,style,unusedFunction,The function 'getCurrentFlushState' is never used. dgfirmware/firmware/App/Modes/ModeHeatDisinfect.c,93,style,unusedFunction,The function 'getCurrentHeatDisinfectState' is never used. -dgfirmware/firmware/App/Modes/ModeInitPOST.c,225,style,unusedFunction,The function 'getCurrentInitAndPOSTState' is never used. +dgfirmware/firmware/App/Modes/ModeInitPOST.c,241,style,unusedFunction,The function 'getCurrentInitAndPOSTState' is never used. dgfirmware/firmware/App/Modes/ModeService.c,88,style,unusedFunction,The function 'getCurrentServiceState' is never used. dgfirmware/firmware/App/Modes/ModeSolo.c,118,style,unusedFunction,The function 'getCurrentSoloState' is never used. dgfirmware/firmware/App/Modes/ModeStandby.c,234,style,unusedFunction,The function 'getCurrentStandbyState' is never used. -dgfirmware/firmware/FWCommon/NVDataMgmt.c,595,style,unusedFunction,The function 'getDisinfectionDate' is never used. -dgfirmware/firmware/FWCommon/NVDataMgmt.c,332,style,unusedFunction,The function 'getMfgData' is never used. +dgfirmware/firmware/FWCommon/NVDataMgmt.c,635,style,unusedFunction,The function 'getDisinfectionDate' is never used. +dgfirmware/firmware/App/Controllers/Fans.c,190,style,unusedFunction,The function 'getMeasuredFanRPM' is never used. +dgfirmware/firmware/FWCommon/NVDataMgmt.c,340,style,unusedFunction,The function 'getMfgData' is never used. dgfirmware/firmware/App/Services/PIControllers.c,188,style,unusedFunction,The function 'getPIControllerSignals' is never used. dgfirmware/firmware/FWCommon/RTC.c,422,style,unusedFunction,The function 'getRTCTimestamp' is never used. -dgfirmware/firmware/FWCommon/NVDataMgmt.c,425,style,unusedFunction,The function 'getServiceDate' is never used. -dgfirmware/firmware/FWCommon/NVDataMgmt.c,518,style,unusedFunction,The function 'getTreatmentTime' is never used. -dgfirmware/firmware/FWCommon/NVDataMgmt.c,555,style,unusedFunction,The function 'getWaterConsumption' is never used. -dgfirmware/firmware/FWCommon/NVDataMgmt.c,279,style,unusedFunction,The function 'initNVDataMgmt' is never used. -dgfirmware/firmware/App/Modes/ModeInitPOST.c,175,style,unusedFunction,The function 'isPOSTCompleted' is never used. -dgfirmware/firmware/App/Modes/ModeInitPOST.c,188,style,unusedFunction,The function 'isPOSTPassed' is never used. +dgfirmware/firmware/FWCommon/NVDataMgmt.c,465,style,unusedFunction,The function 'getServiceDate' is never used. +dgfirmware/firmware/FWCommon/NVDataMgmt.c,558,style,unusedFunction,The function 'getTreatmentTime' is never used. +dgfirmware/firmware/FWCommon/NVDataMgmt.c,595,style,unusedFunction,The function 'getWaterConsumption' is never used. +dgfirmware/firmware/App/Services/SystemCommMessages.c,1480,style,unusedFunction,The function 'handleTestROPumpSetPointOverrideRequest' is never used. +dgfirmware/firmware/FWCommon/NVDataMgmt.c,287,style,unusedFunction,The function 'initNVDataMgmt' is never used. +dgfirmware/firmware/App/Modes/ModeInitPOST.c,191,style,unusedFunction,The function 'isPOSTCompleted' is never used. +dgfirmware/firmware/App/Modes/ModeInitPOST.c,204,style,unusedFunction,The function 'isPOSTPassed' is never used. dgfirmware/firmware/App/Drivers/Comm.c,259,style,unusedFunction,The function 'isSCI2DMATransmitInProgress' is never used. dgfirmware/firmware/App/Drivers/SafetyShutdown.c,71,style,unusedFunction,The function 'isSafetyShutdownActivated' is never used. dgfirmware/firmware/App/Services/Interrupts.c,91,style,unusedFunction,The function 'phantomInterrupt' is never used. -dgfirmware/firmware/FWCommon/NVDataMgmt.c,471,style,unusedFunction,The function 'readLogData' is never used. +dgfirmware/firmware/FWCommon/NVDataMgmt.c,511,style,unusedFunction,The function 'readLogData' is never used. dgfirmware/firmware/FWCommon/Utilities.c,400,style,unusedFunction,The function 'resetCriticalData' is never used. dgfirmware/firmware/App/Services/Interrupts.c,113,style,unusedFunction,The function 'rtiNotification' is never used. dgfirmware/firmware/App/Services/Interrupts.c,242,style,unusedFunction,The function 'sciNotification' is never used. -dgfirmware/firmware/FWCommon/NVDataMgmt.c,703,style,unusedFunction,The function 'setBootloaderFlag' is never used. +dgfirmware/firmware/FWCommon/NVDataMgmt.c,743,style,unusedFunction,The function 'setBootloaderFlag' is never used. dgfirmware/firmware/App/Drivers/CPLD.c,122,style,unusedFunction,The function 'setCPLDLampBlue' is never used. dgfirmware/firmware/App/Drivers/CPLD.c,102,style,unusedFunction,The function 'setCPLDLampGreen' is never used. dgfirmware/firmware/App/Drivers/CPLD.c,142,style,unusedFunction,The function 'setCPLDLampRed' is never used. dgfirmware/firmware/FWCommon/Utilities.c,360,style,unusedFunction,The function 'setCriticalData' is never used. -dgfirmware/firmware/FWCommon/NVDataMgmt.c,570,style,unusedFunction,The function 'setDisinfectionDate' is never used. -dgfirmware/firmware/FWCommon/NVDataMgmt.c,315,style,unusedFunction,The function 'setMfgData' is never used. -dgfirmware/firmware/FWCommon/NVDataMgmt.c,400,style,unusedFunction,The function 'setServiceDate' is never used. -dgfirmware/firmware/FWCommon/NVDataMgmt.c,494,style,unusedFunction,The function 'setTreatmentTime' is never used. -dgfirmware/firmware/FWCommon/NVDataMgmt.c,532,style,unusedFunction,The function 'setWaterConsumption' is never used. +dgfirmware/firmware/FWCommon/NVDataMgmt.c,610,style,unusedFunction,The function 'setDisinfectionDate' is never used. +dgfirmware/firmware/FWCommon/NVDataMgmt.c,323,style,unusedFunction,The function 'setMfgData' is never used. +dgfirmware/firmware/FWCommon/NVDataMgmt.c,440,style,unusedFunction,The function 'setServiceDate' is never used. +dgfirmware/firmware/FWCommon/NVDataMgmt.c,534,style,unusedFunction,The function 'setTreatmentTime' is never used. +dgfirmware/firmware/FWCommon/NVDataMgmt.c,572,style,unusedFunction,The function 'setWaterConsumption' is never used. dgfirmware/firmware/App/Services/Reservoirs.c,242,style,unusedFunction,The function 'stopDrainCmd' is never used. dgfirmware/firmware/App/Services/Reservoirs.c,192,style,unusedFunction,The function 'stopFillCmd' is never used. +dgfirmware/firmware/FWCommon/NVDataMgmt.c,407,style,unusedFunction,The function 'testResetCalibrationData' is never used. dgfirmware/firmware/App/Services/Reservoirs.c,476,style,unusedFunction,The function 'testResetDGActiveReservoirOverride' is never used. dgfirmware/firmware/App/Services/Reservoirs.c,566,style,unusedFunction,The function 'testResetReservoirDrainVolumeMlOverride' is never used. dgfirmware/firmware/App/Services/Reservoirs.c,521,style,unusedFunction,The function 'testResetReservoirFillVolumeMlOverride' is never used. dgfirmware/firmware/App/Services/Reservoirs.c,455,style,unusedFunction,The function 'testSetDGActiveReservoirOverride' is never used. dgfirmware/firmware/App/Services/Reservoirs.c,544,style,unusedFunction,The function 'testSetReservoirDrainVolumeMlOverride' is never used. dgfirmware/firmware/App/Services/Reservoirs.c,499,style,unusedFunction,The function 'testSetReservoirFillVolumeMlOverride' is never used. dgfirmware/firmware/FWCommon/Utilities.c,161,style,unusedFunction,The function 'u32DiffWithWrap' is never used. -dgfirmware/firmware/FWCommon/NVDataMgmt.c,447,style,unusedFunction,The function 'writeLogData' is never used. +dgfirmware/firmware/FWCommon/NVDataMgmt.c,487,style,unusedFunction,The function 'writeLogData' is never used. ,,information,missingInclude,Cppcheck cannot find all the include files (use --check-config for details)