Index: results/cppcheckError.csv =================================================================== diff -u -r58774a3c53ca6c99c1a7cc2a2f6f2207ec603a11 -r88f28230d288947ba84840b967e95b32e3deffaa --- results/cppcheckError.csv (.../cppcheckError.csv) (revision 58774a3c53ca6c99c1a7cc2a2f6f2207ec603a11) +++ results/cppcheckError.csv (.../cppcheckError.csv) (revision 88f28230d288947ba84840b967e95b32e3deffaa) @@ -1,15 +1,13 @@ File, Line No., Severity, Issue, Description -dgfirmware/firmware/App/Controllers/DrainPump.c,166,style,unreadVariable,Variable 'drnPumpSpd' is assigned a value that is never used. -dgfirmware/firmware/App/Controllers/ROPump.c,338,style,unreadVariable,Variable 'tgtPres' is assigned a value that is never used. -dgfirmware/firmware/App/Controllers/ROPump.c,339,style,unreadVariable,Variable 'actPres' is assigned a value that is never used. -dgfirmware/firmware/App/Controllers/ROPump.c,340,style,unusedVariable,Unused variable: newPWM -dgfirmware/firmware/App/Controllers/TemperatureSensors.c,529,style,knownConditionTrueFalse,Condition 'fpgaError==0' is always true -dgfirmware/firmware/App/Controllers/TemperatureSensors.c,526,style,redundantAssignment,Variable 'isADCValid' is reassigned a value before the old one has been used. -dgfirmware/firmware/App/Modes/ModeFill.c,163,style,redundantAssignment,Variable 'isInletWaterReady' is reassigned a value before the old one has been used. +dgfirmware/firmware/App/Controllers/Fans.c,222,style,redundantAssignment,Variable 'state' is reassigned a value before the old one has been used. +dgfirmware/firmware/App/Controllers/Fans.c,318,style,redundantAssignment,Variable 'temperature' is reassigned a value before the old one has been used. +dgfirmware/firmware/App/Controllers/TemperatureSensors.c,578,style,redundantAssignment,Variable 'isADCValid' is reassigned a value before the old one has been used. +dgfirmware/firmware/App/Modes/ModeFill.c,270,style,unreadVariable,Variable 'isROPumpFlowRateOutOfRange' is assigned a value that is never used. +dgfirmware/firmware/App/Modes/ModeFill.c,164,style,redundantAssignment,Variable 'isInletWaterReady' is reassigned a value before the old one has been used. dgfirmware/firmware/App/Modes/ModeFill.c,199,style,redundantAssignment,Variable 'isDialysateProductionGood' is reassigned a value before the old one has been used. dgfirmware/firmware/App/Modes/ModeFill.c,231,style,redundantAssignment,Variable 'isDialysateConductivityBad' is reassigned a value before the old one has been used. dgfirmware/firmware/App/Services/Interrupts.c,172,style,variableScope,The scope of the variable 'debugStr' can be reduced. -dgfirmware/firmware/App/Services/PIControllers.c,76,style,variableScope,The scope of the variable 'controller' can be reduced. +dgfirmware/firmware/App/Services/PIControllers.c,87,style,variableScope,The scope of the variable 'controller' can be reduced. dgfirmware/firmware/App/Services/Reservoirs.c,269,style,redundantAssignment,Variable 'result' is reassigned a value before the old one has been used. dgfirmware/firmware/FWCommon/FlashDrvr/Fapi_UserDefinedFunctions.c,0,information,toomanyconfigs,Too many #ifdef configurations - cppcheck only checks 12 of 21 configurations. Use --force to check all configurations. dgfirmware/firmware/FWCommon/NVDataMgmt.c,1566,style,variableScope,The scope of the variable 'quotient' can be reduced. @@ -28,10 +26,9 @@ dgfirmware/firmware/App/Services/Interrupts.c,148,style,unusedFunction,The function 'canMessageNotification' is never used. dgfirmware/firmware/App/Services/Interrupts.c,312,style,unusedFunction,The function 'dmaGroupANotification' is never used. dgfirmware/firmware/App/Services/AlarmMgmt.c,70,style,unusedFunction,The function 'execAlarmMgmt' is never used. -dgfirmware/firmware/App/Controllers/DrainPump.c,381,style,unusedFunction,The function 'execDrainPumpTest' is never used. dgfirmware/firmware/FWCommon/NVDataMgmt.c,776,style,unusedFunction,The function 'execNVDataMgmt' is never used. dgfirmware/firmware/FWCommon/NVDataMgmt.c,655,style,unusedFunction,The function 'execNVDataMgmtSelfTest' is never used. -dgfirmware/firmware/App/Controllers/ROPump.c,482,style,unusedFunction,The function 'execROPumpTest' is never used. +dgfirmware/firmware/App/Controllers/ROPump.c,419,style,unusedFunction,The function 'execROPumpTest' is never used. dgfirmware/firmware/FWCommon/RTC.c,364,style,unusedFunction,The function 'execRTC' is never used. dgfirmware/firmware/FWCommon/Accel.c,665,style,unusedFunction,The function 'getAccelCalibration' is never used. dgfirmware/firmware/FWCommon/NVDataMgmt.c,764,style,unusedFunction,The function 'getBootloaderFlag' is never used. @@ -41,22 +38,21 @@ dgfirmware/firmware/App/Modes/ModeFault.c,88,style,unusedFunction,The function 'getCurrentFaultState' is never used. dgfirmware/firmware/App/Modes/ModeFlush.c,92,style,unusedFunction,The function 'getCurrentFlushState' is never used. dgfirmware/firmware/App/Modes/ModeHeatDisinfect.c,93,style,unusedFunction,The function 'getCurrentHeatDisinfectState' is never used. -dgfirmware/firmware/App/Modes/ModeInitPOST.c,233,style,unusedFunction,The function 'getCurrentInitAndPOSTState' is never used. +dgfirmware/firmware/App/Modes/ModeInitPOST.c,250,style,unusedFunction,The function 'getCurrentInitAndPOSTState' is never used. dgfirmware/firmware/App/Modes/ModeService.c,88,style,unusedFunction,The function 'getCurrentServiceState' is never used. dgfirmware/firmware/App/Modes/ModeSolo.c,118,style,unusedFunction,The function 'getCurrentSoloState' is never used. dgfirmware/firmware/App/Modes/ModeStandby.c,234,style,unusedFunction,The function 'getCurrentStandbyState' is never used. dgfirmware/firmware/FWCommon/NVDataMgmt.c,635,style,unusedFunction,The function 'getDisinfectionDate' is never used. +dgfirmware/firmware/App/Controllers/Fans.c,190,style,unusedFunction,The function 'getMeasuredFanRPM' is never used. dgfirmware/firmware/FWCommon/NVDataMgmt.c,340,style,unusedFunction,The function 'getMfgData' is never used. -dgfirmware/firmware/App/Services/PIControllers.c,188,style,unusedFunction,The function 'getPIControllerSignals' is never used. +dgfirmware/firmware/App/Services/PIControllers.c,209,style,unusedFunction,The function 'getPIControllerSignals' is never used. dgfirmware/firmware/FWCommon/RTC.c,422,style,unusedFunction,The function 'getRTCTimestamp' is never used. dgfirmware/firmware/FWCommon/NVDataMgmt.c,465,style,unusedFunction,The function 'getServiceDate' is never used. dgfirmware/firmware/FWCommon/NVDataMgmt.c,558,style,unusedFunction,The function 'getTreatmentTime' is never used. dgfirmware/firmware/FWCommon/NVDataMgmt.c,595,style,unusedFunction,The function 'getWaterConsumption' is never used. -dgfirmware/firmware/App/Services/SystemCommMessages.c,1549,style,unusedFunction,The function 'handleTestDrainPumpSetPointOverrideRequest' is never used. -dgfirmware/firmware/App/Services/SystemCommMessages.c,1453,style,unusedFunction,The function 'handleTestROPumpSetPointOverrideRequest' is never used. dgfirmware/firmware/FWCommon/NVDataMgmt.c,287,style,unusedFunction,The function 'initNVDataMgmt' is never used. -dgfirmware/firmware/App/Modes/ModeInitPOST.c,183,style,unusedFunction,The function 'isPOSTCompleted' is never used. -dgfirmware/firmware/App/Modes/ModeInitPOST.c,196,style,unusedFunction,The function 'isPOSTPassed' is never used. +dgfirmware/firmware/App/Modes/ModeInitPOST.c,200,style,unusedFunction,The function 'isPOSTCompleted' is never used. +dgfirmware/firmware/App/Modes/ModeInitPOST.c,213,style,unusedFunction,The function 'isPOSTPassed' is never used. dgfirmware/firmware/App/Drivers/Comm.c,259,style,unusedFunction,The function 'isSCI2DMATransmitInProgress' is never used. dgfirmware/firmware/App/Drivers/SafetyShutdown.c,71,style,unusedFunction,The function 'isSafetyShutdownActivated' is never used. dgfirmware/firmware/App/Services/Interrupts.c,91,style,unusedFunction,The function 'phantomInterrupt' is never used.